* [PATCH] mmc: davinci: allow driver to work without DMA resource
@ 2013-01-31 8:20 Manjunathappa, Prakash
2013-02-01 6:57 ` Sekhar Nori
0 siblings, 1 reply; 3+ messages in thread
From: Manjunathappa, Prakash @ 2013-01-31 8:20 UTC (permalink / raw)
To: linux-mmc
Cc: cjb, davinci-linux-open-source, mporter, ido, gregkh,
Manjunathappa, Prakash
Do not return probe failure with missing DMA resources,
allow driver to work in PIO mode.
Tested on da850-evm.
Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
---
drivers/mmc/host/davinci_mmc.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 2063677..382b79d 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1190,13 +1190,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
if (!r)
- goto out;
- host->rxdma = r->start;
+ dev_warn(&pdev->dev, "DMA resource not specified\n");
+ else
+ host->rxdma = r->start;
r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
if (!r)
- goto out;
- host->txdma = r->start;
+ dev_warn(&pdev->dev, "DMA resource not specified\n");
+ else
+ host->txdma = r->start;
host->mem_res = mem;
host->base = ioremap(mem->start, mem_size);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: davinci: allow driver to work without DMA resource
2013-01-31 8:20 [PATCH] mmc: davinci: allow driver to work without DMA resource Manjunathappa, Prakash
@ 2013-02-01 6:57 ` Sekhar Nori
2013-02-04 13:27 ` Manjunathappa, Prakash
0 siblings, 1 reply; 3+ messages in thread
From: Sekhar Nori @ 2013-02-01 6:57 UTC (permalink / raw)
To: Manjunathappa, Prakash
Cc: linux-mmc, mporter, davinci-linux-open-source, gregkh, cjb
On 1/31/2013 1:50 PM, Manjunathappa, Prakash wrote:
> Do not return probe failure with missing DMA resources,
> allow driver to work in PIO mode.
> Tested on da850-evm.
It will be nice to mention what exactly was tested. rootfs mount? file
create/deletion? mount/unmount?
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> ---
> drivers/mmc/host/davinci_mmc.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 2063677..382b79d 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1190,13 +1190,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
>
> r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
> if (!r)
> - goto out;
> - host->rxdma = r->start;
> + dev_warn(&pdev->dev, "DMA resource not specified\n");
Why not be specific and call it "RX DMA" instead. Anyone who gets this
error will have to do that anyway since you have now got two identical
error messages.
> + else
> + host->rxdma = r->start;
>
> r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
> if (!r)
> - goto out;
> - host->txdma = r->start;
> + dev_warn(&pdev->dev, "DMA resource not specified\n");
"TX DMA" here.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] mmc: davinci: allow driver to work without DMA resource
2013-02-01 6:57 ` Sekhar Nori
@ 2013-02-04 13:27 ` Manjunathappa, Prakash
0 siblings, 0 replies; 3+ messages in thread
From: Manjunathappa, Prakash @ 2013-02-04 13:27 UTC (permalink / raw)
To: Nori, Sekhar
Cc: linux-mmc@vger.kernel.org, Porter, Matt,
davinci-linux-open-source@linux.davincidsp.com,
gregkh@linuxfoundation.org, cjb@laptop.org
Hi Sekhar,
On Fri, Feb 01, 2013 at 12:27:04, Nori, Sekhar wrote:
> On 1/31/2013 1:50 PM, Manjunathappa, Prakash wrote:
> > Do not return probe failure with missing DMA resources,
> > allow driver to work in PIO mode.
> > Tested on da850-evm.
>
> It will be nice to mention what exactly was tested. rootfs mount? file
> create/deletion? mount/unmount?
>
Agreed, will add testing information.
> > Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> > ---
> > drivers/mmc/host/davinci_mmc.c | 10 ++++++----
> > 1 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> > index 2063677..382b79d 100644
> > --- a/drivers/mmc/host/davinci_mmc.c
> > +++ b/drivers/mmc/host/davinci_mmc.c
> > @@ -1190,13 +1190,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
> >
> > r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
> > if (!r)
> > - goto out;
> > - host->rxdma = r->start;
> > + dev_warn(&pdev->dev, "DMA resource not specified\n");
>
> Why not be specific and call it "RX DMA" instead. Anyone who gets this
> error will have to do that anyway since you have now got two identical
> error messages.
>
Agree, I will specify.
> > + else
> > + host->rxdma = r->start;
> >
> > r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
> > if (!r)
> > - goto out;
> > - host->txdma = r->start;
> > + dev_warn(&pdev->dev, "DMA resource not specified\n");
>
> "TX DMA" here.
>
Agree to fix here also.
Thanks,
Prakash
> Thanks,
> Sekhar
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-04 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-31 8:20 [PATCH] mmc: davinci: allow driver to work without DMA resource Manjunathappa, Prakash
2013-02-01 6:57 ` Sekhar Nori
2013-02-04 13:27 ` Manjunathappa, Prakash
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.