From: Vlad Yasevich <vyasevic@redhat.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH v9 net-next 02/12] bridge: Validate that vlan is permitted on ingress
Date: Fri, 01 Feb 2013 21:13:11 -0500 [thread overview]
Message-ID: <510C7637.7080102@redhat.com> (raw)
In-Reply-To: <CAHXqBFLTaPbReQh-vgc_kbBbUtEWOFyE2oq85boWoHFD2+Tm9w@mail.gmail.com>
On 02/01/2013 08:04 PM, Michał Mirosław wrote:
> 2013/2/1 Vlad Yasevich <vyasevic@redhat.com>:
>> When a frame arrives on a port or transmitted by the bridge,
>> if we have VLANs configured, validate that a given VLAN is allowed
>> to enter the bridge.
> [...]
>> +static inline struct net_port_vlans *br_get_vlan_info(
>> + const struct net_bridge *br)
>> +{
>> + return rcu_dereference(br->vlan_info);
>> +}
>> +
>> +static inline struct net_port_vlans *nbp_get_vlan_info(
>> + const struct net_bridge_port *p)
>> +{
>> + return rcu_dereference(p->vlan_info);
>> +}
>
> Those should go to patch #1.
They are not needed till here. I thought it would read/review better if
I kept it together.
-vlad
>
> Best Regards,
> Michał Mirosław
>
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vyasevic@redhat.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: shemminger@vyatta.com, bridge@lists.linux-foundation.org,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v9 net-next 02/12] bridge: Validate that vlan is permitted on ingress
Date: Fri, 01 Feb 2013 21:13:11 -0500 [thread overview]
Message-ID: <510C7637.7080102@redhat.com> (raw)
In-Reply-To: <CAHXqBFLTaPbReQh-vgc_kbBbUtEWOFyE2oq85boWoHFD2+Tm9w@mail.gmail.com>
On 02/01/2013 08:04 PM, Michał Mirosław wrote:
> 2013/2/1 Vlad Yasevich <vyasevic@redhat.com>:
>> When a frame arrives on a port or transmitted by the bridge,
>> if we have VLANs configured, validate that a given VLAN is allowed
>> to enter the bridge.
> [...]
>> +static inline struct net_port_vlans *br_get_vlan_info(
>> + const struct net_bridge *br)
>> +{
>> + return rcu_dereference(br->vlan_info);
>> +}
>> +
>> +static inline struct net_port_vlans *nbp_get_vlan_info(
>> + const struct net_bridge_port *p)
>> +{
>> + return rcu_dereference(p->vlan_info);
>> +}
>
> Those should go to patch #1.
They are not needed till here. I thought it would read/review better if
I kept it together.
-vlad
>
> Best Regards,
> Michał Mirosław
>
next prev parent reply other threads:[~2013-02-02 2:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 20:01 [Bridge] [PATCH v9 net-next 00/12] Add basic VLAN support to bridges Vlad Yasevich
2013-02-01 20:01 ` Vlad Yasevich
2013-02-01 20:01 ` [Bridge] [PATCH v9 net-next 01/12] bridge: Add vlan filtering infrastructure Vlad Yasevich
2013-02-01 20:01 ` Vlad Yasevich
2013-02-02 1:04 ` [Bridge] " Michał Mirosław
2013-02-02 1:04 ` Michał Mirosław
2013-02-02 2:11 ` [Bridge] " Vlad Yasevich
2013-02-02 2:11 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 02/12] bridge: Validate that vlan is permitted on ingress Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-02 1:04 ` [Bridge] " Michał Mirosław
2013-02-02 1:04 ` Michał Mirosław
2013-02-02 2:13 ` Vlad Yasevich [this message]
2013-02-02 2:13 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 03/12] bridge: Verify that a vlan is allowed to egress on give port Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 04/12] bridge: Add netlink interface to configure vlans on bridge ports Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 05/12] bridge: Add the ability to configure pvid Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-02 1:04 ` [Bridge] " Michał Mirosław
2013-02-02 1:04 ` Michał Mirosław
2013-02-02 1:15 ` [Bridge] " Michał Mirosław
2013-02-02 1:15 ` Michał Mirosław
2013-02-02 2:22 ` [Bridge] " Vlad Yasevich
2013-02-02 2:22 ` Vlad Yasevich
2013-02-03 14:49 ` [Bridge] " Michał Mirosław
2013-02-03 14:49 ` Michał Mirosław
2013-02-03 15:20 ` [Bridge] " Michał Mirosław
2013-02-03 15:20 ` Michał Mirosław
2013-02-04 16:59 ` [Bridge] " Vlad Yasevich
2013-02-04 16:59 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 06/12] bridge: Implement vlan ingress/egress policy Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 07/12] bridge: Add vlan to unicast fdb entries Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 08/12] bridge: Add vlan id to multicast groups Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 09/12] bridge: Add vlan support to static neighbors Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 10/12] bridge: Add vlan support for local fdb entries Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 11/12] bridge: Dump vlan information from a bridge port Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-01 20:02 ` [Bridge] [PATCH v9 net-next 12/12] bridge: Separate egress policy bitmap Vlad Yasevich
2013-02-01 20:02 ` Vlad Yasevich
2013-02-04 16:24 ` [Bridge] [PATCH v9 net-next 00/12] Add basic VLAN support to bridges Stephen Hemminger
2013-02-04 16:24 ` Stephen Hemminger
2013-02-04 16:58 ` [Bridge] " Vlad Yasevich
2013-02-04 16:58 ` Vlad Yasevich
2013-02-07 22:48 ` [Bridge] " Vlad Yasevich
2013-02-07 22:48 ` Vlad Yasevich
2013-02-07 22:57 ` [Bridge] " Stephen Hemminger
2013-02-07 22:57 ` Stephen Hemminger
2013-02-07 23:00 ` [Bridge] " Vlad Yasevich
2013-02-07 23:00 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510C7637.7080102@redhat.com \
--to=vyasevic@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.