From: walter harms <wharms@bfs.de>
To: linux-ppp@vger.kernel.org
Subject: Re: [PATCH] ppp: ignore unrecognised radiusclient configuration directives
Date: Sat, 02 Feb 2013 09:49:34 +0000 [thread overview]
Message-ID: <510CE12E.1020900@bfs.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1208301919580.27411@e-smith.charlieb.ott.istop.com>
Normaly paul takes care of patches:
paulus@samba.org
re,
wh
Am 01.02.2013 20:35, schrieb Charlie Brady:
>
> Is anyone maintaining linux ppp? 2nd repost of this patch.
>
> On Fri, 23 Nov 2012, Charlie Brady wrote:
>
>>
>> Paul, did you just miss this, or are you waiting for some more
>> information? Or do we need David Skoll's input?
>>
>> This is relevant for RHEL6, BTW, where default freeradiusclient
>> configuration includes new 'bindaddr' keyword.
>>
>> On Thu, 30 Aug 2012, Charlie Brady wrote:
>>
>>> New versions of freeradius occasionally add configuration keywords.
>>> There's no reason that the pppd plugin should fail when that occurs.
>>>
>>> Signed-off-by: Charlie Brady <charlieb@budge.apana.org.au>
>>>
>>> --- ppp-2.4.5.rhel6/pppd/plugins/radius/config.c 2009-11-16 17:26:07.000000000 -0500
>>> +++ ppp-2.4.5/pppd/plugins/radius/config.c 2012-08-30 16:59:19.911025000 -0400
>>> @@ -216,8 +216,8 @@
>>> p[pos] = '\0';
>>>
>>> if ((option = find_option(p, OT_ANY)) = NULL) {
>>> - error("%s: line %d: unrecognized keyword: %s", filename, line, p);
>>> - return (-1);
>>> + warn("%s: line %d: unrecognized keyword: %s", filename, line, p);
>>> + continue;
>>> }
>>>
>>> if (option->status != ST_UNDEF) {
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-02-02 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 23:24 [PATCH] ppp: ignore unrecognised radiusclient configuration directives Charlie Brady
2012-11-23 16:40 ` Charlie Brady
2013-02-01 19:35 ` Charlie Brady
2013-02-02 9:49 ` walter harms [this message]
2013-02-03 2:28 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510CE12E.1020900@bfs.de \
--to=wharms@bfs.de \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.