* Re: [PATCH] ppp: ignore unrecognised radiusclient configuration directives
2012-08-30 23:24 [PATCH] ppp: ignore unrecognised radiusclient configuration directives Charlie Brady
@ 2012-11-23 16:40 ` Charlie Brady
2013-02-01 19:35 ` Charlie Brady
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Charlie Brady @ 2012-11-23 16:40 UTC (permalink / raw)
To: linux-ppp
Paul, did you just miss this, or are you waiting for some more
information? Or do we need David Skoll's input?
This is relevant for RHEL6, BTW, where default freeradiusclient
configuration includes new 'bindaddr' keyword.
On Thu, 30 Aug 2012, Charlie Brady wrote:
> New versions of freeradius occasionally add configuration keywords.
> There's no reason that the pppd plugin should fail when that occurs.
>
> Signed-off-by: Charlie Brady <charlieb@budge.apana.org.au>
>
> --- ppp-2.4.5.rhel6/pppd/plugins/radius/config.c 2009-11-16 17:26:07.000000000 -0500
> +++ ppp-2.4.5/pppd/plugins/radius/config.c 2012-08-30 16:59:19.911025000 -0400
> @@ -216,8 +216,8 @@
> p[pos] = '\0';
>
> if ((option = find_option(p, OT_ANY)) = NULL) {
> - error("%s: line %d: unrecognized keyword: %s", filename, line, p);
> - return (-1);
> + warn("%s: line %d: unrecognized keyword: %s", filename, line, p);
> + continue;
> }
>
> if (option->status != ST_UNDEF) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ppp: ignore unrecognised radiusclient configuration directives
2012-08-30 23:24 [PATCH] ppp: ignore unrecognised radiusclient configuration directives Charlie Brady
2012-11-23 16:40 ` Charlie Brady
@ 2013-02-01 19:35 ` Charlie Brady
2013-02-02 9:49 ` walter harms
2013-02-03 2:28 ` Paul Mackerras
3 siblings, 0 replies; 5+ messages in thread
From: Charlie Brady @ 2013-02-01 19:35 UTC (permalink / raw)
To: linux-ppp
Is anyone maintaining linux ppp? 2nd repost of this patch.
On Fri, 23 Nov 2012, Charlie Brady wrote:
>
> Paul, did you just miss this, or are you waiting for some more
> information? Or do we need David Skoll's input?
>
> This is relevant for RHEL6, BTW, where default freeradiusclient
> configuration includes new 'bindaddr' keyword.
>
> On Thu, 30 Aug 2012, Charlie Brady wrote:
>
> > New versions of freeradius occasionally add configuration keywords.
> > There's no reason that the pppd plugin should fail when that occurs.
> >
> > Signed-off-by: Charlie Brady <charlieb@budge.apana.org.au>
> >
> > --- ppp-2.4.5.rhel6/pppd/plugins/radius/config.c 2009-11-16 17:26:07.000000000 -0500
> > +++ ppp-2.4.5/pppd/plugins/radius/config.c 2012-08-30 16:59:19.911025000 -0400
> > @@ -216,8 +216,8 @@
> > p[pos] = '\0';
> >
> > if ((option = find_option(p, OT_ANY)) = NULL) {
> > - error("%s: line %d: unrecognized keyword: %s", filename, line, p);
> > - return (-1);
> > + warn("%s: line %d: unrecognized keyword: %s", filename, line, p);
> > + continue;
> > }
> >
> > if (option->status != ST_UNDEF) {
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ppp: ignore unrecognised radiusclient configuration directives
2012-08-30 23:24 [PATCH] ppp: ignore unrecognised radiusclient configuration directives Charlie Brady
2012-11-23 16:40 ` Charlie Brady
2013-02-01 19:35 ` Charlie Brady
@ 2013-02-02 9:49 ` walter harms
2013-02-03 2:28 ` Paul Mackerras
3 siblings, 0 replies; 5+ messages in thread
From: walter harms @ 2013-02-02 9:49 UTC (permalink / raw)
To: linux-ppp
Normaly paul takes care of patches:
paulus@samba.org
re,
wh
Am 01.02.2013 20:35, schrieb Charlie Brady:
>
> Is anyone maintaining linux ppp? 2nd repost of this patch.
>
> On Fri, 23 Nov 2012, Charlie Brady wrote:
>
>>
>> Paul, did you just miss this, or are you waiting for some more
>> information? Or do we need David Skoll's input?
>>
>> This is relevant for RHEL6, BTW, where default freeradiusclient
>> configuration includes new 'bindaddr' keyword.
>>
>> On Thu, 30 Aug 2012, Charlie Brady wrote:
>>
>>> New versions of freeradius occasionally add configuration keywords.
>>> There's no reason that the pppd plugin should fail when that occurs.
>>>
>>> Signed-off-by: Charlie Brady <charlieb@budge.apana.org.au>
>>>
>>> --- ppp-2.4.5.rhel6/pppd/plugins/radius/config.c 2009-11-16 17:26:07.000000000 -0500
>>> +++ ppp-2.4.5/pppd/plugins/radius/config.c 2012-08-30 16:59:19.911025000 -0400
>>> @@ -216,8 +216,8 @@
>>> p[pos] = '\0';
>>>
>>> if ((option = find_option(p, OT_ANY)) = NULL) {
>>> - error("%s: line %d: unrecognized keyword: %s", filename, line, p);
>>> - return (-1);
>>> + warn("%s: line %d: unrecognized keyword: %s", filename, line, p);
>>> + continue;
>>> }
>>>
>>> if (option->status != ST_UNDEF) {
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ppp: ignore unrecognised radiusclient configuration directives
2012-08-30 23:24 [PATCH] ppp: ignore unrecognised radiusclient configuration directives Charlie Brady
` (2 preceding siblings ...)
2013-02-02 9:49 ` walter harms
@ 2013-02-03 2:28 ` Paul Mackerras
3 siblings, 0 replies; 5+ messages in thread
From: Paul Mackerras @ 2013-02-03 2:28 UTC (permalink / raw)
To: linux-ppp
On Thu, Aug 30, 2012 at 07:24:00PM -0400, Charlie Brady wrote:
>
> New versions of freeradius occasionally add configuration keywords.
> There's no reason that the pppd plugin should fail when that occurs.
>
> Signed-off-by: Charlie Brady <charlieb@budge.apana.org.au>
Thanks, applied.
(By the way, your mailer changed the tabs to spaces.)
Paul.
^ permalink raw reply [flat|nested] 5+ messages in thread