From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: davinci: da850: add wdt OF_DEV_AUXDATA entry
Date: Mon, 04 Feb 2013 16:00:20 +0400 [thread overview]
Message-ID: <510FA2D4.7090807@mvista.com> (raw)
In-Reply-To: <510FA09F.7030604@ti.com>
Hello.
On 04-02-2013 15:50, Sekhar Nori wrote:
> Auxdata is not evm specific. This can instead be called da850_auxdata_lookup[].
> Also, I dont think it is necessary to add auxdata in a separate patch
> from dt nodes. So, I fixed these issues and came up with below patch. I
> tested basic wdt reboot. reboot command is still broken (with or
> without this patch). Can you please look at that?
> Thanks,
> Sekhar
> ----8<----
> From: "Kumar, Anil" <anilkumar.v@ti.com>
> Date: Thu, 24 Jan 2013 14:08:14 +0530
> Subject: [PATCH 1/1] ARM: davinci: da850: add wdt DT node
> Add da850 wdt DT node.
> Signed-off-by: Kumar, Anil <anilkumar.v@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
[...]
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 8dd15c0..2800090 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -88,6 +88,11 @@
> 19>;
> status = "disabled";
> };
> + wdt: wdt at 1c21000 {
> + compatible = "ti,davinci-wdt";
> + reg = <0x21000 0xfff>;
Not 0x1000? This is region size, not upper limit.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, "Kumar,
Anil" <anilkumar.v-l0cyMroinI0@public.gmane.org>,
hs-ynQEQJNshbs@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: davinci: da850: add wdt OF_DEV_AUXDATA entry
Date: Mon, 04 Feb 2013 16:00:20 +0400 [thread overview]
Message-ID: <510FA2D4.7090807@mvista.com> (raw)
In-Reply-To: <510FA09F.7030604-l0cyMroinI0@public.gmane.org>
Hello.
On 04-02-2013 15:50, Sekhar Nori wrote:
> Auxdata is not evm specific. This can instead be called da850_auxdata_lookup[].
> Also, I dont think it is necessary to add auxdata in a separate patch
> from dt nodes. So, I fixed these issues and came up with below patch. I
> tested basic wdt reboot. reboot command is still broken (with or
> without this patch). Can you please look at that?
> Thanks,
> Sekhar
> ----8<----
> From: "Kumar, Anil" <anilkumar.v-l0cyMroinI0@public.gmane.org>
> Date: Thu, 24 Jan 2013 14:08:14 +0530
> Subject: [PATCH 1/1] ARM: davinci: da850: add wdt DT node
> Add da850 wdt DT node.
> Signed-off-by: Kumar, Anil <anilkumar.v-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
[...]
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 8dd15c0..2800090 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -88,6 +88,11 @@
> 19>;
> status = "disabled";
> };
> + wdt: wdt@1c21000 {
> + compatible = "ti,davinci-wdt";
> + reg = <0x21000 0xfff>;
Not 0x1000? This is region size, not upper limit.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: "Kumar, Anil" <anilkumar.v@ti.com>,
davinci-linux-open-source@linux.davincidsp.com,
linux@arm.linux.org.uk, b-cousson@ti.com, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, hs@denx.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: davinci: da850: add wdt OF_DEV_AUXDATA entry
Date: Mon, 04 Feb 2013 16:00:20 +0400 [thread overview]
Message-ID: <510FA2D4.7090807@mvista.com> (raw)
In-Reply-To: <510FA09F.7030604@ti.com>
Hello.
On 04-02-2013 15:50, Sekhar Nori wrote:
> Auxdata is not evm specific. This can instead be called da850_auxdata_lookup[].
> Also, I dont think it is necessary to add auxdata in a separate patch
> from dt nodes. So, I fixed these issues and came up with below patch. I
> tested basic wdt reboot. reboot command is still broken (with or
> without this patch). Can you please look at that?
> Thanks,
> Sekhar
> ----8<----
> From: "Kumar, Anil" <anilkumar.v@ti.com>
> Date: Thu, 24 Jan 2013 14:08:14 +0530
> Subject: [PATCH 1/1] ARM: davinci: da850: add wdt DT node
> Add da850 wdt DT node.
> Signed-off-by: Kumar, Anil <anilkumar.v@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
[...]
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 8dd15c0..2800090 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -88,6 +88,11 @@
> 19>;
> status = "disabled";
> };
> + wdt: wdt@1c21000 {
> + compatible = "ti,davinci-wdt";
> + reg = <0x21000 0xfff>;
Not 0x1000? This is region size, not upper limit.
WBR, Sergei
next prev parent reply other threads:[~2013-02-04 12:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 8:38 [PATCH 0/2] ARM: davinci: da850: add wdt DT node Kumar, Anil
2013-01-24 8:38 ` Kumar, Anil
2013-01-24 8:38 ` Kumar, Anil
2013-01-24 8:38 ` [PATCH 1/2] " Kumar, Anil
2013-01-24 8:38 ` Kumar, Anil
2013-01-24 8:38 ` Kumar, Anil
2013-01-24 8:38 ` [PATCH 2/2] ARM: davinci: da850: add wdt OF_DEV_AUXDATA entry Kumar, Anil
2013-01-24 8:38 ` Kumar, Anil
2013-01-24 8:38 ` Kumar, Anil
2013-02-04 11:50 ` Sekhar Nori
2013-02-04 11:50 ` Sekhar Nori
2013-02-04 11:50 ` Sekhar Nori
2013-02-04 12:00 ` Sergei Shtylyov [this message]
2013-02-04 12:00 ` Sergei Shtylyov
2013-02-04 12:00 ` Sergei Shtylyov
2013-02-05 6:39 ` Kumar, Anil
2013-02-05 6:39 ` Kumar, Anil
2013-02-05 6:39 ` Kumar, Anil
2013-02-05 1:51 ` Kumar, Anil
2013-02-05 1:51 ` Kumar, Anil
2013-02-05 1:51 ` Kumar, Anil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510FA2D4.7090807@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.