All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jon-hunter@ti.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Vaibhav Bedia <vaibhav.bedia@ti.com>,
	linux-omap <linux-omap@vger.kernel.org>,
	linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] ARM: OMAP2+: Simplify system timers definitions
Date: Mon, 4 Feb 2013 09:27:43 -0600	[thread overview]
Message-ID: <510FD36F.5090603@ti.com> (raw)
In-Reply-To: <1359565471-30721-5-git-send-email-jon-hunter@ti.com>


On 01/30/2013 11:04 AM, Jon Hunter wrote:
> There is a lot of redundancy in the definitions for the various system
> timers for OMAP2+ devices. For example, the omap3_am33xx_gptimer_timer_init()
> function is the same as the omap3_gp_gptimer_timer_init() function and the
> function omap2_sync32k_timer_init() can be re-used for OMAP4/5 devices.

After further testing, I have found that using the
omap2_sync32k_timer_init() for omap4/5 devices does not work for the
case where we boot with boot parameter "clocksource=gp_timer". The
problem is omap4/5 devices, unlike omap2/3 devices, does not have a
clock alias for "timer_sys_ck" with NULL as the device name. Therefore
we fail to find the parent clock and boot fails.

So I am going to update this patch so that omap4 and omap5 both use
omap4_sync32k_timer_init() and just get rid of the extra function
defined for omap5.

Hope this makes sense.

Cheers
Jon

WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: OMAP2+: Simplify system timers definitions
Date: Mon, 4 Feb 2013 09:27:43 -0600	[thread overview]
Message-ID: <510FD36F.5090603@ti.com> (raw)
In-Reply-To: <1359565471-30721-5-git-send-email-jon-hunter@ti.com>


On 01/30/2013 11:04 AM, Jon Hunter wrote:
> There is a lot of redundancy in the definitions for the various system
> timers for OMAP2+ devices. For example, the omap3_am33xx_gptimer_timer_init()
> function is the same as the omap3_gp_gptimer_timer_init() function and the
> function omap2_sync32k_timer_init() can be re-used for OMAP4/5 devices.

After further testing, I have found that using the
omap2_sync32k_timer_init() for omap4/5 devices does not work for the
case where we boot with boot parameter "clocksource=gp_timer". The
problem is omap4/5 devices, unlike omap2/3 devices, does not have a
clock alias for "timer_sys_ck" with NULL as the device name. Therefore
we fail to find the parent clock and boot fails.

So I am going to update this patch so that omap4 and omap5 both use
omap4_sync32k_timer_init() and just get rid of the extra function
defined for omap5.

Hope this makes sense.

Cheers
Jon

  parent reply	other threads:[~2013-02-04 15:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 17:04 [PATCH 0/5] ARM: OMAP2+: System timer updates Jon Hunter
2013-01-30 17:04 ` Jon Hunter
2013-01-30 17:04 ` [PATCH 1/5] ARM: OMAP2+: Display correct system timer name Jon Hunter
2013-01-30 17:04   ` Jon Hunter
2013-02-01  8:41   ` Bedia, Vaibhav
2013-02-01  8:41     ` Bedia, Vaibhav
2013-02-01  8:53     ` Jon Hunter
2013-02-01  8:53       ` Jon Hunter
2013-02-01  9:31       ` Bedia, Vaibhav
2013-02-01  9:31         ` Bedia, Vaibhav
2013-02-01 10:34         ` Jon Hunter
2013-02-01 10:34           ` Jon Hunter
2013-01-30 17:04 ` [PATCH 2/5] ARM: OMAP2+: Remove hard-coded test on timer ID Jon Hunter
2013-01-30 17:04   ` Jon Hunter
2013-01-30 17:04 ` [PATCH 3/5] ARM: OMAP2+: Simplify system timer clock definitions Jon Hunter
2013-01-30 17:04   ` Jon Hunter
2013-01-30 17:04 ` [PATCH 4/5] ARM: OMAP2+: Simplify system timers definitions Jon Hunter
2013-01-30 17:04   ` Jon Hunter
2013-01-31  9:09   ` Igor Grinberg
2013-01-31  9:09     ` Igor Grinberg
2013-02-04 15:27   ` Jon Hunter [this message]
2013-02-04 15:27     ` Jon Hunter
2013-01-30 17:04 ` [PATCH 5/5] ARM: OMAP3: Update clocksource timer selection Jon Hunter
2013-01-30 17:04   ` Jon Hunter
2013-01-31  9:08   ` Igor Grinberg
2013-01-31  9:08     ` Igor Grinberg
2013-01-31 16:07     ` Jon Hunter
2013-01-31 16:07       ` Jon Hunter
2013-02-01  8:41   ` Bedia, Vaibhav
2013-02-01  8:41     ` Bedia, Vaibhav
2013-02-01  8:59     ` Jon Hunter
2013-02-01  8:59       ` Jon Hunter
2013-02-01  9:25       ` Jon Hunter
2013-02-01  9:25         ` Jon Hunter
2013-02-01  9:31         ` Bedia, Vaibhav
2013-02-01  9:31           ` Bedia, Vaibhav
2013-01-31  9:40 ` [PATCH 0/5] ARM: OMAP2+: System timer updates Santosh Shilimkar
2013-01-31  9:40   ` Santosh Shilimkar
2013-02-01  8:41 ` Bedia, Vaibhav
2013-02-01  8:41   ` Bedia, Vaibhav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510FD36F.5090603@ti.com \
    --to=jon-hunter@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=vaibhav.bedia@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.