From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>, <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH] OF: Fixup resursive locking code paths
Date: Mon, 4 Feb 2013 11:10:35 -0500 [thread overview]
Message-ID: <510FDD7B.7060903@windriver.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1302041147420.11905@ionos>
On 13-02-04 05:48 AM, Thomas Gleixner wrote:
> On Fri, 25 Jan 2013, Paul Gortmaker wrote:
>
>> From: Thomas Gleixner <tglx@linutronix.de>
>>
>> There is no real reason to use a rwlock for devtree_lock. It even
>> could be a mutex, but unfortunately it's locked from cpu hotplug
>> paths which can't schedule :(
>>
>> So it needs to become a raw lock on rt as well. The devtree_lock would
>> be the only user of a raw_rw_lock, so we are better off cleaning up the
>> recursive locking paths which allows us to convert devtree_lock to a
>> read_lock.
>
> Hmm. It's already a rw_lock. For RT we want to change that thing to a
> raw_spinlock.
Thanks for the reminder. Part 2 sent now that the cleanup got OK'd.
Paul.
--
>
> Thanks,
>
> tglx
>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] OF: Fixup resursive locking code paths
Date: Mon, 4 Feb 2013 11:10:35 -0500 [thread overview]
Message-ID: <510FDD7B.7060903@windriver.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1302041147420.11905@ionos>
On 13-02-04 05:48 AM, Thomas Gleixner wrote:
> On Fri, 25 Jan 2013, Paul Gortmaker wrote:
>
>> From: Thomas Gleixner <tglx@linutronix.de>
>>
>> There is no real reason to use a rwlock for devtree_lock. It even
>> could be a mutex, but unfortunately it's locked from cpu hotplug
>> paths which can't schedule :(
>>
>> So it needs to become a raw lock on rt as well. The devtree_lock would
>> be the only user of a raw_rw_lock, so we are better off cleaning up the
>> recursive locking paths which allows us to convert devtree_lock to a
>> read_lock.
>
> Hmm. It's already a rw_lock. For RT we want to change that thing to a
> raw_spinlock.
Thanks for the reminder. Part 2 sent now that the cleanup got OK'd.
Paul.
--
>
> Thanks,
>
> tglx
>
next prev parent reply other threads:[~2013-02-04 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 18:21 [PATCH] OF: Fixup resursive locking code paths Paul Gortmaker
2013-01-28 2:12 ` Rob Herring
2013-02-04 10:48 ` Thomas Gleixner
2013-02-04 16:10 ` Paul Gortmaker [this message]
2013-02-04 16:10 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510FDD7B.7060903@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.