All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Christoph Lameter <cl@linux.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	linux-mm@kvack.org
Subject: Re: next-20130204 - bisected slab problem to "slab: Common constants for kmalloc boundaries"
Date: Wed, 6 Feb 2013 09:44:34 +0000	[thread overview]
Message-ID: <51122602.7060307@imgtec.com> (raw)
In-Reply-To: <0000013caba3a2e8-b80a1426-33b5-44ae-9b2a-85c3ee20dd62-000000@email.amazonses.com>

On 05/02/13 18:34, Christoph Lameter wrote:
> On Tue, 5 Feb 2013, James Hogan wrote:
> 
>> On 05/02/13 16:36, Christoph Lameter wrote:
>>> OK I was able to reproduce it by setting ARCH_DMA_MINALIGN in slab.h. This
>>> patch fixes it here:
>>>
>>>
>>> Subject: slab: Handle ARCH_DMA_MINALIGN correctly
>>>
>>> A fixed KMALLOC_SHIFT_LOW does not work for arches with higher alignment
>>> requirements.
>>>
>>> Determine KMALLOC_SHIFT_LOW from ARCH_DMA_MINALIGN instead.
>>>
>>> Signed-off-by: Christoph Lameter <cl@linux.com>
>>
>> Thanks, your patch fixes it for me.
> 
> Ok I guess that implies a Tested-by:
> 

Yep sorry, feel free to add my Tested-by: if you roll this as a separate
patch.

Cheers
James

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Christoph Lameter <cl@linux.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	<linux-mm@kvack.org>
Subject: Re: next-20130204 - bisected slab problem to "slab: Common constants for kmalloc boundaries"
Date: Wed, 6 Feb 2013 09:44:34 +0000	[thread overview]
Message-ID: <51122602.7060307@imgtec.com> (raw)
In-Reply-To: <0000013caba3a2e8-b80a1426-33b5-44ae-9b2a-85c3ee20dd62-000000@email.amazonses.com>

On 05/02/13 18:34, Christoph Lameter wrote:
> On Tue, 5 Feb 2013, James Hogan wrote:
> 
>> On 05/02/13 16:36, Christoph Lameter wrote:
>>> OK I was able to reproduce it by setting ARCH_DMA_MINALIGN in slab.h. This
>>> patch fixes it here:
>>>
>>>
>>> Subject: slab: Handle ARCH_DMA_MINALIGN correctly
>>>
>>> A fixed KMALLOC_SHIFT_LOW does not work for arches with higher alignment
>>> requirements.
>>>
>>> Determine KMALLOC_SHIFT_LOW from ARCH_DMA_MINALIGN instead.
>>>
>>> Signed-off-by: Christoph Lameter <cl@linux.com>
>>
>> Thanks, your patch fixes it for me.
> 
> Ok I guess that implies a Tested-by:
> 

Yep sorry, feel free to add my Tested-by: if you roll this as a separate
patch.

Cheers
James


  reply	other threads:[~2013-02-06  9:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 16:22 next-20130204 - bisected slab problem to "slab: Common constants for kmalloc boundaries" James Hogan
2013-02-04 16:22 ` James Hogan
2013-02-04 16:22 ` James Hogan
2013-02-04 19:22 ` Christoph Lameter
2013-02-04 19:22   ` Christoph Lameter
2013-02-05 10:08   ` James Hogan
2013-02-05 10:08     ` James Hogan
2013-02-05 12:51   ` James Hogan
2013-02-05 12:51     ` James Hogan
2013-02-05 12:51     ` James Hogan
2013-02-04 19:39 ` Stephen Warren
2013-02-04 19:39   ` Stephen Warren
2013-02-05  2:29   ` Christoph Lameter
2013-02-05  2:29     ` Christoph Lameter
     [not found]   ` <alpine.DEB.2.02.1302042019170.32396@gentwo.org>
2013-02-05 16:36     ` Christoph Lameter
2013-02-05 16:36       ` Christoph Lameter
2013-02-05 17:08       ` James Hogan
2013-02-05 17:08         ` James Hogan
2013-02-05 18:34         ` Christoph Lameter
2013-02-05 18:34           ` Christoph Lameter
2013-02-06  9:44           ` James Hogan [this message]
2013-02-06  9:44             ` James Hogan
2013-02-06 18:33             ` Pekka Enberg
2013-02-06 18:33               ` Pekka Enberg
2013-02-05 18:28       ` Stephen Warren
2013-02-05 18:28         ` Stephen Warren
2013-02-05 18:52         ` Christoph Lameter
2013-02-05 18:52           ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51122602.7060307@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.