From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Emmanuel Thierry <emmanuel.thierry@telecom-bretagne.eu>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Romain KUNTZ <r.kuntz@ipflavors.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
herbert@gondor.hengli.com.au,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jamal Hadi Salim <hadi@cyberus.ca>
Subject: Re: [RFC PATCH] xfrm: fix handling of XFRM policies mark and mask.
Date: Wed, 06 Feb 2013 10:50:34 -0500 [thread overview]
Message-ID: <51127BCA.7070900@mojatatu.com> (raw)
In-Reply-To: <5D4F2414-B869-46AA-B684-01F9EA88AD03@telecom-bretagne.eu>
On 13-02-06 09:39 AM, Emmanuel Thierry wrote:
>
> I think you misread the example !
I did ;->
> Marks are both 1, masks are different.
>
> This case is more complex than a policy
> with no mark (so mark=0 and mask=0) versus
> a policy with an exact mark (so mark=1 and mask=0xffffffff),
> and i wanted to know if the algorithm would take these kind of cases into account.
>
Aha. I think this is pushing the envelope a little - are there good use
cases for this?
certainly you could insert with most exact mask first. No such check is
made at the moment.
cheers,
jamal
WARNING: multiple messages have this Message-ID (diff)
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Emmanuel Thierry <emmanuel.thierry@telecom-bretagne.eu>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Romain KUNTZ <r.kuntz@ipflavors.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
herbert@gondor.apana.org.au,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jamal Hadi Salim <hadi@cyberus.ca>
Subject: Re: [RFC PATCH] xfrm: fix handling of XFRM policies mark and mask.
Date: Wed, 06 Feb 2013 10:50:34 -0500 [thread overview]
Message-ID: <51127BCA.7070900@mojatatu.com> (raw)
In-Reply-To: <5D4F2414-B869-46AA-B684-01F9EA88AD03@telecom-bretagne.eu>
On 13-02-06 09:39 AM, Emmanuel Thierry wrote:
>
> I think you misread the example !
I did ;->
> Marks are both 1, masks are different.
>
> This case is more complex than a policy
> with no mark (so mark=0 and mask=0) versus
> a policy with an exact mark (so mark=1 and mask=0xffffffff),
> and i wanted to know if the algorithm would take these kind of cases into account.
>
Aha. I think this is pushing the envelope a little - are there good use
cases for this?
certainly you could insert with most exact mask first. No such check is
made at the moment.
cheers,
jamal
next prev parent reply other threads:[~2013-02-06 15:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 17:27 [RFC PATCH] xfrm: fix handling of XFRM policies mark and mask Romain KUNTZ
2013-02-02 17:27 ` Romain KUNTZ
2013-02-05 8:12 ` Steffen Klassert
2013-02-05 8:12 ` Steffen Klassert
2013-02-06 13:14 ` jamal
2013-02-06 13:14 ` jamal
2013-02-06 13:53 ` Emmanuel Thierry
2013-02-06 13:53 ` Emmanuel Thierry
2013-02-06 14:30 ` Jamal Hadi Salim
2013-02-06 14:30 ` Jamal Hadi Salim
2013-02-06 14:39 ` Emmanuel Thierry
2013-02-06 14:39 ` Emmanuel Thierry
2013-02-06 15:50 ` Jamal Hadi Salim [this message]
2013-02-06 15:50 ` Jamal Hadi Salim
2013-02-07 10:49 ` Steffen Klassert
2013-02-07 10:49 ` Steffen Klassert
2013-02-07 11:08 ` Emmanuel Thierry
2013-02-07 11:08 ` Emmanuel Thierry
2013-02-07 11:16 ` Emmanuel Thierry
2013-02-07 11:16 ` Emmanuel Thierry
2013-02-07 12:54 ` Steffen Klassert
2013-02-07 12:54 ` Steffen Klassert
2013-02-08 14:16 ` Emmanuel Thierry
2013-02-08 14:16 ` Emmanuel Thierry
2013-02-11 12:57 ` Romain KUNTZ
2013-02-11 12:57 ` Romain KUNTZ
2013-02-11 13:04 ` Steffen Klassert
2013-02-11 13:04 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51127BCA.7070900@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=emmanuel.thierry@telecom-bretagne.eu \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=r.kuntz@ipflavors.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.