From: Jonathan Cameron <jic23@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-iio@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Doug Anderson <dianders@chromium.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/2] iio: Update iio_channel_get API to use consumer device pointer as argument
Date: Wed, 06 Feb 2013 19:30:17 +0000 [thread overview]
Message-ID: <5112AF49.6090100@kernel.org> (raw)
In-Reply-To: <51104AE7.2020909@samsung.com>
On 02/04/2013 11:57 PM, Chanwoo Choi wrote:
> On 02/05/2013 05:26 AM, Guenter Roeck wrote:
>> For iio_channel_get to work with OF based configurations, it needs the
>> consumer device pointer instead of the consumer device name as argument.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied to togreg branch of iio.git.
Thanks all.
I'll hold off on taking the actual device tree patch (2 of this series)
for a day or two to give more time for comments on that.
>> ---
>> drivers/extcon/extcon-adc-jack.c | 3 +--
>> drivers/iio/inkern.c | 11 ++++++++++-
>> drivers/power/generic-adc-battery.c | 4 ++--
>> drivers/power/lp8788-charger.c | 8 ++++----
>> include/linux/iio/consumer.h | 5 +++--
>> 5 files changed, 20 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
>> index eda2a1a..d0233cd 100644
>> --- a/drivers/extcon/extcon-adc-jack.c
>> +++ b/drivers/extcon/extcon-adc-jack.c
>> @@ -135,8 +135,7 @@ static int adc_jack_probe(struct platform_device *pdev)
>> ;
>> data->num_conditions = i;
>> - data->chan = iio_channel_get(dev_name(&pdev->dev),
>> - pdata->consumer_channel);
>> + data->chan = iio_channel_get(&pdev->dev, pdata->consumer_channel);
>> if (IS_ERR(data->chan)) {
>> err = PTR_ERR(data->chan);
>> goto out;
>> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
>> index c42aba6..b289915 100644
>> --- a/drivers/iio/inkern.c
>> +++ b/drivers/iio/inkern.c
>> @@ -93,7 +93,8 @@ static const struct iio_chan_spec
> Ack for drivers/extcon .
>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Thanks,
> Chanwoo Choi
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Naveen Krishna Chatradhi
<ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
MyungJoo Ham
<myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Anton Vorontsov <cbou-JGs/UdohzUI@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH 1/2] iio: Update iio_channel_get API to use consumer device pointer as argument
Date: Wed, 06 Feb 2013 19:30:17 +0000 [thread overview]
Message-ID: <5112AF49.6090100@kernel.org> (raw)
In-Reply-To: <51104AE7.2020909-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On 02/04/2013 11:57 PM, Chanwoo Choi wrote:
> On 02/05/2013 05:26 AM, Guenter Roeck wrote:
>> For iio_channel_get to work with OF based configurations, it needs the
>> consumer device pointer instead of the consumer device name as argument.
>>
>> Signed-off-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Applied to togreg branch of iio.git.
Thanks all.
I'll hold off on taking the actual device tree patch (2 of this series)
for a day or two to give more time for comments on that.
>> ---
>> drivers/extcon/extcon-adc-jack.c | 3 +--
>> drivers/iio/inkern.c | 11 ++++++++++-
>> drivers/power/generic-adc-battery.c | 4 ++--
>> drivers/power/lp8788-charger.c | 8 ++++----
>> include/linux/iio/consumer.h | 5 +++--
>> 5 files changed, 20 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
>> index eda2a1a..d0233cd 100644
>> --- a/drivers/extcon/extcon-adc-jack.c
>> +++ b/drivers/extcon/extcon-adc-jack.c
>> @@ -135,8 +135,7 @@ static int adc_jack_probe(struct platform_device *pdev)
>> ;
>> data->num_conditions = i;
>> - data->chan = iio_channel_get(dev_name(&pdev->dev),
>> - pdata->consumer_channel);
>> + data->chan = iio_channel_get(&pdev->dev, pdata->consumer_channel);
>> if (IS_ERR(data->chan)) {
>> err = PTR_ERR(data->chan);
>> goto out;
>> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
>> index c42aba6..b289915 100644
>> --- a/drivers/iio/inkern.c
>> +++ b/drivers/iio/inkern.c
>> @@ -93,7 +93,8 @@ static const struct iio_chan_spec
> Ack for drivers/extcon .
>
> Acked-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Thanks,
> Chanwoo Choi
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-02-06 19:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 20:26 [PATCH v3 0/2] iio: Devicetree support Guenter Roeck
2013-02-04 20:26 ` Guenter Roeck
2013-02-04 20:26 ` [PATCH 1/2] iio: Update iio_channel_get API to use consumer device pointer as argument Guenter Roeck
2013-02-04 20:26 ` Guenter Roeck
2013-02-04 21:38 ` Anton Vorontsov
2013-02-04 21:38 ` Anton Vorontsov
2013-02-04 23:57 ` Chanwoo Choi
2013-02-04 23:57 ` Chanwoo Choi
2013-02-06 19:30 ` Jonathan Cameron [this message]
2013-02-06 19:30 ` Jonathan Cameron
2013-02-04 20:26 ` [PATCH v3 2/2] iio: Add OF support Guenter Roeck
2013-02-04 20:26 ` Guenter Roeck
2013-02-05 5:20 ` Guenter Roeck
2013-02-05 5:20 ` Guenter Roeck
2013-02-05 15:22 ` Guenter Roeck
2013-02-05 15:22 ` Guenter Roeck
2013-02-06 18:29 ` [PATCH v4 " Guenter Roeck
2013-02-06 18:29 ` Guenter Roeck
2013-02-06 19:37 ` Jonathan Cameron
2013-02-06 19:37 ` Jonathan Cameron
2013-02-06 20:05 ` Guenter Roeck
2013-02-06 20:05 ` Guenter Roeck
2013-02-06 20:12 ` Tomasz Figa
2013-02-06 20:12 ` Tomasz Figa
2013-02-07 1:53 ` Guenter Roeck
2013-02-07 1:53 ` Guenter Roeck
2013-02-07 9:00 ` Jonathan Cameron
2013-02-07 9:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112AF49.6090100@kernel.org \
--to=jic23@kernel.org \
--cc=cbou@mail.ru \
--cc=ch.naveen@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=myungjoo.ham@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.