All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux MM <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org,
	mgorman@suse.de
Subject: Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
Date: Thu, 07 Feb 2013 09:50:22 +0800	[thread overview]
Message-ID: <5113085E.4030104@cn.fujitsu.com> (raw)
In-Reply-To: <20130207010914.GA9070@verge.net.au>

于 2013年02月07日 09:09, Simon Horman 写道:
> On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
>> 于 2013年02月06日 17:29, Julian Anastasov 写道:
>>>
>>> 	Hello,
>>>
>>> 	Sorry that I'm writing a private email but I
>>> deleted your original message by mistake. Your change
>>> of the sysctl_sync_qlen_max from int to long is may be
>>> not enough.
>>>
>>> 	net/netfilter/ipvs/ip_vs_ctl.c contains
>>> proc var "sync_qlen_max" that should be changed to
>>> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>>>
>>
>> Thanks for pointing this. I will update this in patch v2.
> 
> Hi Zhang,
> 
> Thanks for helping to keep IPVS up to date.
> 
> It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
> and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
> may also need to be updated.
> 
> Could you look at including that in v2 too?

OK. I will update it.

Thanks
Zhang


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux MM <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org,
	mgorman@suse.de
Subject: Re: [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max
Date: Thu, 07 Feb 2013 09:50:22 +0800	[thread overview]
Message-ID: <5113085E.4030104@cn.fujitsu.com> (raw)
In-Reply-To: <20130207010914.GA9070@verge.net.au>

于 2013年02月07日 09:09, Simon Horman 写道:
> On Wed, Feb 06, 2013 at 05:36:12PM +0800, Zhang Yanfei wrote:
>> 于 2013年02月06日 17:29, Julian Anastasov 写道:
>>>
>>> 	Hello,
>>>
>>> 	Sorry that I'm writing a private email but I
>>> deleted your original message by mistake. Your change
>>> of the sysctl_sync_qlen_max from int to long is may be
>>> not enough.
>>>
>>> 	net/netfilter/ipvs/ip_vs_ctl.c contains
>>> proc var "sync_qlen_max" that should be changed to
>>> sizeof(unsigned long) and updated with proc_doulongvec_minmax.
>>>
>>
>> Thanks for pointing this. I will update this in patch v2.
> 
> Hi Zhang,
> 
> Thanks for helping to keep IPVS up to date.
> 
> It seems to me that include/net/ip_vs.h:sysctl_sync_qlen_max()
> and its call site, net/netfilter/ipvs/ip_vs_sync.c:sb_queue_tail()
> may also need to be updated.
> 
> Could you look at including that in v2 too?

OK. I will update it.

Thanks
Zhang


  reply	other threads:[~2013-02-07  1:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LFD.2.00.1302061115590.1664@ja.ssi.bg>
2013-02-06  9:36 ` [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max Zhang Yanfei
2013-02-06  9:36   ` Zhang Yanfei
2013-02-07  1:09   ` Simon Horman
2013-02-07  1:09     ` Simon Horman
2013-02-07  1:50     ` Zhang Yanfei [this message]
2013-02-07  1:50       ` Zhang Yanfei
2013-02-06  5:11 [PATCH 0/7] mm: fix types for some functions and variables in case of overflow Zhang Yanfei
2013-02-06  5:20 ` [PATCH 6/7] net: change type of netns_ipvs->sysctl_sync_qlen_max Zhang Yanfei
2013-02-06  5:20   ` Zhang Yanfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5113085E.4030104@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.