All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 4/4] xl: add vif.default.script
Date: Thu, 7 Feb 2013 11:31:03 +0000	[thread overview]
Message-ID: <51139077.4070309@eu.citrix.com> (raw)
In-Reply-To: <1360173877-12696-5-git-send-email-roger.pau@citrix.com>

On 06/02/13 18:04, Roger Pau Monne wrote:
> Replace vifscript with vif.default.script. The old config option is
> kept for backwards compatibility.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>

I haven't done a detailed review of the code, but the naming looks fine 
to me.

  -George


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-02-07 11:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 18:04 [PATCH v2 0/4] add vif-route support to libxl/xl Roger Pau Monne
2013-02-06 18:04 ` [PATCH v2 1/4] xl/libxl: add gatewaydev/netdev to vif specification Roger Pau Monne
2013-03-12 16:20   ` Ian Campbell
2013-02-06 18:04 ` [PATCH v2 2/4] xl: allow specifying a default gatewaydev in xl.conf Roger Pau Monne
2013-02-14 15:09   ` Ulf Kreutzberg
2013-02-14 15:17     ` Roger Pau Monné
2013-02-15 14:06       ` Ulf Kreutzberg
2013-02-18  7:38         ` Roger Pau Monné
2013-02-19 16:04           ` Ulf Kreutzberg
2013-03-04 11:02             ` Roger Pau Monné
2013-03-12 16:39               ` Ulf Kreutzberg
2013-03-12 16:22   ` Ian Campbell
2013-03-12 16:27     ` Ian Campbell
2013-03-13 16:29       ` Roger Pau Monné
2013-02-06 18:04 ` [PATCH v2 3/4] xl: add vif.default.bridge Roger Pau Monne
2013-03-12 16:25   ` Ian Campbell
2013-03-13 16:40     ` Roger Pau Monné
2013-02-06 18:04 ` [PATCH v2 4/4] xl: add vif.default.script Roger Pau Monne
2013-02-07 11:31   ` George Dunlap [this message]
2013-03-12 16:25   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51139077.4070309@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.