Re: [PATCH v2 2/4] xl: allow specifying a default gatewaydev in xl.conf

["Roger Pau Monné" <roger.pau@citrix.com>]

On 12/03/13 17:27, Ian Campbell wrote:
> On Tue, 2013-03-12 at 16:22 +0000, Ian Campbell wrote:
>> On Wed, 2013-02-06 at 18:04 +0000, Roger Pau Monne wrote:
>>> This adds a new global option in the xl configuration file called
>>> "vif.default.gatewaydev", that is used to specify the default
>>> gatewaydev to use when none is passed in the vif specification.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>> Cc: Ulf Kreutzberg <ulf.kreutzberg@hosteurope.de>
>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>> Cc: George Dunlap <george.dunlap@citrix.com>
>>> ---
>>> Changes since v1:
>>>  * Rename defaultnetdev to vif.default.gatewaydev
>>
>> That whole file is a bit uncomfortable ad-hoc in its naming, but oh
>> well.
> 
> Although if you fancied writing down some sort of simple "schema" (which
> is far too grand a word for what I'm thinking of) which fits the scheme
> you are using here and could serve as guidance for future new variable
> names, that would be very nice.

Thanks for the review, I guess the best place for this would be a
comment on the code next to the section that parses the global options.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel