From: George Dunlap <george.dunlap@eu.citrix.com>
To: Frediano Ziglio <frediano.ziglio@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>,
"Keir (Xen.org)" <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v7] cover: Coverage support
Date: Thu, 7 Feb 2013 11:57:38 +0000 [thread overview]
Message-ID: <511396B2.3030804@eu.citrix.com> (raw)
In-Reply-To: <1360236482-25452-1-git-send-email-frediano.ziglio@citrix.com>
On 07/02/13 11:27, Frediano Ziglio wrote:
> Updated set of patches for coverage.
>
> Changes:
> - remove operation to check if coverage enabled
> - add operation to read and reset coverage at same time
> - updated utility to refrect changes above
>
I've done a once-over and in principle I think this is a good series.
Thanks for doing it -- I think Xen has needed this for some time. Just
a couple of high-level comments (and I haven't been following the
discussion, so please forgive me if I'm contradicting something someone
said somewhere else):
First, re the name -- is there any reason not to call it "gcov" (or
"xgcov" or something like that) in the patch series and the Xen
command-line option? Since we're using the gcov format and the intent
(I presume) is to use the gcov tools to do the actual analysis,
Secondly, there doesn't seem to be any documentation. A definition of
the Xen command-line term is an absolute minimum, and a brief markdown
how-to explaining how to enable the option and use it would be much
appreciated.
-George
next prev parent reply other threads:[~2013-02-07 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 11:27 [PATCH v7] cover: Coverage support Frediano Ziglio
2013-02-07 11:27 ` [PATCH 1/4] cover: Call constructors during initialization Frediano Ziglio
2013-02-07 11:28 ` [PATCH 2/4] cover: Adding support for coverage information Frediano Ziglio
2013-02-07 11:59 ` George Dunlap
2013-02-07 13:01 ` Frediano Ziglio
2013-02-07 11:28 ` [PATCH 3/4] cover: Implement code to read coverage informations Frediano Ziglio
2013-02-07 11:28 ` [PATCH 4/4] cover: Add small utility to deal with test coverage information from Xen Frediano Ziglio
2013-02-07 11:57 ` George Dunlap [this message]
2013-02-07 14:32 ` [PATCH v7] cover: Coverage support Frediano Ziglio
2013-02-07 14:52 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511396B2.3030804@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=frediano.ziglio@citrix.com \
--cc=keir@xen.org \
--cc=konrad@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.