* [PATCH] rbd: add parentheses to object request iterator macros
@ 2013-02-08 16:18 Alex Elder
2013-02-19 19:15 ` Josh Durgin
0 siblings, 1 reply; 2+ messages in thread
From: Alex Elder @ 2013-02-08 16:18 UTC (permalink / raw)
To: ceph-devel@vger.kernel.org
The for_each_obj_request*() macros should parenthesize their uses of
the ireq parameter.
Signed-off-by: Alex Elder <elder@inktank.com>
---
drivers/block/rbd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 982963e..6e9e2c2 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -226,11 +226,11 @@ struct rbd_img_request {
};
#define for_each_obj_request(ireq, oreq) \
- list_for_each_entry(oreq, &ireq->obj_requests, links)
+ list_for_each_entry(oreq, &(ireq)->obj_requests, links)
#define for_each_obj_request_from(ireq, oreq) \
- list_for_each_entry_from(oreq, &ireq->obj_requests, links)
+ list_for_each_entry_from(oreq, &(ireq)->obj_requests, links)
#define for_each_obj_request_safe(ireq, oreq, n) \
- list_for_each_entry_safe_reverse(oreq, n, &ireq->obj_requests, links)
+ list_for_each_entry_safe_reverse(oreq, n, &(ireq)->obj_requests, links)
struct rbd_snap {
struct device dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rbd: add parentheses to object request iterator macros
2013-02-08 16:18 [PATCH] rbd: add parentheses to object request iterator macros Alex Elder
@ 2013-02-19 19:15 ` Josh Durgin
0 siblings, 0 replies; 2+ messages in thread
From: Josh Durgin @ 2013-02-19 19:15 UTC (permalink / raw)
To: Alex Elder; +Cc: ceph-devel@vger.kernel.org
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
On 02/08/2013 08:18 AM, Alex Elder wrote:
> The for_each_obj_request*() macros should parenthesize their uses of
> the ireq parameter.
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
> drivers/block/rbd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 982963e..6e9e2c2 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -226,11 +226,11 @@ struct rbd_img_request {
> };
>
> #define for_each_obj_request(ireq, oreq) \
> - list_for_each_entry(oreq, &ireq->obj_requests, links)
> + list_for_each_entry(oreq, &(ireq)->obj_requests, links)
> #define for_each_obj_request_from(ireq, oreq) \
> - list_for_each_entry_from(oreq, &ireq->obj_requests, links)
> + list_for_each_entry_from(oreq, &(ireq)->obj_requests, links)
> #define for_each_obj_request_safe(ireq, oreq, n) \
> - list_for_each_entry_safe_reverse(oreq, n, &ireq->obj_requests, links)
> + list_for_each_entry_safe_reverse(oreq, n, &(ireq)->obj_requests, links)
>
> struct rbd_snap {
> struct device dev;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-19 19:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-08 16:18 [PATCH] rbd: add parentheses to object request iterator macros Alex Elder
2013-02-19 19:15 ` Josh Durgin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.