From: Bart Van Assche <bvanassche@acm.org>
To: Joe Lawrence <Joe.Lawrence@stratus.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>,
Mike Christie <michaelc@cs.wisc.edu>, Tejun Heo <tj@kernel.org>,
Chanho Min <chanho.min@lge.com>,
David Milburn <dmilburn@redhat.com>
Subject: Re: [PATCH v8 0/10] More device removal fixes
Date: Sat, 09 Feb 2013 10:28:09 +0100 [thread overview]
Message-ID: <511616A9.7040904@acm.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1302081813170.13267@jlaw-desktop.mno.stratus.com>
On 02/09/13 00:29, Joe Lawrence wrote:
> I haven't had time to rerun the test without the two patches that wait in
> scsi_remove_host(), however I did rerun the test and verify the same
> behavior as in my earlier mail. I didn't see any __scsi_remove_device()
> instances running.
>
> Some more investigation revealed that MD RAID was holding a reference to
> the removed device. (In short, mdadm --remove had failed and left the
> device as a faulty member of the array.) When I did finally manage to
> kick that disk from the MD device, scsi host/device removal continued to
> completion as expected.
>
> There's a bit more context to the MD situation that I'll post to the raid
> list once I get the details together for Neil. I will CC you if you are
> interested in following.
The loop in scsi_remove_host() waits too long. It should stop waiting as
soon as the blk_cleanup_queue() calls for all sdev's have finished
instead of waiting until all sdev users have closed these sdev's. I will
repost patches 07/10 and 08/10.
Bart.
next prev parent reply other threads:[~2013-02-09 9:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 12:44 [PATCH v8 0/10] More device removal fixes Bart Van Assche
2013-02-05 12:45 ` [PATCH v8 01/10] Fix race between starved list processing and device removal Bart Van Assche
2013-02-05 12:46 ` [PATCH v8 02/10] Remove get_device() / put_device() pair from scsi_request_fn() Bart Van Assche
2013-02-05 12:47 ` [PATCH v8 03/10] Introduce scsi_device_being_removed() Bart Van Assche
2013-02-05 12:47 ` [PATCH v8 04/10] Remove offline devices when removing a host Bart Van Assche
2013-02-05 12:48 ` [PATCH v8 05/10] Disallow changing the device state via sysfs into "deleted" Bart Van Assche
2013-02-05 12:49 ` [PATCH v8 06/10] Avoid saving/restoring interrupt state inside scsi_remove_host() Bart Van Assche
2013-02-05 12:49 ` [PATCH v8 07/10] Make scsi_remove_host() wait for device removal Bart Van Assche
2013-02-05 12:50 ` [PATCH v8 08/10] Make scsi_remove_host() wait until error handling finished Bart Van Assche
2013-02-05 12:51 ` [PATCH v8 09/10] Avoid that scsi_device_set_state() triggers a race Bart Van Assche
2013-02-05 12:51 ` [PATCH v8 10/10] Save and restore host_scribble during error handling Bart Van Assche
2013-02-06 22:31 ` [PATCH v8 0/10] More device removal fixes Joe Lawrence
2013-02-07 10:40 ` Bart Van Assche
2013-02-07 11:33 ` Bart Van Assche
2013-02-08 23:29 ` Joe Lawrence
2013-02-09 9:28 ` Bart Van Assche [this message]
2013-02-11 20:36 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511616A9.7040904@acm.org \
--to=bvanassche@acm.org \
--cc=Joe.Lawrence@stratus.com \
--cc=chanho.min@lge.com \
--cc=dmilburn@redhat.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.