All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Denis CIOCCA <denis.ciocca@st.com>
Cc: lars@metafoo.de,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Denis CIOCCA <denis.ciocca@st.com>
Subject: Re: [PATCH] iio:common: added allocate and deallocate trigger functions when trigger is disabled.
Date: Sat, 09 Feb 2013 10:46:34 +0000	[thread overview]
Message-ID: <5116290A.7050505@kernel.org> (raw)
In-Reply-To: <1360230363-15553-1-git-send-email-denis.ciocca@st.com>

On 02/07/2013 09:46 AM, Denis CIOCCA wrote:
> This patch resolve a bugfix when driver is compiled without trigger.
Please remember to sign off on these. Also this is all part of what Randy
found, so he gets a reported by as well to thank him for pointing it out.

Anyhow added this one to the togreg branch of iio.git.
We also need the two patches I'll send out in a minute to fully deal with
the compile issues here.


Jonathan
> ---
>  include/linux/iio/common/st_sensors.h |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/include/linux/iio/common/st_sensors.h b/include/linux/iio/common/st_sensors.h
> index c40fdf5..1f86a97 100644
> --- a/include/linux/iio/common/st_sensors.h
> +++ b/include/linux/iio/common/st_sensors.h
> @@ -235,6 +235,16 @@ void st_sensors_deallocate_trigger(struct iio_dev *indio_dev);
>  irqreturn_t st_sensors_trigger_handler(int irq, void *p);
>  
>  int st_sensors_get_buffer_element(struct iio_dev *indio_dev, u8 *buf);
> +#else
> +static inline int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
> +				const struct iio_trigger_ops *trigger_ops)
> +{
> +	return 0;
> +}
> +static inline void st_sensors_deallocate_trigger(struct iio_dev *indio_dev)
> +{
> +	return;
> +}
>  #endif
>  
>  int st_sensors_init_sensor(struct iio_dev *indio_dev);
> 

  reply	other threads:[~2013-02-09 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07  9:46 [PATCH] iio:common: added allocate and deallocate trigger functions when trigger is disabled Denis CIOCCA
2013-02-09 10:46 ` Jonathan Cameron [this message]
2013-02-09 11:47   ` Denis Ciocca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5116290A.7050505@kernel.org \
    --to=jic23@kernel.org \
    --cc=denis.ciocca@st.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.