All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio:common: added allocate and deallocate trigger functions when trigger is disabled.
@ 2013-02-07  9:46 Denis CIOCCA
  2013-02-09 10:46 ` Jonathan Cameron
  0 siblings, 1 reply; 3+ messages in thread
From: Denis CIOCCA @ 2013-02-07  9:46 UTC (permalink / raw)
  To: jic23, lars, linux-iio; +Cc: Denis Ciocca

This patch resolve a bugfix when driver is compiled without trigger.
---
 include/linux/iio/common/st_sensors.h |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/linux/iio/common/st_sensors.h b/include/linux/iio/common/st_sensors.h
index c40fdf5..1f86a97 100644
--- a/include/linux/iio/common/st_sensors.h
+++ b/include/linux/iio/common/st_sensors.h
@@ -235,6 +235,16 @@ void st_sensors_deallocate_trigger(struct iio_dev *indio_dev);
 irqreturn_t st_sensors_trigger_handler(int irq, void *p);
 
 int st_sensors_get_buffer_element(struct iio_dev *indio_dev, u8 *buf);
+#else
+static inline int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
+				const struct iio_trigger_ops *trigger_ops)
+{
+	return 0;
+}
+static inline void st_sensors_deallocate_trigger(struct iio_dev *indio_dev)
+{
+	return;
+}
 #endif
 
 int st_sensors_init_sensor(struct iio_dev *indio_dev);
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio:common: added allocate and deallocate trigger functions when trigger is disabled.
  2013-02-07  9:46 [PATCH] iio:common: added allocate and deallocate trigger functions when trigger is disabled Denis CIOCCA
@ 2013-02-09 10:46 ` Jonathan Cameron
  2013-02-09 11:47   ` Denis Ciocca
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2013-02-09 10:46 UTC (permalink / raw)
  To: Denis CIOCCA; +Cc: lars, linux-iio@vger.kernel.org, Randy Dunlap, Denis CIOCCA

On 02/07/2013 09:46 AM, Denis CIOCCA wrote:
> This patch resolve a bugfix when driver is compiled without trigger.
Please remember to sign off on these. Also this is all part of what Randy
found, so he gets a reported by as well to thank him for pointing it out.

Anyhow added this one to the togreg branch of iio.git.
We also need the two patches I'll send out in a minute to fully deal with
the compile issues here.


Jonathan
> ---
>  include/linux/iio/common/st_sensors.h |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/include/linux/iio/common/st_sensors.h b/include/linux/iio/common/st_sensors.h
> index c40fdf5..1f86a97 100644
> --- a/include/linux/iio/common/st_sensors.h
> +++ b/include/linux/iio/common/st_sensors.h
> @@ -235,6 +235,16 @@ void st_sensors_deallocate_trigger(struct iio_dev *indio_dev);
>  irqreturn_t st_sensors_trigger_handler(int irq, void *p);
>  
>  int st_sensors_get_buffer_element(struct iio_dev *indio_dev, u8 *buf);
> +#else
> +static inline int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
> +				const struct iio_trigger_ops *trigger_ops)
> +{
> +	return 0;
> +}
> +static inline void st_sensors_deallocate_trigger(struct iio_dev *indio_dev)
> +{
> +	return;
> +}
>  #endif
>  
>  int st_sensors_init_sensor(struct iio_dev *indio_dev);
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio:common: added allocate and deallocate trigger functions when trigger is disabled.
  2013-02-09 10:46 ` Jonathan Cameron
@ 2013-02-09 11:47   ` Denis Ciocca
  0 siblings, 0 replies; 3+ messages in thread
From: Denis Ciocca @ 2013-02-09 11:47 UTC (permalink / raw)
  To: Jonathan Cameron
  Cc: Denis CIOCCA, Lars-Peter Clausen, linux-iio@vger.kernel.org,
	Randy Dunlap

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

2013/2/9 Jonathan Cameron <jic23@kernel.org>

> On 02/07/2013 09:46 AM, Denis CIOCCA wrote:
> > This patch resolve a bugfix when driver is compiled without trigger.
> Please remember to sign off on these. Also this is all part of what Randy
> found, so he gets a reported by as well to thank him for pointing it out.
>
> Ok I'm sorry. Thanks Jonathan and Randy.


Denis

[-- Attachment #2: Type: text/html, Size: 733 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-02-09 11:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-07  9:46 [PATCH] iio:common: added allocate and deallocate trigger functions when trigger is disabled Denis CIOCCA
2013-02-09 10:46 ` Jonathan Cameron
2013-02-09 11:47   ` Denis Ciocca

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.