[PATCH 01/15] pm80xx: fix for memory region free

[PATCH 01/15] pm80xx: fix for memory region free

[Anand]

>From 56ee53f01663fa479c0624b81e36545ea5b1ab94 Mon Sep 17 00:00:00 2001
From: Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com>
Date: Mon, 4 Feb 2013 12:10:02 +0530
Subject: [PATCH 01/15] pm80xx: fix for memory region free

All memory regions are allocated based on variables total_len
and alignment but free was based on element_size.

Signed-off-by: Sakthivel K <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>
Signed-off-by: Anand Kumar S <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>
---
 drivers/scsi/pm8001/pm8001_init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 4c9fe73..3d5e522 100755
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -140,7 +140,8 @@ static void pm8001_free(struct pm8001_hba_info *pm8001_ha)
 	for (i = 0; i < USI_MAX_MEMCNT; i++) {
 		if (pm8001_ha->memoryMap.region[i].virt_ptr != NULL) {
 			pci_free_consistent(pm8001_ha->pdev,
-				pm8001_ha->memoryMap.region[i].element_size,
+				(pm8001_ha->memoryMap.region[i].total_len +
+				pm8001_ha->memoryMap.region[i].alignment),
 				pm8001_ha->memoryMap.region[i].virt_ptr,
 				pm8001_ha->memoryMap.region[i].phys_addr);
 			}
-- 
1.7.1

Re: [PATCH 01/15] pm80xx: fix for memory region free

[James Bottomley]

On Tue, 2013-02-12 at 04:25 -0800, Anand wrote:
> >From 56ee53f01663fa479c0624b81e36545ea5b1ab94 Mon Sep 17 00:00:00 2001
> From: Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com>
> Date: Mon, 4 Feb 2013 12:10:02 +0530
> Subject: [PATCH 01/15] pm80xx: fix for memory region free
> 
> All memory regions are allocated based on variables total_len
> and alignment but free was based on element_size.
> 
> Signed-off-by: Sakthivel K <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>
> Signed-off-by: Anand Kumar S <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>
> ---
>  drivers/scsi/pm8001/pm8001_init.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 4c9fe73..3d5e522 100755

Can you please fix whatever it is you're doing that's causing this.  The
100755 at the end of the index directive indicates that you've
incorrectly added execute permissions to the file.  I've stripped all
these off again, but it's annoying.

Thanks,

James

Re: [PATCH 01/15] pm80xx: fix for memory region free

[James Bottomley]

On Tue, 2013-02-12 at 04:25 -0800, Anand wrote:
> >From 56ee53f01663fa479c0624b81e36545ea5b1ab94 Mon Sep 17 00:00:00 2001
> From: Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com>
> Date: Mon, 4 Feb 2013 12:10:02 +0530
> Subject: [PATCH 01/15] pm80xx: fix for memory region free
> 
> All memory regions are allocated based on variables total_len
> and alignment but free was based on element_size.
> 
> Signed-off-by: Sakthivel K <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>
> Signed-off-by: Anand Kumar S <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>

This address doesn't resolve either

> Reporting-MTA: dns;bby1exg01.pmc_nt.nt.pmc-sierra.bc.ca
> Received-From-MTA: dns;bby1mta02.pmc-sierra.bc.ca
> Arrival-Date: Fri, 22 Feb 2013 10:19:53 -0800
> 
> Original-Recipient: rfc822;DL.Team.PMC.SPC.Linux.open.source@pmcs.com
> Final-Recipient: rfc822;DL.Team.PMC.SPC.Linux.open.source@pmcs.com
> Action: failed
> Status: 5.7.1
> X-Display-Name: DL Team PMC SPC Linux open source
> 
We need resolvable addresses for signoffs, please.

Thanks,

James

RE: [PATCH 01/15] pm80xx: fix for memory region free

[Anand Kumar Santhanam]

Hi James,

We are planning to resubmit the patchset for pm8001 from patch 2 onwards

with  your comments addressed.
In short we will address the following

1. Use resolvable email addressed in patch.
2. Change the permission for patchset to 644 instead of 755.
3. We have merged patch 2, 3, 4 into a single patch to resolve
compilation and 
individual patch functionality issue.
4. We will be attaching the individual patches in the email as well as
submit 
the patch inline within the email.

Regards
Anand

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] 
Sent: Saturday, February 23, 2013 4:35 AM
To: Anand Kumar Santhanam
Cc: linux-scsi@vger.kernel.org; jack_wang@usish.com; Sangeetha
Gnanasekaran; Vishwanath Maram; Harry Yang
Subject: Re: [PATCH 01/15] pm80xx: fix for memory region free

On Tue, 2013-02-12 at 04:25 -0800, Anand wrote:
> >From 56ee53f01663fa479c0624b81e36545ea5b1ab94 Mon Sep 17 00:00:00 
> >2001
> From: Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com>
> Date: Mon, 4 Feb 2013 12:10:02 +0530
> Subject: [PATCH 01/15] pm80xx: fix for memory region free
> 
> All memory regions are allocated based on variables total_len and 
> alignment but free was based on element_size.
> 
> Signed-off-by: Sakthivel K 
> <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>
> Signed-off-by: Anand Kumar S 
> <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>

This address doesn't resolve either

> Reporting-MTA: dns;bby1exg01.pmc_nt.nt.pmc-sierra.bc.ca
> Received-From-MTA: dns;bby1mta02.pmc-sierra.bc.ca
> Arrival-Date: Fri, 22 Feb 2013 10:19:53 -0800
> 
> Original-Recipient: rfc822;DL.Team.PMC.SPC.Linux.open.source@pmcs.com
> Final-Recipient: rfc822;DL.Team.PMC.SPC.Linux.open.source@pmcs.com
> Action: failed
> Status: 5.7.1
> X-Display-Name: DL Team PMC SPC Linux open source
> 
We need resolvable addresses for signoffs, please.

Thanks,

James

RE: [PATCH 01/15] pm80xx: fix for memory region free

[Anand Kumar Santhanam]

Hi James,

The patches for pm80xx driver has been resubmitted based on your review
feedback. Could you pls include the same for 3.9?

Regards
Anand

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] 
Sent: Saturday, February 23, 2013 4:35 AM
To: Anand Kumar Santhanam
Cc: linux-scsi@vger.kernel.org; jack_wang@usish.com; Sangeetha
Gnanasekaran; Vishwanath Maram; Harry Yang
Subject: Re: [PATCH 01/15] pm80xx: fix for memory region free

On Tue, 2013-02-12 at 04:25 -0800, Anand wrote:
> >From 56ee53f01663fa479c0624b81e36545ea5b1ab94 Mon Sep 17 00:00:00 
> >2001
> From: Sakthivel K <Sakthivel.SaravananKamalRaju@pmcs.com>
> Date: Mon, 4 Feb 2013 12:10:02 +0530
> Subject: [PATCH 01/15] pm80xx: fix for memory region free
> 
> All memory regions are allocated based on variables total_len and 
> alignment but free was based on element_size.
> 
> Signed-off-by: Sakthivel K 
> <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>
> Signed-off-by: Anand Kumar S 
> <DL.Team.PMC.SPC.Linux.open.source@pmcs.com>

This address doesn't resolve either

> Reporting-MTA: dns;bby1exg01.pmc_nt.nt.pmc-sierra.bc.ca
> Received-From-MTA: dns;bby1mta02.pmc-sierra.bc.ca
> Arrival-Date: Fri, 22 Feb 2013 10:19:53 -0800
> 
> Original-Recipient: rfc822;DL.Team.PMC.SPC.Linux.open.source@pmcs.com
> Final-Recipient: rfc822;DL.Team.PMC.SPC.Linux.open.source@pmcs.com
> Action: failed
> Status: 5.7.1
> X-Display-Name: DL Team PMC SPC Linux open source
> 
We need resolvable addresses for signoffs, please.

Thanks,

James