From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: remove clock-frequency properties from serial nodes
Date: Tue, 12 Feb 2013 10:47:33 -0700 [thread overview]
Message-ID: <511A8035.6080808@wwwdotorg.org> (raw)
In-Reply-To: <1360691025-8393-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 02/12/2013 10:43 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Currently, the serial nodes define both a clock-frequency and a clocks
> property. We should not provide both, since they might conflict.
>
> In practice, this also causes problems since the of_serial driver uses
> the clock-frequency property in preference to the clocks property, and
> hence doesn't clk_prepare_enable() the clock, which may then leave it
> with no known users, and hence the common clock framework will disable
> it, thus breaking the port, which is usually the console.
I've applied this to Tegra's for-3.9/soc-ccf-fixes branch, although I'll
hold off on pushing it out a little while in case anyone has comments on
it. That said, I hope to include it in an arm-soc pull request tomorrow
at the latest.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: remove clock-frequency properties from serial nodes
Date: Tue, 12 Feb 2013 10:47:33 -0700 [thread overview]
Message-ID: <511A8035.6080808@wwwdotorg.org> (raw)
In-Reply-To: <1360691025-8393-1-git-send-email-swarren@wwwdotorg.org>
On 02/12/2013 10:43 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Currently, the serial nodes define both a clock-frequency and a clocks
> property. We should not provide both, since they might conflict.
>
> In practice, this also causes problems since the of_serial driver uses
> the clock-frequency property in preference to the clocks property, and
> hence doesn't clk_prepare_enable() the clock, which may then leave it
> with no known users, and hence the common clock framework will disable
> it, thus breaking the port, which is usually the console.
I've applied this to Tegra's for-3.9/soc-ccf-fixes branch, although I'll
hold off on pushing it out a little while in case anyone has comments on
it. That said, I hope to include it in an arm-soc pull request tomorrow
at the latest.
next prev parent reply other threads:[~2013-02-12 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 17:43 [PATCH] ARM: tegra: remove clock-frequency properties from serial nodes Stephen Warren
2013-02-12 17:43 ` Stephen Warren
[not found] ` <1360691025-8393-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-12 17:47 ` Stephen Warren [this message]
2013-02-12 17:47 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511A8035.6080808@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.