From: Bart Van Assche <bvanassche@acm.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jack Morgenstein <jackm@dev.mellanox.co.il>,
Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/lmx4: silence GCC warning
Date: Wed, 13 Feb 2013 14:50:20 +0100 [thread overview]
Message-ID: <511B9A1C.6000402@acm.org> (raw)
In-Reply-To: <1351504201.1339.4.camel@x61.thuisdomein>
On 10/29/12 10:50, Paul Bolle wrote:
> On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote:
>> You could use:
>>
>> u16 uninitialized_var(vlan);
>>
>> instead.
>
> I guess we'd better just wait and see whether uninitialized_var()
> survives before discussing your suggestion (see the thread starting at
> https://lkml.org/lkml/2012/10/26/508 ).
>
>> Although this in the special QP data flow, I still prefer to avoid adding extra code (even setting
>> initial values at procedure entry). The line above will also do the job. "uninitialized_var"
>> is used elsewhere in the driver. See, for example, mlx4_ib_post_send() in the same file (qp.c).
(replying to an e-mail of a few months ago)
If there are no further objections I'd like to see this patch to go
upstream. It fixes an annoying compiler warning and I don't think that
this patch has a negative performance impact.
Thanks,
Bart.
next prev parent reply other threads:[~2013-02-13 13:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:48 [PATCH] IB/lmx4: silence GCC warning Paul Bolle
[not found] ` <1348836538.3626.21.camel-uMdlDhfIn7prKue/0VVhAg@public.gmane.org>
2012-10-10 7:23 ` Jack Morgenstein
2012-10-10 7:23 ` Jack Morgenstein
[not found] ` <201210100923.43927.jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2012-10-29 9:50 ` Paul Bolle
2012-10-29 9:50 ` Paul Bolle
2013-02-13 13:50 ` Bart Van Assche [this message]
[not found] ` <511B9A1C.6000402-HInyCGIudOg@public.gmane.org>
2013-02-21 9:02 ` [PATCH v2] IB/mlx4: " Paul Bolle
2013-02-21 9:02 ` Paul Bolle
2013-02-24 12:34 ` Jack Morgenstein
[not found] ` <201302241434.17586.jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2013-02-25 16:54 ` Roland Dreier
2013-02-25 16:54 ` Roland Dreier
2013-02-25 17:23 ` Roland Dreier
[not found] ` <CAL1RGDWt2cgcwec-iQ9f8-YvC8fO2AncGBfQ2VUgPi3W49bKxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-26 7:57 ` Jack Morgenstein
2013-02-26 7:57 ` Jack Morgenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511B9A1C.6000402@acm.org \
--to=bvanassche@acm.org \
--cc=hal.rosenstock@gmail.com \
--cc=jackm@dev.mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.