From: Arend van Spriel <arend@broadcom.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/4] mac80211: Convert PS configuration from a binary flag to a set of modes
Date: Wed, 13 Feb 2013 19:54:19 +0100 [thread overview]
Message-ID: <511BE15B.8090507@broadcom.com> (raw)
In-Reply-To: <20130213170445.GC22867@thinkpad-t410>
On 02/13/2013 06:04 PM, Seth Forshee wrote:
>> Is all this really worth it? It seems a quick fix for brcmsmac might be
>> > to always set the powersave bit when IEEE80211_CONF_OFFCHANNEL is
>> > enabled in the config, and then go implement a real solution like I
>> > described earlier with powersave being separated out of the core
>> > mac80211 routines, and actually made possible for multiple interfaces?
> Using IEEE80211_CONF_OFFCHANNEL won't work. When the nullfunc to enable
> PS is sent the flag won't be set, as we're still on the operating
> channel. When we're actually off-channel the value of PM doesn't matter
> for the types of frames which are being sent. The only quick fix I've
> found is to watch out for frames with PM set and set the powersave bit
> while they're being transmitted.
I actually don't see that one fly. The frames are posted on a DMA fifo
towards the hardware so in the driver we have no clue when that frame is
being processes/transmitted hence no way of knowing when to write the
register(s).
Gr. AvS
WARNING: multiple messages have this Message-ID (diff)
From: "Arend van Spriel" <arend@broadcom.com>
To: "Seth Forshee" <seth.forshee@canonical.com>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
"Jouni Malinen" <jouni@qca.qualcomm.com>,
"Vasanthakumar Thiagarajan" <vthiagar@qca.qualcomm.com>,
"Senthil Balasubramanian" <senthilb@qca.qualcomm.com>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"Ivo van Doorn" <IvDoorn@gmail.com>,
"Gertjan van Wingerde" <gwingerde@gmail.com>,
"Helmut Schaa" <helmut.schaa@googlemail.com>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"Chaoming Li" <chaoming_li@realsil.com.cn>,
"Wey-Yi Guy" <wey-yi.w.guy@intel.com>,
"Intel Linux Wireless" <ilw@linux.intel.com>,
"Luciano Coelho" <coelho@ti.com>,
ath9k-devel@venema.h4ckr.net, brcm80211-dev-list@broadcom.com,
users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 1/4] mac80211: Convert PS configuration from a binary flag to a set of modes
Date: Wed, 13 Feb 2013 19:54:19 +0100 [thread overview]
Message-ID: <511BE15B.8090507@broadcom.com> (raw)
In-Reply-To: <20130213170445.GC22867@thinkpad-t410>
On 02/13/2013 06:04 PM, Seth Forshee wrote:
>> Is all this really worth it? It seems a quick fix for brcmsmac might be
>> > to always set the powersave bit when IEEE80211_CONF_OFFCHANNEL is
>> > enabled in the config, and then go implement a real solution like I
>> > described earlier with powersave being separated out of the core
>> > mac80211 routines, and actually made possible for multiple interfaces?
> Using IEEE80211_CONF_OFFCHANNEL won't work. When the nullfunc to enable
> PS is sent the flag won't be set, as we're still on the operating
> channel. When we're actually off-channel the value of PM doesn't matter
> for the types of frames which are being sent. The only quick fix I've
> found is to watch out for frames with PM set and set the powersave bit
> while they're being transmitted.
I actually don't see that one fly. The frames are posted on a DMA fifo
towards the hardware so in the driver we have no clue when that frame is
being processes/transmitted hence no way of knowing when to write the
register(s).
Gr. AvS
next prev parent reply other threads:[~2013-02-13 18:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 21:01 [PATCH 0/4] Add support for off-channel powersave state in mac80211 Seth Forshee
2013-02-06 21:01 ` [ath9k-devel] [PATCH 1/4] mac80211: Convert PS configuration from a binary flag to a set of modes Seth Forshee
2013-02-06 21:01 ` Seth Forshee
2013-02-13 15:06 ` [ath9k-devel] " Johannes Berg
2013-02-13 15:06 ` Johannes Berg
2013-02-13 17:04 ` [ath9k-devel] " Seth Forshee
2013-02-13 17:04 ` Seth Forshee
2013-02-13 18:54 ` Arend van Spriel [this message]
2013-02-13 18:54 ` Arend van Spriel
2013-02-13 19:09 ` [ath9k-devel] " Johannes Berg
2013-02-13 19:09 ` Johannes Berg
2013-02-13 19:25 ` [ath9k-devel] " Seth Forshee
2013-02-13 19:25 ` Seth Forshee
2013-02-13 21:36 ` [ath9k-devel] " Seth Forshee
2013-02-13 21:36 ` Seth Forshee
2013-02-13 21:43 ` [ath9k-devel] " Arend van Spriel
2013-02-13 21:43 ` Arend van Spriel
2013-02-13 22:00 ` [ath9k-devel] " Seth Forshee
2013-02-13 22:00 ` Seth Forshee
2013-02-15 12:20 ` [ath9k-devel] " Johannes Berg
2013-02-15 12:20 ` Johannes Berg
2013-02-06 21:01 ` [ath9k-devel] [PATCH 2/4] mac80211: Indicate hardware support for doze state rather than powersave Seth Forshee
2013-02-15 23:45 ` Hin-Tak Leung
2013-02-06 21:01 ` [PATCH 3/4] mac80211: Add off-channel PS state Seth Forshee
2013-02-06 21:01 ` [PATCH 4/4] brcmsmac: Add support for off-channel powersave Seth Forshee
2013-02-06 21:32 ` [PATCH 0/4] Add support for off-channel powersave state in mac80211 Johannes Berg
2013-02-07 18:15 ` Seth Forshee
2013-02-07 20:01 ` Arend van Spriel
2013-02-07 20:10 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511BE15B.8090507@broadcom.com \
--to=arend@broadcom.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.