From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: sctp: minor: make jsctp_sf_eat_sack static
Date: Wed, 13 Feb 2013 19:14:05 +0000 [thread overview]
Message-ID: <511BE5FD.9050307@redhat.com> (raw)
In-Reply-To: <20130213.140607.144614341798606281.davem@davemloft.net>
On 02/13/2013 08:06 PM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 13 Feb 2013 14:04:36 -0500 (EST)
>
>> From: Daniel Borkmann <dborkman@redhat.com>
>> Date: Wed, 13 Feb 2013 12:03:49 +0100
>>
>>> The function jsctp_sf_eat_sack can be made static, no need to extend
>>> its visibility.
>>>
>>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>>
>> It's exported for the jprobe lookup by ->symbol_name
>>
>> Did you test this?
>
> Never mind, I mis-read this, the symbol name is for the routine being
> shadowed by the jprobe, which is exported.
>
> These two patches look fine and I'll apply them, thanks Daniel.
Thanks Dave, yes, I did a test doing cat on /proc/net/sctpprobe
while running a simple SCTP client / server.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: sctp: minor: make jsctp_sf_eat_sack static
Date: Wed, 13 Feb 2013 20:14:05 +0100 [thread overview]
Message-ID: <511BE5FD.9050307@redhat.com> (raw)
In-Reply-To: <20130213.140607.144614341798606281.davem@davemloft.net>
On 02/13/2013 08:06 PM, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 13 Feb 2013 14:04:36 -0500 (EST)
>
>> From: Daniel Borkmann <dborkman@redhat.com>
>> Date: Wed, 13 Feb 2013 12:03:49 +0100
>>
>>> The function jsctp_sf_eat_sack can be made static, no need to extend
>>> its visibility.
>>>
>>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>>
>> It's exported for the jprobe lookup by ->symbol_name
>>
>> Did you test this?
>
> Never mind, I mis-read this, the symbol name is for the routine being
> shadowed by the jprobe, which is exported.
>
> These two patches look fine and I'll apply them, thanks Daniel.
Thanks Dave, yes, I did a test doing cat on /proc/net/sctpprobe
while running a simple SCTP client / server.
next prev parent reply other threads:[~2013-02-13 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1360752304.git.dborkman@redhat.com>
2013-02-13 11:03 ` [PATCH net-next 1/2] net: sctp: minor: make jsctp_sf_eat_sack static Daniel Borkmann
2013-02-13 11:03 ` Daniel Borkmann
2013-02-13 11:03 ` [PATCH net-next 2/2] net: sctp: add build check for sctp_sf_eat_sack_6_2/jsctp_sf_eat_sack Daniel Borkmann
2013-02-13 11:03 ` Daniel Borkmann
2013-02-13 21:15 ` Neil Horman
2013-02-13 21:15 ` Neil Horman
2013-02-13 19:04 ` [PATCH net-next 1/2] net: sctp: minor: make jsctp_sf_eat_sack static David Miller
2013-02-13 19:04 ` David Miller
2013-02-13 19:06 ` David Miller
2013-02-13 19:06 ` David Miller
2013-02-13 19:14 ` Daniel Borkmann [this message]
2013-02-13 19:14 ` Daniel Borkmann
2013-02-13 21:02 ` Neil Horman
2013-02-13 21:02 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511BE5FD.9050307@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.