* Possible bug with probe_send_count set to 0 and then checked if greater than 0
@ 2013-02-14 11:58 Magnus Cederlöf
2013-02-14 12:09 ` Wojciech Dubowik
0 siblings, 1 reply; 2+ messages in thread
From: Magnus Cederlöf @ 2013-02-14 11:58 UTC (permalink / raw)
To: linux-wireless
In net/mac80211/mlme.c function ieee80211_sta_tx_notify:
If a null frame was acked, ieee80211_sta_reset_conn_monitor is called.
This function sets probe_send_count to 0.
After the call to ieee80211_sta_reset_conn_monitor, it is checked if
probe_set_count is > 0.
This means that ieee80211_queue_work will not be called even though
the nullfunc was successful.
The symptom of this error is that when using power save, it will take
500ms to enter power save again after a successfully acked null frame.
What case will the check for 'probe_send_count > 0' cover?
Regards,
Magnus Cederlöf
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Possible bug with probe_send_count set to 0 and then checked if greater than 0
2013-02-14 11:58 Possible bug with probe_send_count set to 0 and then checked if greater than 0 Magnus Cederlöf
@ 2013-02-14 12:09 ` Wojciech Dubowik
0 siblings, 0 replies; 2+ messages in thread
From: Wojciech Dubowik @ 2013-02-14 12:09 UTC (permalink / raw)
To: Magnus Cederlöf; +Cc: linux-wireless
On 02/14/2013 12:58 PM, Magnus Cederlöf wrote:
> In net/mac80211/mlme.c function ieee80211_sta_tx_notify:
> If a null frame was acked, ieee80211_sta_reset_conn_monitor is called.
> This function sets probe_send_count to 0.
> After the call to ieee80211_sta_reset_conn_monitor, it is checked if
> probe_set_count is > 0.
> This means that ieee80211_queue_work will not be called even though
> the nullfunc was successful.
>
> The symptom of this error is that when using power save, it will take
> 500ms to enter power save again after a successfully acked null frame.
I am looking at it now and I see that it happens without power save
as well. I have just started putting printk around so I am not so far.
Wojtek
> What case will the check for 'probe_send_count > 0' cover?
>
> Regards,
> Magnus Cederlöf
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-14 12:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-14 11:58 Possible bug with probe_send_count set to 0 and then checked if greater than 0 Magnus Cederlöf
2013-02-14 12:09 ` Wojciech Dubowik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.