[PATCH] hfp_hf_bluez5: Remove unneeded modem hash lookup

[PATCH] hfp_hf_bluez5: Remove unneeded modem hash lookup

[Claudio Takahasi]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

Modem object is created when the Device Proxy is added, and it is
paired. Another path is when the Device "Paired" property changes
to True.
---
 plugins/hfp_hf_bluez5.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c
index 2f4a89e..543bf0f 100644
--- a/plugins/hfp_hf_bluez5.c
+++ b/plugins/hfp_hf_bluez5.c
@@ -166,10 +166,6 @@ static struct ofono_modem *modem_register(const char *device,
 	struct ofono_modem *modem;
 	char *path;
 
-	modem = g_hash_table_lookup(modem_hash, device);
-	if (modem != NULL)
-		return modem;
-
 	path = g_strconcat("hfp", device, NULL);
 
 	modem = ofono_modem_create(path, "hfp");
-- 
1.7.11.7

Re: [PATCH] hfp_hf_bluez5: Remove unneeded modem hash lookup

[Claudio Takahasi]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

Hi Denis:

On Fri, Feb 1, 2013 at 10:24 AM, Claudio Takahasi
<claudio.takahasi@openbossa.org> wrote:
> Modem object is created when the Device Proxy is added, and it is
> paired. Another path is when the Device "Paired" property changes
> to True.

Ignore this patch. This verification is needed: Property Changed
callback for "Paired" is *always* called after Proxy Added.

Regards,
Claudio

Re: [PATCH] hfp_hf_bluez5: Remove unneeded modem hash lookup

[Claudio Takahasi]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Denis:

On Fri, Feb 1, 2013 at 11:03 AM, Claudio Takahasi
<claudio.takahasi@openbossa.org> wrote:
> Hi Denis:
>
> On Fri, Feb 1, 2013 at 10:24 AM, Claudio Takahasi
> <claudio.takahasi@openbossa.org> wrote:
>> Modem object is created when the Device Proxy is added, and it is
>> paired. Another path is when the Device "Paired" property changes
>> to True.
>
> Ignore this patch. This verification is needed: Property Changed
> callback for "Paired" is *always* called after Proxy Added.
>
> Regards,
> Claudio

This patch can be applied now.

The patch "gdbus: Don't call property changed callback during client
init" fixes the problem that I reported.


Regards,
Claudio.

Re: [PATCH] hfp_hf_bluez5: Remove unneeded modem hash lookup

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi Claudio,

On 02/01/2013 07:24 AM, Claudio Takahasi wrote:
> Modem object is created when the Device Proxy is added, and it is
> paired. Another path is when the Device "Paired" property changes
> to True.
> ---
>   plugins/hfp_hf_bluez5.c | 4 ----
>   1 file changed, 4 deletions(-)
>

Patch has been applied, thanks.

Regards,
-Denis