From: Fabio Fantoni <fabio.fantoni@heliman.it>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
Stefano.Stabellini@eu.citrix.com, fantonifabio@tiscali.it
Subject: Re: [PATCH] tools/libxl: Added vga parameter for hvm domUs
Date: Fri, 15 Feb 2013 22:54:49 +0100 [thread overview]
Message-ID: <511EAEA9.5040109@heliman.it> (raw)
In-Reply-To: <20766.22732.806518.892544@mariner.uk.xensource.com>
Il 15/02/2013 16:48, Ian Jackson ha scritto:
> fantonifabio@tiscali.it writes ("[Xen-devel] [PATCH] tools/libxl: Added vga parameter for hvm domUs"):
>> From: Fabio Fantoni <fabio.fantoni@heliman.it>
>>
>> Usage:
>> vga="stdvga"|"cirrus"
>>
>> - Default option is cirrus.
>> - Prints error and exit if unknown value is passed.
>> - stdvga parameter is now deprecated.
>> - Updated xl.cfg man.
>>
>> Required patch: Improve videoram setting v5
>> Is prerequisite for patch: Add qxl support v9
> The code looks good to me, but there are a couple of formatting
> problems. Your wrapping of the longer lines is odd (particularly, you
> fail to indent the continuations), and there's a spurious space after
> xlu_cfg_get_string. Can you please repost following the style used
> elsewhere ?
>
> Thanks,
> Ian.
Sorry.
Can you explain me the error of indentation did I do please?
next prev parent reply other threads:[~2013-02-15 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 10:57 [PATCH] tools/libxl: Added vga parameter for hvm domUs fantonifabio
2013-02-15 12:26 ` Stefano Stabellini
2013-02-15 13:45 ` Ian Campbell
2013-02-15 15:48 ` Ian Jackson
2013-02-15 16:00 ` Ian Campbell
2013-02-15 21:54 ` Fabio Fantoni [this message]
2013-02-18 10:06 ` Ian Campbell
2013-02-18 10:51 ` Fabio Fantoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511EAEA9.5040109@heliman.it \
--to=fabio.fantoni@heliman.it \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=fantonifabio@tiscali.it \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.