From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: Add axi-clkgen driver
Date: Sat, 16 Feb 2013 09:47:40 +0100 [thread overview]
Message-ID: <511F47AC.102@metafoo.de> (raw)
In-Reply-To: <20130216025234.11471.8029@quantum>
On 02/16/2013 03:52 AM, Mike Turquette wrote:
> Quoting Lars-Peter Clausen (2013-01-23 06:04:52)
>> +static const struct of_device_id axi_clkgen_ids[] = {
>> + { .compatible = "adi,axi-clkgen-1.00.a" },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, axi_clkgen_ids);
>
> This method is deprecated. Can you convert over to the newer
> of_clk_init method? See:
>
> http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commit;h=f2f6c2556dcc432e50003bc8fa4d62d95906f149
Hi,
I'm not sure this makes sense here. That would mean completely bypassing the
device driver model. And since this device is on a kind of external bus it may
or may not be present at the time of_clk_init() runs.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mike Turquette <mturquette@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] clk: Add axi-clkgen driver
Date: Sat, 16 Feb 2013 09:47:40 +0100 [thread overview]
Message-ID: <511F47AC.102@metafoo.de> (raw)
In-Reply-To: <20130216025234.11471.8029@quantum>
On 02/16/2013 03:52 AM, Mike Turquette wrote:
> Quoting Lars-Peter Clausen (2013-01-23 06:04:52)
>> +static const struct of_device_id axi_clkgen_ids[] = {
>> + { .compatible = "adi,axi-clkgen-1.00.a" },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, axi_clkgen_ids);
>
> This method is deprecated. Can you convert over to the newer
> of_clk_init method? See:
>
> http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commit;h=f2f6c2556dcc432e50003bc8fa4d62d95906f149
Hi,
I'm not sure this makes sense here. That would mean completely bypassing the
device driver model. And since this device is on a kind of external bus it may
or may not be present at the time of_clk_init() runs.
- Lars
next prev parent reply other threads:[~2013-02-16 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 14:04 [PATCH v2] clk: Add axi-clkgen driver Lars-Peter Clausen
2013-01-23 14:04 ` Lars-Peter Clausen
2013-02-16 2:52 ` Mike Turquette
2013-02-16 8:47 ` Lars-Peter Clausen [this message]
2013-02-16 8:47 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511F47AC.102@metafoo.de \
--to=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.