All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Cc: kexec@lists.infradead.org
Subject: Re: makedumpfile-1.5.2: Secret data scrubbing with eppic language.
Date: Sat, 16 Feb 2013 18:03:38 +0800	[thread overview]
Message-ID: <511F597A.2030900@redhat.com> (raw)
In-Reply-To: <20130214110716.7b2b9f9b0eba662caefc9410@mxc.nes.nec.co.jp>

On 02/14/2013 10:07 AM, Atsushi Kumagai wrote:
> Hello,
> 
> makedumpfile version 1.5.2 is released.
> Your comments/patches are welcome.

Hi,
ppc64 build fails with "undefined reference to readpage_sadump".

Below patch fixes this, but feel free to fix it without the #if in other way.

diff -uprN makedumpfile/makedumpfile.c makedumpfile.new/makedumpfile.c
--- makedumpfile/makedumpfile.c	2013-02-16 17:58:58.158576503 +0800
+++ makedumpfile.new/makedumpfile.c	2013-02-16 17:59:19.775577017 +0800
@@ -412,9 +412,11 @@ readmem(int type_addr, unsigned long lon
 		if (info->flag_refiltering) {
 			if (!readpage_kdump_compressed(pgaddr, pgbuf))
 				goto error;
+#if defined(__x86__) || defined(__x86_64__)
 		} else if (info->flag_sadump) {
 			if (!readpage_sadump(pgaddr, pgbuf))
 				goto error;
+#endif
 		} else {
 			if (!readpage_elf(pgaddr, pgbuf))
 				goto error;

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2013-02-16 10:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14  2:07 makedumpfile-1.5.2: Secret data scrubbing with eppic language Atsushi Kumagai
2013-02-16 10:03 ` Dave Young [this message]
2013-02-17  3:30   ` Dave Young
2013-02-18  4:14     ` Atsushi Kumagai
2013-02-18  6:34       ` Dave Young
2013-02-18  7:11         ` Atsushi Kumagai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511F597A.2030900@redhat.com \
    --to=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.