All of lore.kernel.org
 help / color / mirror / Atom feed
* makedumpfile-1.5.2: Secret data scrubbing with eppic language.
@ 2013-02-14  2:07 Atsushi Kumagai
  2013-02-16 10:03 ` Dave Young
  0 siblings, 1 reply; 6+ messages in thread
From: Atsushi Kumagai @ 2013-02-14  2:07 UTC (permalink / raw)
  To: kexec

Hello,

makedumpfile version 1.5.2 is released.
Your comments/patches are welcome.

Main new feature:
o Support for eppic language
  This feature enables us to specify rules to scrub data in a
  dumpfile with eppic macro instead of the current configuration
  file (makedumpfile.conf). Currently, this feature works only
  for symbols in vmlinux while the current feature can work also
  for module symbols.
  
  To use this feature, you should build the extension module as
  below and move it to your library directory:
  
  # make eppic_makedumpfile.so

  To build this module, you should prepare eppic library from 
  the following URL:
  http://code.google.com/p/eppic/

o Exclude hwpoison page
  This is the default action in new makedumpfile.
  This feature excludes hwpoison pages in any dump_level, we can
  avoid touching poisoned pages and running into MCE during dump
  process.

Changelog:
o New feature
   Commits related to "Support for eppic language"
    - [PATCH v4 1/9] Initialize and setup eppic. (by Aravinda Prasad) 86f38e9
    - [PATCH v4 2/9] makedumpfile and eppic interface layer. (by Aravinda Prasad) 3e0747f
    - [PATCH v4 3/9] Eppic call back functions to query a dump image. (by Aravinda Prasad) 83b85ca
    - [PATCH v4 4/9] Implement apigetctype call back function. (by Aravinda Prasad) 9c5f56c
    - [PATCH v4 5/9] Implement apimember and apigetrtype call back functions. 
      (by Aravinda Prasad) b0bb9fb
    - [PATCH v4 6/9] Extend eppic built-in functions to include memset function. 
      (by Aravinda Prasad) 9c19ab0
    - [PATCH v4 7/9] Support fully typed symbol access mode. (by Aravinda Prasad) 63676e8
    - [PATCH v4 8/9] Hack for the limitation when compiled with -static. (by Aravinda Prasad) 46373c5
    - [PATCH v4 9/9] Update Documentation. (by Aravinda Prasad) a910399
   Other commit
    - [PATCH v2] Add a default action to exclude hwpoison page from vmcore.
      (by Mitsuhiro Tanino) 030800d
    - [PATCH] keep dumpfile pages in a cache. (by Petr Tesarik) 0aff0e5
o Bugfix
    - [PATCH] Fix PAGEOFFSET and PAGEBASE macros for i386 PAE. (by Atsushi Kumagai) 5d83960
    - [PATCH] --dump-dmesg fix for post 3.5 kernels. (by Louis Bouchard) 36c2458
    - [PATCH] ppc64: Auto-detect the correct MAX_PHYSMEM_BITS used in vmcore being analyzed. 
              (by Mahesh Salgaonkar) bfff315
    - [PATCH] Fix cyclic mode to scrub data with -E option. (by Atsushi Kumagai) f06bdd9
    - [PATCH] sadump: fix bug in checking a given physical address is present on memory. 
              (by HATAYAMA Daisuke) 1128de7
    - [PATCH] s390x: Allow HW Change-bit override for page table entries. (by Michael Holzheu) 6073b28
o Cleanup
    - [PATCH] sadump: fix warning about unused variable. (by HATAYAMA Daisuke) b93de26
    - [PATCH] sadump: fix warning messages in building time. (by HATAYAMA Daisuke) a1238cd
    - [PATCH] Cleanup: Delete incorrect comments of file handling. (by Atsushi Kumagai) 3104500


Explanation of makedumpfile:
  To shorten the size of the dumpfile and the time of creating the
  dumpfile, makedumpfile copies only the necessary pages for analysis
  to the dumpfile from /proc/vmcore. You can specify the kind of
  unnecessary pages with dump_level. If you want to shorten the size
  further, enable the compression of the page data.

Download:
  You can download the latest makedumpfile from the following URL.
  Details of the change are written on the git page of the following site.
  https://sourceforge.net/projects/makedumpfile/

Method of installation:
  You can compile the makedumpfile command as follows;
  1. "tar -zxvf makedumpfile-x.y.z.tar.gz"
  2. "cd makedumpfile-x.y.z"
  3. "make; make install"

Usage:
  makedumpfile [-c] [-E] [-d dump_level] [-x vmlinux] dump_mem dump_file

Example:
  If you want to exclude pages filled by zero, cache pages, user pages
  and free pages and to enable compression, please execute the following
  command.

  # makedumpfile -c -d 31 -x vmlinux /proc/vmcore dumpfile


Thanks
Atsushi Kumagai

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: makedumpfile-1.5.2: Secret data scrubbing with eppic language.
  2013-02-14  2:07 makedumpfile-1.5.2: Secret data scrubbing with eppic language Atsushi Kumagai
@ 2013-02-16 10:03 ` Dave Young
  2013-02-17  3:30   ` Dave Young
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Young @ 2013-02-16 10:03 UTC (permalink / raw)
  To: Atsushi Kumagai; +Cc: kexec

On 02/14/2013 10:07 AM, Atsushi Kumagai wrote:
> Hello,
> 
> makedumpfile version 1.5.2 is released.
> Your comments/patches are welcome.

Hi,
ppc64 build fails with "undefined reference to readpage_sadump".

Below patch fixes this, but feel free to fix it without the #if in other way.

diff -uprN makedumpfile/makedumpfile.c makedumpfile.new/makedumpfile.c
--- makedumpfile/makedumpfile.c	2013-02-16 17:58:58.158576503 +0800
+++ makedumpfile.new/makedumpfile.c	2013-02-16 17:59:19.775577017 +0800
@@ -412,9 +412,11 @@ readmem(int type_addr, unsigned long lon
 		if (info->flag_refiltering) {
 			if (!readpage_kdump_compressed(pgaddr, pgbuf))
 				goto error;
+#if defined(__x86__) || defined(__x86_64__)
 		} else if (info->flag_sadump) {
 			if (!readpage_sadump(pgaddr, pgbuf))
 				goto error;
+#endif
 		} else {
 			if (!readpage_elf(pgaddr, pgbuf))
 				goto error;

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: makedumpfile-1.5.2: Secret data scrubbing with eppic language.
  2013-02-16 10:03 ` Dave Young
@ 2013-02-17  3:30   ` Dave Young
  2013-02-18  4:14     ` Atsushi Kumagai
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Young @ 2013-02-17  3:30 UTC (permalink / raw)
  To: Atsushi Kumagai; +Cc: kexec, Baoquan He

On 02/16/2013 06:03 PM, Dave Young wrote:
> On 02/14/2013 10:07 AM, Atsushi Kumagai wrote:
>> Hello,
>>
>> makedumpfile version 1.5.2 is released.
>> Your comments/patches are welcome.
> 
> Hi,
> ppc64 build fails with "undefined reference to readpage_sadump".
> 
> Below patch fixes this, but feel free to fix it without the #if in other way.
> 
> diff -uprN makedumpfile/makedumpfile.c makedumpfile.new/makedumpfile.c
> --- makedumpfile/makedumpfile.c	2013-02-16 17:58:58.158576503 +0800
> +++ makedumpfile.new/makedumpfile.c	2013-02-16 17:59:19.775577017 +0800
> @@ -412,9 +412,11 @@ readmem(int type_addr, unsigned long lon
>  		if (info->flag_refiltering) {
>  			if (!readpage_kdump_compressed(pgaddr, pgbuf))
>  				goto error;
> +#if defined(__x86__) || defined(__x86_64__)
>  		} else if (info->flag_sadump) {
>  			if (!readpage_sadump(pgaddr, pgbuf))
>  				goto error;
> +#endif
>  		} else {
>  			if (!readpage_elf(pgaddr, pgbuf))
>  				goto error;
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


-- 
Thanks
Dave



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: makedumpfile-1.5.2: Secret data scrubbing with eppic language.
  2013-02-17  3:30   ` Dave Young
@ 2013-02-18  4:14     ` Atsushi Kumagai
  2013-02-18  6:34       ` Dave Young
  0 siblings, 1 reply; 6+ messages in thread
From: Atsushi Kumagai @ 2013-02-18  4:14 UTC (permalink / raw)
  To: dyoung; +Cc: kexec, bhe

Hello Dave,

On Sat, 16 Feb 2013 18:03:38 +0800
Dave Young <dyoung@redhat.com> wrote:

> On 02/14/2013 10:07 AM, Atsushi Kumagai wrote:
> > Hello,
> > 
> > makedumpfile version 1.5.2 is released.
> > Your comments/patches are welcome.
> 
> Hi,
> ppc64 build fails with "undefined reference to readpage_sadump".
> 

Thanks for reporting this issue.

readpage_sadump() was introduced as modification of readpmem_sadump
to use caching feature, but the dummy implementation of it wasn't
renamed.

I'll fix this issue with the patch below, so could you test it in your
environment ?


Thanks
Atsushi Kumagai
-----------------------------------------------------------------

[PATCH] Fix dummy implementation for readpage_sadump.

readpage_sadump() was introduced as modification of readpmem_sadump,
but the dummy implementation of it wasn't renamed.

Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>

diff --git a/sadump_info.h b/sadump_info.h
index 766f35d..c0175dd 100644
--- a/sadump_info.h
+++ b/sadump_info.h
@@ -97,8 +97,8 @@ static inline unsigned long long sadump_get_max_mapnr(void)
        return 0;
 }

-static inline int readpmem_sadump(unsigned long long paddr,
-                                 void *bufptr, size_t size)
+static inline int
+readpage_sadump(unsigned long long paddr, void *bufptr)
 {
        return FALSE;
 }


> Below patch fixes this, but feel free to fix it without the #if in other way.
> 
> diff -uprN makedumpfile/makedumpfile.c makedumpfile.new/makedumpfile.c
> --- makedumpfile/makedumpfile.c	2013-02-16 17:58:58.158576503 +0800
> +++ makedumpfile.new/makedumpfile.c	2013-02-16 17:59:19.775577017 +0800
> @@ -412,9 +412,11 @@ readmem(int type_addr, unsigned long lon
>  		if (info->flag_refiltering) {
>  			if (!readpage_kdump_compressed(pgaddr, pgbuf))
>  				goto error;
> +#if defined(__x86__) || defined(__x86_64__)
>  		} else if (info->flag_sadump) {
>  			if (!readpage_sadump(pgaddr, pgbuf))
>  				goto error;
> +#endif
>  		} else {
>  			if (!readpage_elf(pgaddr, pgbuf))
>  				goto error;

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: makedumpfile-1.5.2: Secret data scrubbing with eppic language.
  2013-02-18  4:14     ` Atsushi Kumagai
@ 2013-02-18  6:34       ` Dave Young
  2013-02-18  7:11         ` Atsushi Kumagai
  0 siblings, 1 reply; 6+ messages in thread
From: Dave Young @ 2013-02-18  6:34 UTC (permalink / raw)
  To: Atsushi Kumagai; +Cc: kexec, bhe

On 02/18/2013 12:14 PM, Atsushi Kumagai wrote:
> Hello Dave,
> 
> On Sat, 16 Feb 2013 18:03:38 +0800
> Dave Young <dyoung@redhat.com> wrote:
> 
>> On 02/14/2013 10:07 AM, Atsushi Kumagai wrote:
>>> Hello,
>>>
>>> makedumpfile version 1.5.2 is released.
>>> Your comments/patches are welcome.
>>
>> Hi,
>> ppc64 build fails with "undefined reference to readpage_sadump".
>>
> 
> Thanks for reporting this issue.
> 
> readpage_sadump() was introduced as modification of readpmem_sadump
> to use caching feature, but the dummy implementation of it wasn't
> renamed.
> 
> I'll fix this issue with the patch below, so could you test it in your
> environment ?

Hi, Atsushi

It works for me, thanks.

Tested-by: Dave Young <dyoung@redhat.com>

> 
> 
> Thanks
> Atsushi Kumagai
> -----------------------------------------------------------------
> 
> [PATCH] Fix dummy implementation for readpage_sadump.
> 
> readpage_sadump() was introduced as modification of readpmem_sadump,
> but the dummy implementation of it wasn't renamed.
> 
> Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
> 
> diff --git a/sadump_info.h b/sadump_info.h
> index 766f35d..c0175dd 100644
> --- a/sadump_info.h
> +++ b/sadump_info.h
> @@ -97,8 +97,8 @@ static inline unsigned long long sadump_get_max_mapnr(void)
>         return 0;
>  }
> 
> -static inline int readpmem_sadump(unsigned long long paddr,
> -                                 void *bufptr, size_t size)
> +static inline int
> +readpage_sadump(unsigned long long paddr, void *bufptr)
>  {
>         return FALSE;
>  }
> 
> 
>> Below patch fixes this, but feel free to fix it without the #if in other way.
>>
>> diff -uprN makedumpfile/makedumpfile.c makedumpfile.new/makedumpfile.c
>> --- makedumpfile/makedumpfile.c	2013-02-16 17:58:58.158576503 +0800
>> +++ makedumpfile.new/makedumpfile.c	2013-02-16 17:59:19.775577017 +0800
>> @@ -412,9 +412,11 @@ readmem(int type_addr, unsigned long lon
>>  		if (info->flag_refiltering) {
>>  			if (!readpage_kdump_compressed(pgaddr, pgbuf))
>>  				goto error;
>> +#if defined(__x86__) || defined(__x86_64__)
>>  		} else if (info->flag_sadump) {
>>  			if (!readpage_sadump(pgaddr, pgbuf))
>>  				goto error;
>> +#endif
>>  		} else {
>>  			if (!readpage_elf(pgaddr, pgbuf))
>>  				goto error;
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


-- 
Thanks
Dave



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: makedumpfile-1.5.2: Secret data scrubbing with eppic language.
  2013-02-18  6:34       ` Dave Young
@ 2013-02-18  7:11         ` Atsushi Kumagai
  0 siblings, 0 replies; 6+ messages in thread
From: Atsushi Kumagai @ 2013-02-18  7:11 UTC (permalink / raw)
  To: dyoung; +Cc: kexec, bhe

Hello Dave,

On Mon, 18 Feb 2013 14:34:45 +0800
Dave Young <dyoung@redhat.com> wrote:

> On 02/18/2013 12:14 PM, Atsushi Kumagai wrote:
> > Hello Dave,
> > 
> > On Sat, 16 Feb 2013 18:03:38 +0800
> > Dave Young <dyoung@redhat.com> wrote:
> > 
> >> On 02/14/2013 10:07 AM, Atsushi Kumagai wrote:
> >>> Hello,
> >>>
> >>> makedumpfile version 1.5.2 is released.
> >>> Your comments/patches are welcome.
> >>
> >> Hi,
> >> ppc64 build fails with "undefined reference to readpage_sadump".
> >>
> > 
> > Thanks for reporting this issue.
> > 
> > readpage_sadump() was introduced as modification of readpmem_sadump
> > to use caching feature, but the dummy implementation of it wasn't
> > renamed.
> > 
> > I'll fix this issue with the patch below, so could you test it in your
> > environment ?
> 
> Hi, Atsushi
> 
> It works for me, thanks.
> 
> Tested-by: Dave Young <dyoung@redhat.com>

Thanks for your quick response.
I'll release a fixed version soon.


Thanks
Atsushi Kumagai

> 
> > 
> > 
> > Thanks
> > Atsushi Kumagai
> > -----------------------------------------------------------------
> > 
> > [PATCH] Fix dummy implementation for readpage_sadump.
> > 
> > readpage_sadump() was introduced as modification of readpmem_sadump,
> > but the dummy implementation of it wasn't renamed.
> > 
> > Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
> > 
> > diff --git a/sadump_info.h b/sadump_info.h
> > index 766f35d..c0175dd 100644
> > --- a/sadump_info.h
> > +++ b/sadump_info.h
> > @@ -97,8 +97,8 @@ static inline unsigned long long sadump_get_max_mapnr(void)
> >         return 0;
> >  }
> > 
> > -static inline int readpmem_sadump(unsigned long long paddr,
> > -                                 void *bufptr, size_t size)
> > +static inline int
> > +readpage_sadump(unsigned long long paddr, void *bufptr)
> >  {
> >         return FALSE;
> >  }
> > 
> > 
> >> Below patch fixes this, but feel free to fix it without the #if in other way.
> >>
> >> diff -uprN makedumpfile/makedumpfile.c makedumpfile.new/makedumpfile.c
> >> --- makedumpfile/makedumpfile.c	2013-02-16 17:58:58.158576503 +0800
> >> +++ makedumpfile.new/makedumpfile.c	2013-02-16 17:59:19.775577017 +0800
> >> @@ -412,9 +412,11 @@ readmem(int type_addr, unsigned long lon
> >>  		if (info->flag_refiltering) {
> >>  			if (!readpage_kdump_compressed(pgaddr, pgbuf))
> >>  				goto error;
> >> +#if defined(__x86__) || defined(__x86_64__)
> >>  		} else if (info->flag_sadump) {
> >>  			if (!readpage_sadump(pgaddr, pgbuf))
> >>  				goto error;
> >> +#endif
> >>  		} else {
> >>  			if (!readpage_elf(pgaddr, pgbuf))
> >>  				goto error;
> > 
> > _______________________________________________
> > kexec mailing list
> > kexec@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
> > 
> 
> 
> -- 
> Thanks
> Dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-18  7:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-14  2:07 makedumpfile-1.5.2: Secret data scrubbing with eppic language Atsushi Kumagai
2013-02-16 10:03 ` Dave Young
2013-02-17  3:30   ` Dave Young
2013-02-18  4:14     ` Atsushi Kumagai
2013-02-18  6:34       ` Dave Young
2013-02-18  7:11         ` Atsushi Kumagai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.