From: Mugunthan V N <mugunthanvnm@ti.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly
Date: Sun, 17 Feb 2013 15:04:42 +0530 [thread overview]
Message-ID: <5120A432.5070302@ti.com> (raw)
In-Reply-To: <20130215.150506.499818568035818118.davem@davemloft.net>
On 2/16/2013 1:35 AM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Thu, 14 Feb 2013 23:56:46 +0530
>
>> +enum {
>> + CPDMA_EOI_RX_THRESH = 0,
>> + CPDMA_EOI_RX,
>> + CPDMA_EOI_TX,
>> + CPDMA_EOI_MISC,
>> +};
> Do not use enumerations for hardware register values, which must be
> exact, otherwise you are potentially going to succumb to the vagaries
> of C language enumeration value assignment.
Will change enum to define and submit next version patch.
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly
Date: Sun, 17 Feb 2013 15:04:42 +0530 [thread overview]
Message-ID: <5120A432.5070302@ti.com> (raw)
In-Reply-To: <20130215.150506.499818568035818118.davem@davemloft.net>
On 2/16/2013 1:35 AM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Thu, 14 Feb 2013 23:56:46 +0530
>
>> +enum {
>> + CPDMA_EOI_RX_THRESH = 0,
>> + CPDMA_EOI_RX,
>> + CPDMA_EOI_TX,
>> + CPDMA_EOI_MISC,
>> +};
> Do not use enumerations for hardware register values, which must be
> exact, otherwise you are potentially going to succumb to the vagaries
> of C language enumeration value assignment.
Will change enum to define and submit next version patch.
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: Mugunthan V N <mugunthanvnm@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly
Date: Sun, 17 Feb 2013 15:04:42 +0530 [thread overview]
Message-ID: <5120A432.5070302@ti.com> (raw)
In-Reply-To: <20130215.150506.499818568035818118.davem@davemloft.net>
On 2/16/2013 1:35 AM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Thu, 14 Feb 2013 23:56:46 +0530
>
>> +enum {
>> + CPDMA_EOI_RX_THRESH = 0,
>> + CPDMA_EOI_RX,
>> + CPDMA_EOI_TX,
>> + CPDMA_EOI_MISC,
>> +};
> Do not use enumerations for hardware register values, which must be
> exact, otherwise you are potentially going to succumb to the vagaries
> of C language enumeration value assignment.
Will change enum to define and submit next version patch.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-02-17 9:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 18:26 [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly Mugunthan V N
2013-02-14 18:26 ` Mugunthan V N
2013-02-14 18:26 ` Mugunthan V N
2013-02-15 20:05 ` David Miller
2013-02-15 20:05 ` David Miller
2013-02-15 20:05 ` David Miller
2013-02-15 20:05 ` David Miller
2013-02-17 9:35 ` Mugunthan V N
2013-02-17 9:35 ` Mugunthan V N
2013-02-17 9:35 ` Mugunthan V N
2013-02-15 20:18 ` Joe Perches
2013-02-15 20:18 ` Joe Perches
2013-02-15 20:20 ` David Miller
2013-02-15 20:20 ` David Miller
2013-02-17 9:34 ` Mugunthan V N [this message]
2013-02-17 9:34 ` Mugunthan V N
2013-02-17 9:34 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5120A432.5070302@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.