All of lore.kernel.org
 help / color / mirror / Atom feed
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Ric Mason <ric.masonn@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <jweiner@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Larry Woodman <lwoodman@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Joe Perches <joe@perches.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCHv5 7/8] zswap: add swap page writeback support
Date: Mon, 18 Feb 2013 13:32:11 -0600	[thread overview]
Message-ID: <512281BB.30906@linux.vnet.ibm.com> (raw)
In-Reply-To: <511F22FB.4010607@gmail.com>

On 02/16/2013 12:11 AM, Ric Mason wrote:
> On 02/14/2013 02:38 AM, Seth Jennings wrote:
<snip>
>> +/*******************************************
>> +* page pool for temporary compression result
>> +********************************************/
>> +#define ZSWAP_TMPPAGE_POOL_PAGES 16
> 
> Why not the number of online cpu?
> 

While the number of online cpus can change, it could better than this
fixed value.

You're the second person to mention this, so I'll fix it up.

Thanks,
Seth

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Ric Mason <ric.masonn@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nitin Gupta <ngupta@vflare.org>, Minchan Kim <minchan@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Jenifer Hopper <jhopper@us.ibm.com>, Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <jweiner@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Larry Woodman <lwoodman@redhat.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Joe Perches <joe@perches.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCHv5 7/8] zswap: add swap page writeback support
Date: Mon, 18 Feb 2013 13:32:11 -0600	[thread overview]
Message-ID: <512281BB.30906@linux.vnet.ibm.com> (raw)
In-Reply-To: <511F22FB.4010607@gmail.com>

On 02/16/2013 12:11 AM, Ric Mason wrote:
> On 02/14/2013 02:38 AM, Seth Jennings wrote:
<snip>
>> +/*******************************************
>> +* page pool for temporary compression result
>> +********************************************/
>> +#define ZSWAP_TMPPAGE_POOL_PAGES 16
> 
> Why not the number of online cpu?
> 

While the number of online cpus can change, it could better than this
fixed value.

You're the second person to mention this, so I'll fix it up.

Thanks,
Seth


  reply	other threads:[~2013-02-18 19:32 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 18:38 [PATCHv5 0/8] zswap: compressed swap caching Seth Jennings
2013-02-13 18:38 ` [PATCHv5 1/8] zsmalloc: add to mm/ Seth Jennings
2013-02-16  3:26   ` Ric Mason
2013-02-16  3:26     ` Ric Mason
2013-02-18 19:04     ` Seth Jennings
2013-02-18 19:04       ` Seth Jennings
2013-02-19  9:18   ` Joonsoo Kim
2013-02-19  9:18     ` Joonsoo Kim
2013-02-19 17:54     ` Seth Jennings
2013-02-19 17:54       ` Seth Jennings
2013-02-19 23:37       ` Minchan Kim
2013-02-19 23:37         ` Minchan Kim
2013-02-22  9:24         ` Joonsoo Kim
2013-02-22  9:24           ` Joonsoo Kim
2013-02-22 20:04           ` Seth Jennings
2013-02-22 20:04             ` Seth Jennings
2013-02-25 17:05             ` Dan Magenheimer
2013-02-25 17:05               ` Dan Magenheimer
2013-02-25 19:14               ` Seth Jennings
2013-02-25 19:14                 ` Seth Jennings
2013-02-26  0:20                 ` Dan Magenheimer
2013-02-26  0:20                   ` Dan Magenheimer
2013-02-20  1:58       ` Nitin Gupta
2013-02-20  2:42       ` Nitin Gupta
2013-02-20  2:42         ` Nitin Gupta
2013-02-13 18:38 ` [PATCHv5 2/8] zsmalloc: add documentation Seth Jennings
2013-02-16  6:21   ` Ric Mason
2013-02-16  6:21     ` Ric Mason
2013-02-18 19:16     ` Seth Jennings
2013-02-18 19:16       ` Seth Jennings
2013-02-21  8:44       ` Ric Mason
2013-02-21  8:49       ` Ric Mason
2013-02-21  8:49         ` Ric Mason
2013-02-21 15:50         ` Seth Jennings
2013-02-21 15:50           ` Seth Jennings
2013-02-21 16:20           ` Dan Magenheimer
2013-02-21 16:20             ` Dan Magenheimer
2013-02-22  2:56           ` Ric Mason
2013-02-22  2:56             ` Ric Mason
2013-02-22 21:02             ` Seth Jennings
2013-02-22 21:02               ` Seth Jennings
2013-02-24  0:37               ` Ric Mason
2013-02-24  0:37                 ` Ric Mason
2013-02-25 15:18                 ` Seth Jennings
2013-02-25 15:18                   ` Seth Jennings
2013-03-01  6:47                   ` Ric Mason
2013-03-01  6:47                     ` Ric Mason
2013-02-22  2:59           ` Ric Mason
2013-02-22  2:59             ` Ric Mason
2013-02-13 18:38 ` [PATCHv5 3/8] debugfs: add get/set for atomic types Seth Jennings
2013-02-13 18:38 ` [PATCHv5 4/8] zswap: add to mm/ Seth Jennings
2013-02-16  4:04   ` Ric Mason
2013-02-16  4:04     ` Ric Mason
2013-02-18 19:24     ` Seth Jennings
2013-02-18 19:24       ` Seth Jennings
2013-02-18 19:49       ` Cody P Schafer
2013-02-18 19:49         ` Cody P Schafer
2013-02-18 20:07         ` Seth Jennings
2013-02-18 20:07           ` Seth Jennings
2013-02-18 19:55       ` Dan Magenheimer
2013-02-18 19:55         ` Dan Magenheimer
2013-02-18 20:39         ` Seth Jennings
2013-02-18 20:39           ` Seth Jennings
2013-02-18 21:59           ` Dan Magenheimer
2013-02-18 21:59             ` Dan Magenheimer
2013-02-18 22:52             ` Seth Jennings
2013-02-18 22:52               ` Seth Jennings
2013-02-18 23:17               ` Dan Magenheimer
2013-02-18 23:17                 ` Dan Magenheimer
2013-02-20 20:37         ` Seth Jennings
2013-02-20 20:37           ` Seth Jennings
2013-02-13 18:38 ` [PATCHv5 5/8] mm: break up swap_writepage() for frontswap backends Seth Jennings
2013-02-13 18:38 ` [PATCHv5 6/8] mm: allow for outstanding swap writeback accounting Seth Jennings
2013-02-13 18:38 ` [PATCHv5 7/8] zswap: add swap page writeback support Seth Jennings
2013-02-16  6:11   ` Ric Mason
2013-02-16  6:11     ` Ric Mason
2013-02-18 19:32     ` Seth Jennings [this message]
2013-02-18 19:32       ` Seth Jennings
2013-02-25  2:54   ` Minchan Kim
2013-02-25  2:54     ` Minchan Kim
2013-02-25 17:37     ` Seth Jennings
2013-02-25 17:37       ` Seth Jennings
2013-02-13 18:38 ` [PATCHv5 8/8] zswap: add documentation Seth Jennings
2013-02-16  3:20 ` [PATCHv5 0/8] zswap: compressed swap caching Ric Mason
2013-02-16  3:20   ` Ric Mason
2013-02-18 19:37   ` Seth Jennings
2013-02-18 19:37     ` Seth Jennings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512281BB.30906@linux.vnet.ibm.com \
    --to=sjenning@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhopper@us.ibm.com \
    --cc=joe@perches.com \
    --cc=jweiner@redhat.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=ric.masonn@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.