From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Vincent Stehlé" <vincent.stehle@laposte.net>
Cc: linux-sh@vger.kernel.org, linux-next@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH linux-next] ARM: shmobile: rcar-gen2: update call to dma_contiguous_reserve_area
Date: Fri, 20 Jun 2014 13:11:42 +0200 [thread overview]
Message-ID: <5123262.2QjNse2sTm@avalon> (raw)
In-Reply-To: <1403170270-17877-1-git-send-email-vincent.stehle@laposte.net>
Hi Vincent,
Thank you for the patch.
On Thursday 19 June 2014 11:31:10 Vincent Stehlé wrote:
> Commit 5ea3b1b2f8ad 'cma: add placement specifier for "cma=" kernel
> parameter' adds a new 'fixed' parameter to dma_contiguous_reserve_area().
> Update rcar_gen2_reserve() accordingly.
>
> This fixes the following compilation error:
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c: In function ‘rcar_gen2_reserve’:
> arch/arm/mach-shmobile/setup-rcar-gen2.c:182:10: error: too few arguments
> to function ‘dma_contiguous_reserve_area’
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Hi,
>
> This can be seen with linux next-20140619 and e.g. arm allmodconfig.
>
> Best regards,
>
> V.
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/setup-rcar-gen2.c
> b/arch/arm/mach-shmobile/setup-rcar-gen2.c index 73fb2a6..42d5b43 100644
> --- a/arch/arm/mach-shmobile/setup-rcar-gen2.c
> +++ b/arch/arm/mach-shmobile/setup-rcar-gen2.c
> @@ -179,6 +179,6 @@ void __init rcar_gen2_reserve(void)
> #ifdef CONFIG_DMA_CMA
> if (mrc.size)
> dma_contiguous_reserve_area(mrc.size, mrc.base, 0,
> - &rcar_gen2_dma_contiguous);
> + &rcar_gen2_dma_contiguous, true);
> #endif
> }
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH linux-next] ARM: shmobile: rcar-gen2: update call to dma_contiguous_reserve_area
Date: Fri, 20 Jun 2014 11:11:42 +0000 [thread overview]
Message-ID: <5123262.2QjNse2sTm@avalon> (raw)
In-Reply-To: <1403170270-17877-1-git-send-email-vincent.stehle@laposte.net>
Hi Vincent,
Thank you for the patch.
On Thursday 19 June 2014 11:31:10 Vincent Stehlé wrote:
> Commit 5ea3b1b2f8ad 'cma: add placement specifier for "cma=" kernel
> parameter' adds a new 'fixed' parameter to dma_contiguous_reserve_area().
> Update rcar_gen2_reserve() accordingly.
>
> This fixes the following compilation error:
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c: In function ‘rcar_gen2_reserve’:
> arch/arm/mach-shmobile/setup-rcar-gen2.c:182:10: error: too few arguments
> to function ‘dma_contiguous_reserve_area’
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Hi,
>
> This can be seen with linux next-20140619 and e.g. arm allmodconfig.
>
> Best regards,
>
> V.
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/setup-rcar-gen2.c
> b/arch/arm/mach-shmobile/setup-rcar-gen2.c index 73fb2a6..42d5b43 100644
> --- a/arch/arm/mach-shmobile/setup-rcar-gen2.c
> +++ b/arch/arm/mach-shmobile/setup-rcar-gen2.c
> @@ -179,6 +179,6 @@ void __init rcar_gen2_reserve(void)
> #ifdef CONFIG_DMA_CMA
> if (mrc.size)
> dma_contiguous_reserve_area(mrc.size, mrc.base, 0,
> - &rcar_gen2_dma_contiguous);
> + &rcar_gen2_dma_contiguous, true);
> #endif
> }
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH linux-next] ARM: shmobile: rcar-gen2: update call to dma_contiguous_reserve_area
Date: Fri, 20 Jun 2014 13:11:42 +0200 [thread overview]
Message-ID: <5123262.2QjNse2sTm@avalon> (raw)
In-Reply-To: <1403170270-17877-1-git-send-email-vincent.stehle@laposte.net>
Hi Vincent,
Thank you for the patch.
On Thursday 19 June 2014 11:31:10 Vincent Stehl? wrote:
> Commit 5ea3b1b2f8ad 'cma: add placement specifier for "cma=" kernel
> parameter' adds a new 'fixed' parameter to dma_contiguous_reserve_area().
> Update rcar_gen2_reserve() accordingly.
>
> This fixes the following compilation error:
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c: In function ?rcar_gen2_reserve?:
> arch/arm/mach-shmobile/setup-rcar-gen2.c:182:10: error: too few arguments
> to function ?dma_contiguous_reserve_area?
>
> Signed-off-by: Vincent Stehl? <vincent.stehle@laposte.net>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> Hi,
>
> This can be seen with linux next-20140619 and e.g. arm allmodconfig.
>
> Best regards,
>
> V.
>
> arch/arm/mach-shmobile/setup-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/setup-rcar-gen2.c
> b/arch/arm/mach-shmobile/setup-rcar-gen2.c index 73fb2a6..42d5b43 100644
> --- a/arch/arm/mach-shmobile/setup-rcar-gen2.c
> +++ b/arch/arm/mach-shmobile/setup-rcar-gen2.c
> @@ -179,6 +179,6 @@ void __init rcar_gen2_reserve(void)
> #ifdef CONFIG_DMA_CMA
> if (mrc.size)
> dma_contiguous_reserve_area(mrc.size, mrc.base, 0,
> - &rcar_gen2_dma_contiguous);
> + &rcar_gen2_dma_contiguous, true);
> #endif
> }
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-06-20 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 9:31 [PATCH linux-next] ARM: shmobile: rcar-gen2: update call to dma_contiguous_reserve_area Vincent Stehlé
2014-06-19 9:31 ` Vincent Stehlé
2014-06-19 9:31 ` Vincent Stehlé
2014-06-20 11:11 ` Laurent Pinchart [this message]
2014-06-20 11:11 ` Laurent Pinchart
2014-06-20 11:11 ` Laurent Pinchart
2014-06-23 0:15 ` Simon Horman
2014-06-23 0:15 ` Simon Horman
2014-06-23 0:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5123262.2QjNse2sTm@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.