All of lore.kernel.org
 help / color / mirror / Atom feed
From: Diana Craciun <diana.craciun@freescale.com>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, scottwood@freescale.com,
	joro@8bytes.org, stuart.yoder@freescale.com
Subject: Re: [PATCH 6/6 v8] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Date: Tue, 19 Feb 2013 17:59:37 +0200	[thread overview]
Message-ID: <5123A169.9060100@freescale.com> (raw)
In-Reply-To: <1361191939-21260-7-git-send-email-Varun.Sethi@freescale.com>

On 02/18/2013 02:52 PM, Varun Sethi wrote:
> +/**
> + * pamu_get_ppaace() - Return the primary PACCE
> + * @liodn: liodn PAACT index for desired PAACE
> + *
> + * Returns the ppace pointer upon success else return
> + * null.
> + */
> +static struct paace *pamu_get_ppaace(int liodn)
> +{
> +	if (!ppaact || liodn > PAACE_NUMBER_ENTRIES) {

Shouldn't be "liodn >= PAACE_NUMBER_ENTRIES" ?

> +		pr_err("PPAACT doesn't exist\n");
> +		return NULL;
> +	}
> +
> +	return &ppaact[liodn];
> +}
> +

Diana

WARNING: multiple messages have this Message-ID (diff)
From: Diana Craciun <diana.craciun@freescale.com>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: joro@8bytes.org, stuart.yoder@freescale.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/6 v8] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Date: Tue, 19 Feb 2013 17:59:37 +0200	[thread overview]
Message-ID: <5123A169.9060100@freescale.com> (raw)
In-Reply-To: <1361191939-21260-7-git-send-email-Varun.Sethi@freescale.com>

On 02/18/2013 02:52 PM, Varun Sethi wrote:
> +/**
> + * pamu_get_ppaace() - Return the primary PACCE
> + * @liodn: liodn PAACT index for desired PAACE
> + *
> + * Returns the ppace pointer upon success else return
> + * null.
> + */
> +static struct paace *pamu_get_ppaace(int liodn)
> +{
> +	if (!ppaact || liodn > PAACE_NUMBER_ENTRIES) {

Shouldn't be "liodn >= PAACE_NUMBER_ENTRIES" ?

> +		pr_err("PPAACT doesn't exist\n");
> +		return NULL;
> +	}
> +
> +	return &ppaact[liodn];
> +}
> +

Diana

WARNING: multiple messages have this Message-ID (diff)
From: Diana Craciun <diana.craciun@freescale.com>
To: Varun Sethi <Varun.Sethi@freescale.com>
Cc: <iommu@lists.linux-foundation.org>,
	<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<scottwood@freescale.com>, <joro@8bytes.org>,
	<stuart.yoder@freescale.com>
Subject: Re: [PATCH 6/6 v8] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Date: Tue, 19 Feb 2013 17:59:37 +0200	[thread overview]
Message-ID: <5123A169.9060100@freescale.com> (raw)
In-Reply-To: <1361191939-21260-7-git-send-email-Varun.Sethi@freescale.com>

On 02/18/2013 02:52 PM, Varun Sethi wrote:
> +/**
> + * pamu_get_ppaace() - Return the primary PACCE
> + * @liodn: liodn PAACT index for desired PAACE
> + *
> + * Returns the ppace pointer upon success else return
> + * null.
> + */
> +static struct paace *pamu_get_ppaace(int liodn)
> +{
> +	if (!ppaact || liodn > PAACE_NUMBER_ENTRIES) {

Shouldn't be "liodn >= PAACE_NUMBER_ENTRIES" ?

> +		pr_err("PPAACT doesn't exist\n");
> +		return NULL;
> +	}
> +
> +	return &ppaact[liodn];
> +}
> +

Diana


  parent reply	other threads:[~2013-02-19 15:59 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 12:52 [PATCH 0/6 v8] iommu/fsl: Freescale PAMU driver and IOMMU API implementation Varun Sethi
2013-02-18 12:52 ` Varun Sethi
     [not found] ` <1361191939-21260-1-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-18 12:52   ` [PATCH 1/6 v8] iommu/fsl: Store iommu domain information pointer in archdata Varun Sethi
2013-02-18 12:52     ` Varun Sethi
     [not found]     ` <1361191939-21260-2-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-27 11:30       ` Joerg Roedel
2013-02-27 11:30         ` Joerg Roedel
2013-02-27 11:30         ` Joerg Roedel
     [not found]         ` <20130227113045.GH26252-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-02-27 12:04           ` Sethi Varun-B16395
2013-02-27 12:04             ` Sethi Varun-B16395
2013-02-27 12:04             ` Sethi Varun-B16395
     [not found]             ` <C5ECD7A89D1DC44195F34B25E172658D3C26F6-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-02-28 15:51               ` Kumar Gala
2013-02-28 15:51                 ` Kumar Gala
2013-02-28 15:51                 ` Kumar Gala
     [not found]                 ` <BAB98EA5-5324-4FB2-97C2-A28A96C569DC-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2013-03-01  1:24                   ` Alexey Kardashevskiy
2013-03-01  1:24                     ` Alexey Kardashevskiy
2013-03-01  1:24                     ` Alexey Kardashevskiy
     [not found]                     ` <51300367.6080300-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org>
2013-03-01  8:55                       ` Sethi Varun-B16395
2013-03-01  8:55                         ` Sethi Varun-B16395
2013-03-01  8:55                         ` Sethi Varun-B16395
     [not found]                         ` <C5ECD7A89D1DC44195F34B25E172658D3C802F-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-03-01 10:07                           ` Alexey Kardashevskiy
2013-03-01 10:07                             ` Alexey Kardashevskiy
2013-03-01 10:07                             ` Alexey Kardashevskiy
     [not found]                             ` <51307DCE.1050506-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org>
2013-03-01 16:21                               ` Yoder Stuart-B08248
2013-03-01 16:21                                 ` Yoder Stuart-B08248
2013-03-01 16:21                                 ` Yoder Stuart-B08248
     [not found]                                 ` <9F6FE96B71CF29479FF1CDC8046E1503565876-TcFNo7jSaXOLgTCmFNXF2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-03-04  6:35                                   ` Sethi Varun-B16395
2013-03-04  6:35                                     ` Sethi Varun-B16395
2013-03-04  6:35                                     ` Sethi Varun-B16395
2013-02-18 12:52   ` [PATCH 2/6] powerpc/fsl_pci: Store the platform device information corresponding to the pci controller Varun Sethi
2013-02-18 12:52     ` Varun Sethi
     [not found]     ` <1361191939-21260-3-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-26  0:09       ` Stuart Yoder
2013-02-26  0:09         ` Stuart Yoder
2013-02-26  0:09         ` Stuart Yoder
     [not found]         ` <CALRxmdDc9TuxH7HgAF3_iLgatoaOUML6fUt8SU+sxHyz6ZVjfw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-26  6:16           ` Sethi Varun-B16395
2013-02-26  6:16             ` Sethi Varun-B16395
2013-02-26  6:16             ` Sethi Varun-B16395
     [not found]             ` <C5ECD7A89D1DC44195F34B25E172658D3BD338-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-02-27 10:45               ` Joerg Roedel
2013-02-27 10:45                 ` Joerg Roedel
2013-02-27 10:45                 ` Joerg Roedel
     [not found]                 ` <20130227104505.GE26252-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-02-27 10:56                   ` Sethi Varun-B16395
2013-02-27 10:56                     ` Sethi Varun-B16395
2013-02-27 10:56                     ` Sethi Varun-B16395
2013-02-28 15:45                     ` Kumar Gala
2013-02-28 15:45                       ` Kumar Gala
     [not found]                       ` <D109CC7C-09D2-41E6-82BF-376692C390CA-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2013-03-07  9:14                         ` Sethi Varun-B16395
2013-03-07  9:14                           ` Sethi Varun-B16395
2013-03-07  9:14                           ` Sethi Varun-B16395
     [not found]                           ` <C5ECD7A89D1DC44195F34B25E172658D3E74C7-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-03-07 10:37                             ` Joerg Roedel
2013-03-07 10:37                               ` Joerg Roedel
2013-03-07 10:37                               ` Joerg Roedel
2013-02-18 12:52   ` [PATCH 3/6] powerpc/fsl_pci: Added defines for the FSL PCI controller BRR1 register Varun Sethi
2013-02-18 12:52     ` Varun Sethi
     [not found]     ` <1361191939-21260-4-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-27 11:33       ` Joerg Roedel
2013-02-27 11:33         ` Joerg Roedel
2013-02-27 11:33         ` Joerg Roedel
2013-02-28 15:46         ` Kumar Gala
2013-02-28 15:46           ` Kumar Gala
2013-02-18 12:52   ` [PATCH 4/6] iommu/fsl: Add window permission flags for iommu_domain_window_enable API Varun Sethi
2013-02-18 12:52     ` Varun Sethi
2013-02-18 12:52   ` [PATCH 5/6 v8] iommu/fsl: Add addtional attributes specific to the PAMU driver Varun Sethi
2013-02-18 12:52     ` Varun Sethi
     [not found]     ` <1361191939-21260-6-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-27 11:38       ` Joerg Roedel
2013-02-27 11:38         ` Joerg Roedel
2013-02-27 11:38         ` Joerg Roedel
2013-02-18 12:52   ` [PATCH 6/6 v8] iommu/fsl: Freescale PAMU driver and IOMMU API implementation Varun Sethi
2013-02-18 12:52     ` Varun Sethi
2013-02-19 10:04     ` Diana Craciun
2013-02-19 10:04       ` Diana Craciun
2013-02-19 10:04       ` Diana Craciun
     [not found]       ` <51234E27.9020604-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-19 10:27         ` Sethi Varun-B16395
2013-02-19 10:27           ` Sethi Varun-B16395
2013-02-19 10:27           ` Sethi Varun-B16395
2013-02-19 15:59     ` Diana Craciun [this message]
2013-02-19 15:59       ` Diana Craciun
2013-02-19 15:59       ` Diana Craciun
     [not found]       ` <5123A169.9060100-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-20  9:41         ` Sethi Varun-B16395
2013-02-20  9:41           ` Sethi Varun-B16395
2013-02-20  9:41           ` Sethi Varun-B16395
     [not found]     ` <1361191939-21260-7-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-02-26 22:33       ` Stuart Yoder
2013-02-26 22:33         ` Stuart Yoder
2013-02-26 22:33         ` Stuart Yoder
     [not found]         ` <CALRxmdBBO2AoAnKSTNNTYhHZ9fitJKWWeZMUj1ObtFhsZS5iSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-27 11:56           ` Sethi Varun-B16395
2013-02-27 11:56             ` Sethi Varun-B16395
2013-02-27 11:56             ` Sethi Varun-B16395
2013-02-28  0:03       ` Stuart Yoder
2013-02-28  0:03         ` Stuart Yoder
2013-02-28  0:03         ` Stuart Yoder
2013-03-01 23:27       ` Stuart Yoder
2013-03-01 23:27         ` Stuart Yoder
2013-03-01 23:27         ` Stuart Yoder
     [not found]         ` <CALRxmdDEccTaS2Houuns44DoQ_8wUbXAMiXQ8w0Ks9R2F2u-Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-04 11:31           ` Sethi Varun-B16395
2013-03-04 11:31             ` Sethi Varun-B16395
2013-03-04 11:31             ` Sethi Varun-B16395
     [not found]             ` <C5ECD7A89D1DC44195F34B25E172658D3D12D9-RL0Hj/+nBVDYdknt8GnhQq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-03-04 16:55               ` Yoder Stuart-B08248
2013-03-04 16:55                 ` Yoder Stuart-B08248
2013-03-04 16:55                 ` Yoder Stuart-B08248
2013-02-25 10:15   ` [PATCH 0/6 " Sethi Varun-B16395
2013-02-25 10:15     ` Sethi Varun-B16395
2013-02-25 10:15     ` Sethi Varun-B16395

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5123A169.9060100@freescale.com \
    --to=diana.craciun@freescale.com \
    --cc=Varun.Sethi@freescale.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.