* Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode"
@ 2013-02-19 17:48 Stephen Warren
2013-02-19 18:56 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Warren @ 2013-02-19 17:48 UTC (permalink / raw)
To: Daniel Vetter
Cc: Rob Clark, dri-devel@lists.freedesktop.org,
linux-tegra@vger.kernel.org, linux-next@vger.kernel.org,
Mark Zhang
Daniel,
Commit 6aed8ec "drm: review locking for
drm_fb_helper_restore_fbdev_mode" (now in next-20130218 and later)
causes build failures for tegra_defconfig. The issue is this part of the
patch:
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index 3742bc9..1b6ba2d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -389,8 +389,10 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini);
> */
> void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma)
> {
> + drm_modeset_lock_all(dev);
> if (fbdev_cma)
> drm_fb_helper_restore_fbdev_mode(&fbdev_cma->fb_helper);
> + drm_modeset_unlock_all(dev);
> }
> EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode);
There, there is no "dev" variable, so compile fails.
If I revert this one patch, the build succeeds, although I didn't check
whether DRM still works after that (e.g. due to any dependencies from
the rest of the series).
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode"
2013-02-19 17:48 Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode" Stephen Warren
@ 2013-02-19 18:56 ` Daniel Vetter
[not found] ` <CAKMK7uG=x4ESF_uVUwvK+0kzvsXEgZBtM9Z6_Qrm6keSasoCbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2013-02-19 18:56 UTC (permalink / raw)
To: Stephen Warren
Cc: Mark Zhang, dri-devel@lists.freedesktop.org,
linux-next@vger.kernel.org, linux-tegra@vger.kernel.org
On Tue, Feb 19, 2013 at 6:48 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> Daniel,
>
> Commit 6aed8ec "drm: review locking for
> drm_fb_helper_restore_fbdev_mode" (now in next-20130218 and later)
> causes build failures for tegra_defconfig. The issue is this part of the
> patch:
You need to yell at Dave Airlie:
https://patchwork.kernel.org/patch/2162391/
Cheers, Daniel
>> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
>> index 3742bc9..1b6ba2d 100644
>> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
>> @@ -389,8 +389,10 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini);
>> */
>> void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma)
>> {
>> + drm_modeset_lock_all(dev);
>> if (fbdev_cma)
>> drm_fb_helper_restore_fbdev_mode(&fbdev_cma->fb_helper);
>> + drm_modeset_unlock_all(dev);
>> }
>> EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode);
>
> There, there is no "dev" variable, so compile fails.
>
> If I revert this one patch, the build succeeds, although I didn't check
> whether DRM still works after that (e.g. due to any dependencies from
> the rest of the series).
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-19 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 17:48 Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode" Stephen Warren
2013-02-19 18:56 ` Daniel Vetter
[not found] ` <CAKMK7uG=x4ESF_uVUwvK+0kzvsXEgZBtM9Z6_Qrm6keSasoCbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-19 19:29 ` Stephen Warren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.