From: Stephen Warren <swarren@wwwdotorg.org>
To: Wei Ni <wni@nvidia.com>
Cc: durgadoss.r@intel.com, rui.zhang@intel.com,
MLongnecker@nvidia.com, khali@linux-fr.org,
devicetree-discuss@lists.ozlabs.org, linux-tegra@vger.kernel.org,
lm-sensors@lm-sensors.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.orgrs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11
Date: Tue, 19 Feb 2013 16:02:47 -0700 [thread overview]
Message-ID: <51240497.8010909@wwwdotorg.org> (raw)
In-Reply-To: <1361187031-3679-5-git-send-email-wni@nvidia.com>
On 02/18/2013 04:30 AM, Wei Ni wrote:
> Using macros for the indexes and nrs of temp8 and temp11.
> This make the code much clearer.
Sorry to nit-pick, but those aren't macros, but rather they're enums.
The patch looks good though.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Wei Ni <wni@nvidia.com>
Cc: durgadoss.r@intel.com, rui.zhang@intel.com,
MLongnecker@nvidia.com, khali@linux-fr.org,
devicetree-discuss@lists.ozlabs.org, linux-tegra@vger.kernel.org,
lm-sensors@lm-sensors.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.orgrs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11
Date: Tue, 19 Feb 2013 23:02:47 +0000 [thread overview]
Message-ID: <51240497.8010909@wwwdotorg.org> (raw)
In-Reply-To: <1361187031-3679-5-git-send-email-wni@nvidia.com>
On 02/18/2013 04:30 AM, Wei Ni wrote:
> Using macros for the indexes and nrs of temp8 and temp11.
> This make the code much clearer.
Sorry to nit-pick, but those aren't macros, but rather they're enums.
The patch looks good though.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11
Date: Tue, 19 Feb 2013 16:02:47 -0700 [thread overview]
Message-ID: <51240497.8010909@wwwdotorg.org> (raw)
In-Reply-To: <1361187031-3679-5-git-send-email-wni@nvidia.com>
On 02/18/2013 04:30 AM, Wei Ni wrote:
> Using macros for the indexes and nrs of temp8 and temp11.
> This make the code much clearer.
Sorry to nit-pick, but those aren't macros, but rather they're enums.
The patch looks good though.
next prev parent reply other threads:[~2013-02-19 23:02 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 11:30 [RFC PATCH 0/9] Support for tegra30 thermal Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
[not found] ` <1361187031-3679-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-18 11:30 ` [RFC PATCH 1/9] ARM: dt: t30 cardhu: add dt entry for lm90 Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
[not found] ` <1361187031-3679-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-19 3:28 ` Alex Courbot
2013-02-19 3:28 ` Alex Courbot
2013-02-19 3:28 ` [lm-sensors] " Alex Courbot
2013-02-19 9:52 ` Wei Ni
2013-02-19 9:52 ` Wei Ni
2013-02-19 9:52 ` [lm-sensors] " Wei Ni
[not found] ` <5122F162.9030103-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-19 22:48 ` Stephen Warren
2013-02-19 22:48 ` Stephen Warren
2013-02-19 22:48 ` [lm-sensors] " Stephen Warren
2013-02-18 11:30 ` [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
[not found] ` <1361187031-3679-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-19 3:34 ` Guenter Roeck
2013-02-19 3:34 ` Guenter Roeck
2013-02-19 3:34 ` Guenter Roeck
2013-02-19 10:43 ` Wei Ni
2013-02-19 10:43 ` Wei Ni
2013-02-19 10:43 ` Wei Ni
2013-02-19 23:00 ` Stephen Warren
2013-02-19 23:00 ` Stephen Warren
2013-02-19 23:00 ` [lm-sensors] " Stephen Warren
2013-02-20 3:27 ` Alex Courbot
2013-02-20 3:27 ` Alex Courbot
2013-02-20 3:27 ` [lm-sensors] " Alex Courbot
[not found] ` <5124429B.2000404-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-20 10:27 ` Wei Ni
2013-02-20 10:27 ` Wei Ni
2013-02-20 10:27 ` [lm-sensors] " Wei Ni
2013-02-18 11:30 ` [RFC PATCH 5/9] Thermal: Support using dt node to get sensor Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
[not found] ` <1361187031-3679-6-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-19 23:12 ` Stephen Warren
2013-02-19 23:12 ` Stephen Warren
2013-02-19 23:12 ` [lm-sensors] " Stephen Warren
[not found] ` <512406F0.4080708-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-20 10:36 ` Wei Ni
2013-02-20 10:36 ` Wei Ni
2013-02-20 10:36 ` [lm-sensors] " Wei Ni
2013-02-18 11:30 ` [RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
2013-02-19 3:42 ` Guenter Roeck
2013-02-19 3:42 ` Guenter Roeck
2013-02-19 3:42 ` Guenter Roeck
[not found] ` <20130219034205.GC25610-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-19 10:47 ` Wei Ni
2013-02-19 10:47 ` Wei Ni
2013-02-19 10:47 ` Wei Ni
2013-02-19 5:22 ` Alex Courbot
2013-02-19 5:22 ` Alex Courbot
2013-02-19 5:22 ` [lm-sensors] " Alex Courbot
2013-02-19 10:58 ` Wei Ni
2013-02-19 10:58 ` Wei Ni
2013-02-19 10:58 ` [lm-sensors] " Wei Ni
[not found] ` <1361187031-3679-7-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-19 23:18 ` Stephen Warren
2013-02-19 23:18 ` Stephen Warren
2013-02-19 23:18 ` [lm-sensors] " Stephen Warren
2013-02-20 10:40 ` Wei Ni
2013-02-20 10:40 ` Wei Ni
2013-02-20 10:40 ` [lm-sensors] " Wei Ni
2013-02-18 11:30 ` [RFC PATCH 8/9] ARM: dt: t30 cardhu: add dt entry for thermal driver Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
2013-02-19 3:42 ` Alex Courbot
2013-02-19 3:42 ` Alex Courbot
2013-02-19 3:42 ` [lm-sensors] " Alex Courbot
2013-02-19 9:56 ` Wei Ni
2013-02-19 9:56 ` Wei Ni
2013-02-19 9:56 ` [lm-sensors] " Wei Ni
[not found] ` <1361187031-3679-9-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-19 23:28 ` Stephen Warren
2013-02-19 23:28 ` Stephen Warren
2013-02-19 23:28 ` [lm-sensors] " Stephen Warren
2013-02-20 11:53 ` Wei Ni
2013-02-20 11:53 ` Wei Ni
2013-02-20 11:53 ` [lm-sensors] " Wei Ni
[not found] ` <5124B934.3020900-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-20 17:18 ` Stephen Warren
2013-02-20 17:18 ` Stephen Warren
2013-02-20 17:18 ` [lm-sensors] " Stephen Warren
2013-02-18 11:30 ` [RFC PATCH 9/9] ARM: tegra: defconfig: enable thermal framework Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
2013-02-18 11:30 ` [RFC PATCH 2/9] hwmon: (lm90) split set&show temp as common codes Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
2013-02-18 22:29 ` Matthew Longnecker
2013-02-18 22:29 ` Matthew Longnecker
2013-02-18 22:29 ` [lm-sensors] " Matthew Longnecker
2013-02-19 9:48 ` Wei Ni
2013-02-19 9:48 ` Wei Ni
2013-02-19 9:48 ` [lm-sensors] " Wei Ni
2013-02-19 3:31 ` Guenter Roeck
2013-02-19 3:31 ` Guenter Roeck
2013-02-19 3:31 ` Guenter Roeck
[not found] ` <20130219033144.GA25610-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-19 10:00 ` Wei Ni
2013-02-19 10:00 ` Wei Ni
2013-02-19 10:00 ` Wei Ni
2013-02-19 22:56 ` Stephen Warren
2013-02-19 22:56 ` Stephen Warren
2013-02-19 22:56 ` [lm-sensors] " Stephen Warren
[not found] ` <51240331.7080604-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-20 12:31 ` Wei Ni
2013-02-20 12:31 ` Wei Ni
2013-02-20 12:31 ` [lm-sensors] " Wei Ni
2013-02-18 11:30 ` [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11 Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
2013-02-19 5:39 ` Alex Courbot
2013-02-19 5:39 ` Alex Courbot
2013-02-19 5:39 ` [lm-sensors] " Alex Courbot
[not found] ` <5123100A.9050604-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-19 9:58 ` Wei Ni
2013-02-19 9:58 ` Wei Ni
2013-02-19 9:58 ` [lm-sensors] " Wei Ni
2013-02-19 23:02 ` Stephen Warren [this message]
2013-02-19 23:02 ` Stephen Warren
2013-02-19 23:02 ` [lm-sensors] " Stephen Warren
[not found] ` <51240497.8010909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-20 10:29 ` Wei Ni
2013-02-20 10:29 ` Wei Ni
2013-02-20 10:29 ` [lm-sensors] " Wei Ni
2013-02-18 11:30 ` [RFC PATCH 7/9] thermal: tegra30: add tegra30 thermal driver Wei Ni
2013-02-18 11:30 ` Wei Ni
2013-02-18 11:30 ` [lm-sensors] " Wei Ni
2013-02-19 23:48 ` Stephen Warren
2013-02-19 23:48 ` Stephen Warren
2013-02-19 23:48 ` [lm-sensors] " Stephen Warren
2013-02-20 12:23 ` Wei Ni
2013-02-20 12:23 ` Wei Ni
2013-02-20 12:23 ` [lm-sensors] " Wei Ni
2013-02-19 23:56 ` Russell King - ARM Linux
2013-02-19 23:56 ` Russell King - ARM Linux
2013-02-19 23:56 ` [lm-sensors] " Russell King - ARM Linux
[not found] ` <20130219235629.GU17833-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2013-02-20 12:29 ` Wei Ni
2013-02-20 12:29 ` Wei Ni
2013-02-20 12:29 ` [lm-sensors] " Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51240497.8010909@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=MLongnecker@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=durgadoss.r@intel.com \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.orgrs.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rui.zhang@intel.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.