From: Hartmut Knaack <knaack.h@gmx.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <jic23@cam.ac.uk>,
lm-sensors@lm-sensors.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/9] hwmon: (adt7410) Clear unwanted bits in the config register
Date: Wed, 20 Feb 2013 00:03:00 +0100 [thread overview]
Message-ID: <512404A4.1010200@gmx.de> (raw)
In-Reply-To: <1360947438-2550-1-git-send-email-lars@metafoo.de>
Lars-Peter Clausen schrieb:
> Make sure to clear the mode bits from the config register before setting the new
> mode. Otherwise we might end up with a different mode than we want to.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Hartmut Knaack <knaack.h@gmx.de>
> ---
> drivers/hwmon/adt7410.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
> index 797c2b8..4ccee4f 100644
> --- a/drivers/hwmon/adt7410.c
> +++ b/drivers/hwmon/adt7410.c
> @@ -364,6 +364,7 @@ static int adt7410_probe(struct i2c_client *client,
> /*
> * Set to 16 bit resolution, continous conversion and comparator mode.
> */
> + ret &= ~ADT7410_MODE_MASK;
> data->config = ret | ADT7410_FULL | ADT7410_RESOLUTION |
> ADT7410_EVENT_MODE;
> if (data->config != data->oldconfig) {
WARNING: multiple messages have this Message-ID (diff)
From: Hartmut Knaack <knaack.h@gmx.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <jic23@cam.ac.uk>,
lm-sensors@lm-sensors.org, linux-iio@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/9] hwmon: (adt7410) Clear unwanted bits in the config register
Date: Tue, 19 Feb 2013 23:03:00 +0000 [thread overview]
Message-ID: <512404A4.1010200@gmx.de> (raw)
In-Reply-To: <1360947438-2550-1-git-send-email-lars@metafoo.de>
Lars-Peter Clausen schrieb:
> Make sure to clear the mode bits from the config register before setting the new
> mode. Otherwise we might end up with a different mode than we want to.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Hartmut Knaack <knaack.h@gmx.de>
> ---
> drivers/hwmon/adt7410.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
> index 797c2b8..4ccee4f 100644
> --- a/drivers/hwmon/adt7410.c
> +++ b/drivers/hwmon/adt7410.c
> @@ -364,6 +364,7 @@ static int adt7410_probe(struct i2c_client *client,
> /*
> * Set to 16 bit resolution, continous conversion and comparator mode.
> */
> + ret &= ~ADT7410_MODE_MASK;
> data->config = ret | ADT7410_FULL | ADT7410_RESOLUTION |
> ADT7410_EVENT_MODE;
> if (data->config != data->oldconfig) {
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-02-19 23:03 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 16:57 [PATCH 1/9] hwmon: (adt7410) Clear unwanted bits in the config register Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 16:57 ` [PATCH 2/9] hwmon: (adt7410) Let suspend/resume depend on CONFIG_PM_SLEEP Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 20:07 ` Guenter Roeck
2013-02-15 20:07 ` [lm-sensors] " Guenter Roeck
2013-02-19 23:07 ` Hartmut Knaack
2013-02-19 23:07 ` [lm-sensors] " Hartmut Knaack
2013-02-15 16:57 ` [PATCH 3/9] hwmon: (adt7410) Use the SIMPLE_DEV_PM_OPS helper macro Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 20:07 ` Guenter Roeck
2013-02-15 20:07 ` [lm-sensors] " Guenter Roeck
2013-02-19 23:13 ` Hartmut Knaack
2013-02-19 23:13 ` [lm-sensors] " Hartmut Knaack
2013-02-15 16:57 ` [PATCH 4/9] hwmon: (adt7410) Use I2C_ADDRS " Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 20:07 ` Guenter Roeck
2013-02-15 20:07 ` [lm-sensors] " Guenter Roeck
2013-02-19 23:17 ` Hartmut Knaack
2013-02-19 23:17 ` [lm-sensors] " Hartmut Knaack
2013-02-15 16:57 ` [PATCH 5/9] hwmon: (adt7410) Add device table entry for the adt7420 Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 20:08 ` Guenter Roeck
2013-02-15 20:08 ` [lm-sensors] " Guenter Roeck
2013-02-19 23:21 ` Hartmut Knaack
2013-02-19 23:21 ` [lm-sensors] " Hartmut Knaack
2013-02-21 0:10 ` Hartmut Knaack
2013-02-21 0:10 ` [lm-sensors] " Hartmut Knaack
2013-02-15 16:57 ` [PATCH 6/9] hwmon: (adt7410) Don't re-read non-volatile registers Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 20:20 ` Guenter Roeck
2013-02-15 20:20 ` [lm-sensors] " Guenter Roeck
2013-02-16 15:56 ` Lars-Peter Clausen
2013-02-16 15:56 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 16:57 ` [PATCH 7/9] hwmon: (adt7410) Add support for the adt7310/adt7320 Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] [PATCH 7/9] hwmon: (adt7410) Add =?utf-8?q?_support_for_the_adt73 Lars-Peter Clausen
2013-02-15 20:05 ` [PATCH 7/9] hwmon: (adt7410) Add support for the adt7310/adt7320 Hartmut Knaack
2013-02-15 20:05 ` [lm-sensors] " Hartmut Knaack
2013-02-16 0:40 ` Andrey Repin
2013-02-16 15:49 ` Lars-Peter Clausen
2013-02-16 15:54 ` Lars-Peter Clausen
2013-02-16 15:54 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 20:32 ` Guenter Roeck
2013-02-15 20:32 ` [lm-sensors] " Guenter Roeck
2013-02-16 16:04 ` Lars-Peter Clausen
2013-02-16 16:04 ` [lm-sensors] " Lars-Peter Clausen
2013-02-16 19:15 ` Guenter Roeck
2013-02-16 19:15 ` [lm-sensors] " Guenter Roeck
2013-02-15 16:57 ` [PATCH 8/9] hwmon: (adt7x10) Add alarm interrupt support Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 16:57 ` [PATCH 9/9] staging:iio: Remove adt7410 driver Lars-Peter Clausen
2013-02-15 16:57 ` [lm-sensors] " Lars-Peter Clausen
2013-02-15 20:06 ` [PATCH 1/9] hwmon: (adt7410) Clear unwanted bits in the config register Guenter Roeck
2013-02-15 20:06 ` [lm-sensors] " Guenter Roeck
2013-02-19 23:03 ` Hartmut Knaack [this message]
2013-02-19 23:03 ` Hartmut Knaack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512404A4.1010200@gmx.de \
--to=knaack.h@gmx.de \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.