All of lore.kernel.org
 help / color / mirror / Atom feed
From: dirk.behme@de.bosch.com (Dirk Behme)
To: linux-arm-kernel@lists.infradead.org
Subject: i.MX6 Solo: maxcpus=1 vs. nosmp: Warning from smp_twd.c?
Date: Thu, 21 Feb 2013 08:16:01 +0100	[thread overview]
Message-ID: <5125C9B1.8050209@de.bosch.com> (raw)
In-Reply-To: <20130218025021.GI6782@S2101-09.ap.freescale.net>

On 18.02.2013 03:50, Shawn Guo wrote:
> On Thu, Feb 14, 2013 at 02:37:52PM +0000, Russell King - ARM Linux wrote:
>> On Thu, Feb 14, 2013 at 03:10:43PM +0100, Dirk Behme wrote:
>>> working on a i.MX6 Solo SoC (one Cortex A9 core) we are usually booting  
>>> with maxcpus=1 a kernel built with CONFIG_NR_CPUS=4. This is done to be  
>>> able to boot the same kernel on the Solo and Quad version of that SoC.
>> And what happens if you compile a kernel without SMP support and boot
>> it on this SoC?
> 
> Thanks Dirk for bringing this up on the list.  We have hit this fat
> warning on FSL internal 3.5.7 kernel tree when booting SMP kernel with
> nosmp on kernel cmdline.
> 
> As what Dirk confirmed, we do not see the warning with kernel built
> with !SMP.
> 
> Russell,
> 
> The following is an immediate and less invasive change to lower the
> warning level.  If you agree, I will post a patch and then put it
> into patch system.
> 
> Shawn
> 
> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
> index c092115..f796b83 100644
> --- a/arch/arm/kernel/smp_twd.c
> +++ b/arch/arm/kernel/smp_twd.c
> @@ -392,6 +392,6 @@ void __init twd_local_timer_of_register(void)
>         err = twd_local_timer_common_register(np);
> 
>  out:
> -       WARN(err, "twd_local_timer_of_register failed (%d)\n", err);
> +       pr_warn("twd_local_timer_of_register failed (%d)\n", err);
>  }
>  #endif

Any news on this? Time to move it to the patch system?

Thanks

Dirk

  reply	other threads:[~2013-02-21  7:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 14:10 i.MX6 Solo: maxcpus=1 vs. nosmp: Warning from smp_twd.c? Dirk Behme
2013-02-14 14:37 ` Russell King - ARM Linux
2013-02-15  9:25   ` Dirk Behme
2013-02-18  2:50   ` Shawn Guo
2013-02-21  7:16     ` Dirk Behme [this message]
2013-02-21  7:29       ` Shawn Guo
2013-02-14 14:40 ` Fabio Estevam
2013-02-14 14:47   ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5125C9B1.8050209@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.