All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: hch@infradead.org, xfs@oss.sgi.com
Subject: Re: [PATCH V2] xfsprogs: Fix possible unallocated memory access in fiemap
Date: Thu, 21 Feb 2013 09:28:08 -0600	[thread overview]
Message-ID: <51263D08.5060307@sgi.com> (raw)
In-Reply-To: <5102F4BE.6060009@sandeen.net>

On 01/25/13 15:10, Eric Sandeen wrote:
> (Based on original patch by Lukas Czerner&  comments by Dave Chinner)
>
> Currently we could access unallocated memory in fiemap because we're
> using uninitialized variable 'fiemap' in fiemap_f(). In fact this has
> been spotted on x390s machine where xfs_io would segfault.
>
> The problem happens in the for cycle which seems to be intended to
> compute the header item spacing. However at that point the fiemap
> structure has just been allocated and does not contain any extents
> yet, so it is entirely useless and it never actually worked.
>
> This patch delays the format calculation until the first batch
> of extents has come in for analysis.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---

A working calculated format is a great improvement.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

           reply	other threads:[~2013-02-21 15:28 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <5102F4BE.6060009@sandeen.net>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51263D08.5060307@sgi.com \
    --to=tinguely@sgi.com \
    --cc=hch@infradead.org \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.