* Re: [PATCH V2] xfsprogs: Fix possible unallocated memory access in fiemap
[not found] ` <5102F4BE.6060009@sandeen.net>
@ 2013-02-21 15:28 ` Mark Tinguely
0 siblings, 0 replies; only message in thread
From: Mark Tinguely @ 2013-02-21 15:28 UTC (permalink / raw)
To: Eric Sandeen; +Cc: hch, xfs
On 01/25/13 15:10, Eric Sandeen wrote:
> (Based on original patch by Lukas Czerner& comments by Dave Chinner)
>
> Currently we could access unallocated memory in fiemap because we're
> using uninitialized variable 'fiemap' in fiemap_f(). In fact this has
> been spotted on x390s machine where xfs_io would segfault.
>
> The problem happens in the for cycle which seems to be intended to
> compute the header item spacing. However at that point the fiemap
> structure has just been allocated and does not contain any extents
> yet, so it is entirely useless and it never actually worked.
>
> This patch delays the format calculation until the first batch
> of extents has come in for analysis.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
A working calculated format is a great improvement.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-02-21 15:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1355319059-12111-1-git-send-email-lczerner@redhat.com>
[not found] ` <20121212231245.GY16353@dastard>
[not found] ` <alpine.LFD.2.00.1212131024460.17970@localhost>
[not found] ` <20121213230608.GI16353@dastard>
[not found] ` <5102F4BE.6060009@sandeen.net>
2013-02-21 15:28 ` [PATCH V2] xfsprogs: Fix possible unallocated memory access in fiemap Mark Tinguely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.