All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: thomas.lendacky@amd.com, msalter@redhat.com,
	herbert@gondor.apana.org.au, al.stone@linaro.org,
	rjw@rjwysocki.net, catalin.marinas@arm.com,
	linaro-acpi@lists.linaro.org, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-acpi@vger.kernel.org, leo.duran@amd.com,
	hanjun.guo@linaro.org,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
	netdev@vger.kernel.org, grant.likely@linaro.org,
	davem@davemloft.net, lenb@kernel.org
Subject: Re: [V2 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object
Date: Tue, 05 May 2015 17:44:49 +0200	[thread overview]
Message-ID: <5126612.k0u2CL2zi5@wuerfel> (raw)
In-Reply-To: <1430838729-21572-3-git-send-email-Suravee.Suthikulpanit@amd.com>

On Tuesday 05 May 2015 10:12:06 Suravee Suthikulpanit wrote:
> +struct dma_map_ops dummy_dma_ops = {
> +       .alloc                  = __dummy_alloc,
> +       .free                   = __dummy_free,
> +       .mmap                   = __dummy_mmap,
> +       .map_page               = __dummy_map_page,
> +       .unmap_page             = __dummy_unmap_page,
> +       .map_sg                 = __dummy_map_sg,
> +       .unmap_sg               = __dummy_unmap_sg,
> +       .sync_single_for_cpu    = __dummy_sync_single_for_cpu,
> +       .sync_single_for_device = __dummy_sync_single_for_device,
> +       .sync_sg_for_cpu        = __dummy_sync_sg_for_cpu,
> +       .sync_sg_for_device     = __dummy_sync_sg_for_device,
> +       .mapping_error          = __dummy_mapping_error,
> +       .dma_supported          = __dummy_dma_supported,
> +};
> +EXPORT_SYMBOL(dummy_dma_ops);
> +
> 

This will clearly work, but I think it's easier to just leave
the dma_mask pointer as NULL when creating the platform device,
which should let the normal dma ops fail all the callbacks.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [V2 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object
Date: Tue, 05 May 2015 17:44:49 +0200	[thread overview]
Message-ID: <5126612.k0u2CL2zi5@wuerfel> (raw)
In-Reply-To: <1430838729-21572-3-git-send-email-Suravee.Suthikulpanit@amd.com>

On Tuesday 05 May 2015 10:12:06 Suravee Suthikulpanit wrote:
> +struct dma_map_ops dummy_dma_ops = {
> +       .alloc                  = __dummy_alloc,
> +       .free                   = __dummy_free,
> +       .mmap                   = __dummy_mmap,
> +       .map_page               = __dummy_map_page,
> +       .unmap_page             = __dummy_unmap_page,
> +       .map_sg                 = __dummy_map_sg,
> +       .unmap_sg               = __dummy_unmap_sg,
> +       .sync_single_for_cpu    = __dummy_sync_single_for_cpu,
> +       .sync_single_for_device = __dummy_sync_single_for_device,
> +       .sync_sg_for_cpu        = __dummy_sync_sg_for_cpu,
> +       .sync_sg_for_device     = __dummy_sync_sg_for_device,
> +       .mapping_error          = __dummy_mapping_error,
> +       .dma_supported          = __dummy_dma_supported,
> +};
> +EXPORT_SYMBOL(dummy_dma_ops);
> +
> 

This will clearly work, but I think it's easier to just leave
the dma_mask pointer as NULL when creating the platform device,
which should let the normal dma ops fail all the callbacks.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
	rjw@rjwysocki.net, lenb@kernel.org, catalin.marinas@arm.com,
	will.deacon@arm.com, thomas.lendacky@amd.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	al.stone@linaro.org, linaro-acpi@lists.linaro.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, leo.duran@amd.com,
	hanjun.guo@linaro.org, msalter@redhat.com,
	grant.likely@linaro.org, linux-crypto@vger.kernel.org
Subject: Re: [V2 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object
Date: Tue, 05 May 2015 17:44:49 +0200	[thread overview]
Message-ID: <5126612.k0u2CL2zi5@wuerfel> (raw)
In-Reply-To: <1430838729-21572-3-git-send-email-Suravee.Suthikulpanit@amd.com>

On Tuesday 05 May 2015 10:12:06 Suravee Suthikulpanit wrote:
> +struct dma_map_ops dummy_dma_ops = {
> +       .alloc                  = __dummy_alloc,
> +       .free                   = __dummy_free,
> +       .mmap                   = __dummy_mmap,
> +       .map_page               = __dummy_map_page,
> +       .unmap_page             = __dummy_unmap_page,
> +       .map_sg                 = __dummy_map_sg,
> +       .unmap_sg               = __dummy_unmap_sg,
> +       .sync_single_for_cpu    = __dummy_sync_single_for_cpu,
> +       .sync_single_for_device = __dummy_sync_single_for_device,
> +       .sync_sg_for_cpu        = __dummy_sync_sg_for_cpu,
> +       .sync_sg_for_device     = __dummy_sync_sg_for_device,
> +       .mapping_error          = __dummy_mapping_error,
> +       .dma_supported          = __dummy_dma_supported,
> +};
> +EXPORT_SYMBOL(dummy_dma_ops);
> +
> 

This will clearly work, but I think it's easier to just leave
the dma_mask pointer as NULL when creating the platform device,
which should let the normal dma ops fail all the callbacks.

	Arnd

  reply	other threads:[~2015-05-05 15:44 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 15:12 [V2 PATCH 0/5] Introduce ACPI _CCA support and device_dma_is_coherent API Suravee Suthikulpanit
2015-05-05 15:12 ` Suravee Suthikulpanit
2015-05-05 15:12 ` Suravee Suthikulpanit
2015-05-05 15:12 ` Suravee Suthikulpanit
2015-05-05 15:12 ` [V2 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 20:36   ` Rafael J. Wysocki
2015-05-05 20:36     ` Rafael J. Wysocki
2015-05-06  4:15     ` Suravee Suthikulpanit
2015-05-06  4:15       ` Suravee Suthikulpanit
2015-05-06  4:15       ` Suravee Suthikulpanit
2015-05-06 22:21       ` Rafael J. Wysocki
2015-05-06 22:21         ` Rafael J. Wysocki
2015-05-06 22:16         ` Suravee Suthikulanit
2015-05-06 22:16           ` Suravee Suthikulanit
2015-05-06 22:16           ` Suravee Suthikulanit
2015-05-07  9:07           ` [Linaro-acpi] " Arnd Bergmann
2015-05-07  9:07             ` Arnd Bergmann
2015-05-07 20:18             ` Rafael J. Wysocki
2015-05-07 20:18               ` Rafael J. Wysocki
2015-05-06  3:13   ` Hanjun Guo
2015-05-06  3:13     ` Hanjun Guo
2015-05-06  4:17     ` Suravee Suthikulpanit
2015-05-06  4:17       ` Suravee Suthikulpanit
2015-05-06  4:17       ` Suravee Suthikulpanit
2015-05-05 15:12 ` [V2 PATCH 2/5] arm64 : Introduce support for ACPI _CCA object Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:44   ` Arnd Bergmann [this message]
2015-05-05 15:44     ` Arnd Bergmann
2015-05-05 15:44     ` Arnd Bergmann
2015-05-05 16:09     ` Suravee Suthikulanit
2015-05-05 16:09       ` Suravee Suthikulanit
2015-05-05 16:09       ` Suravee Suthikulanit
2015-05-05 16:09       ` Suravee Suthikulanit
2015-05-05 16:12       ` [Linaro-acpi] " Arnd Bergmann
2015-05-05 16:12         ` Arnd Bergmann
2015-05-05 16:13         ` Suravee Suthikulanit
2015-05-05 16:13           ` Suravee Suthikulanit
2015-05-05 16:13           ` Suravee Suthikulanit
2015-05-05 16:24           ` Tom Lendacky
2015-05-05 16:24             ` Tom Lendacky
2015-05-05 16:24             ` Tom Lendacky
2015-05-05 18:02             ` Arnd Bergmann
2015-05-05 18:02               ` Arnd Bergmann
2015-05-06 10:08   ` Robin Murphy
2015-05-06 10:08     ` Robin Murphy
2015-05-06 14:34     ` Suravee Suthikulanit
2015-05-06 14:34       ` Suravee Suthikulanit
2015-05-05 15:12 ` [V2 PATCH 3/5] device property: Introduces device_dma_is_coherent() Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-06 23:52   ` Suravee Suthikulanit
2015-05-06 23:52     ` Suravee Suthikulanit
2015-05-06 23:52     ` Suravee Suthikulanit
2015-05-06 23:58     ` Rafael J. Wysocki
2015-05-06 23:58       ` Rafael J. Wysocki
2015-05-05 15:12 ` [V2 PATCH 4/5] crypto: ccp - Unify coherency checking logic with device_dma_is_coherent() Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12 ` [V2 PATCH 5/5] amd-xgbe: " Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit
2015-05-05 15:12   ` Suravee Suthikulpanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5126612.k0u2CL2zi5@wuerfel \
    --to=arnd@arndb.de \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=al.stone@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=grant.likely@linaro.org \
    --cc=hanjun.guo@linaro.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=lenb@kernel.org \
    --cc=leo.duran@amd.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msalter@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=thomas.lendacky@amd.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.