From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Tejun Heo <tj@kernel.org>
Cc: Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Marc Gauthier <marc@tensilica.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] memblock: add assertion for zero allocation size
Date: Fri, 22 Feb 2013 01:13:53 +0530 [thread overview]
Message-ID: <512678F9.8020603@synopsys.com> (raw)
In-Reply-To: <20130221193639.GN3570@htj.dyndns.org>
On Friday 22 February 2013 01:06 AM, Tejun Heo wrote:
> On Fri, Feb 22, 2013 at 01:03:41AM +0530, Vineet Gupta wrote:
>> Where - you mean if user passes 0, just make it 1. Nah - it's better to complain
>> and get the call site fixed !
>>
>>> or BUG_ON(!align) instead?
>> That could be done too but you would also need BUG_ON(!size) - to catch another
>> API abuse.
>> BUG_ON(!size) however catches both the cases.
> How about "if (WARN_ON(!align)) align = __alignof__(long long);"?
> Early BUG_ON()s can be painful to debug depending on setup.
Totally agree - been there - seen that :-)
Also for caller passing zero, the panic will force the caller to fix it.
I'll respin the patch.
Thx,
-Vineet
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Tejun Heo <tj@kernel.org>
Cc: Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Chris Zankel <chris@zankel.net>,
"Max Filippov" <jcmvbkbc@gmail.com>,
Marc Gauthier <marc@tensilica.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] memblock: add assertion for zero allocation size
Date: Fri, 22 Feb 2013 01:13:53 +0530 [thread overview]
Message-ID: <512678F9.8020603@synopsys.com> (raw)
In-Reply-To: <20130221193639.GN3570@htj.dyndns.org>
On Friday 22 February 2013 01:06 AM, Tejun Heo wrote:
> On Fri, Feb 22, 2013 at 01:03:41AM +0530, Vineet Gupta wrote:
>> Where - you mean if user passes 0, just make it 1. Nah - it's better to complain
>> and get the call site fixed !
>>
>>> or BUG_ON(!align) instead?
>> That could be done too but you would also need BUG_ON(!size) - to catch another
>> API abuse.
>> BUG_ON(!size) however catches both the cases.
> How about "if (WARN_ON(!align)) align = __alignof__(long long);"?
> Early BUG_ON()s can be painful to debug depending on setup.
Totally agree - been there - seen that :-)
Also for caller passing zero, the panic will force the caller to fix it.
I'll respin the patch.
Thx,
-Vineet
next prev parent reply other threads:[~2013-02-21 19:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361471962-25164-1-git-send-email-vgupta@synopsys.com>
2013-02-21 18:39 ` [PATCH 1/2] memblock: add assertion for zero allocation size Vineet Gupta
2013-02-21 18:39 ` Vineet Gupta
2013-02-21 19:27 ` Yinghai Lu
2013-02-21 19:27 ` Yinghai Lu
2013-02-21 19:33 ` Vineet Gupta
2013-02-21 19:33 ` Vineet Gupta
2013-02-21 19:36 ` Tejun Heo
2013-02-21 19:36 ` Tejun Heo
2013-02-21 19:43 ` Vineet Gupta [this message]
2013-02-21 19:43 ` Vineet Gupta
2013-02-21 20:10 ` [PATCH v2 1/2] memblock: add assertion for zero allocation alignment Vineet Gupta
2013-02-21 20:10 ` Vineet Gupta
2013-02-21 20:31 ` Yinghai Lu
2013-02-21 20:31 ` Yinghai Lu
2013-02-21 20:47 ` Vineet Gupta
2013-02-21 20:47 ` Vineet Gupta
2013-02-21 20:52 ` [PATCH v3 " Vineet Gupta
2013-02-21 20:52 ` Vineet Gupta
2013-02-21 20:53 ` Tejun Heo
2013-02-21 20:53 ` Tejun Heo
2013-03-04 11:15 ` Vineet Gupta
2013-03-04 11:15 ` Vineet Gupta
2013-02-21 18:39 ` [PATCH 2/2] xtensa: Flat DeviceTree copy not future-safe Vineet Gupta
2013-02-21 20:06 ` Max Filippov
2013-05-29 13:10 ` Fwd: " Vineet Gupta
2013-05-31 1:01 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512678F9.8020603@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=hpa@zytor.com \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=marc@tensilica.com \
--cc=mingo@kernel.org \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.