All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Unset LANG in setlocalversion script
Date: Thu, 21 Feb 2013 22:14:13 +0100	[thread overview]
Message-ID: <51268E25.6070104@suse.cz> (raw)
In-Reply-To: <201302211249.r1LCno6O024776@localhost.localdomain>

Dne 21.2.2013 13:49, Christophe Leroy napsal(a):
> This patch allows the use of setlocalversion script regardless of the LANG
> parameter. Otherwise, the `svn info 2>/dev/null | grep '^Last Changed Rev'`
> returns nothing because for instance, in French the text 'Last Changed Rev'
> is replaced by 'Révision de la derničre modification'

Unsetting LANG might not be enough. You should unset LC_ALL and set
LC_MESSAGES=C. But - is this a problem for other commands in the script?
From a quick look, we only parse English output of svn, so I suggest to
only set the env var for the svn command.

Michal

WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Unset LANG in setlocalversion script
Date: Thu, 21 Feb 2013 22:14:13 +0100	[thread overview]
Message-ID: <51268E25.6070104@suse.cz> (raw)
In-Reply-To: <201302211249.r1LCno6O024776@localhost.localdomain>

Dne 21.2.2013 13:49, Christophe Leroy napsal(a):
> This patch allows the use of setlocalversion script regardless of the LANG
> parameter. Otherwise, the `svn info 2>/dev/null | grep '^Last Changed Rev'`
> returns nothing because for instance, in French the text 'Last Changed Rev'
> is replaced by 'Révision de la derničre modification'

Unsetting LANG might not be enough. You should unset LC_ALL and set
LC_MESSAGES=C. But - is this a problem for other commands in the script?
>From a quick look, we only parse English output of svn, so I suggest to
only set the env var for the svn command.

Michal

  reply	other threads:[~2013-02-21 21:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-21 12:49 [PATCH] Unset LANG in setlocalversion script Christophe Leroy
2013-02-21 21:14 ` Michal Marek [this message]
2013-02-21 21:14   ` Michal Marek
2013-02-22  8:56   ` leroy christophe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51268E25.6070104@suse.cz \
    --to=mmarek@suse.cz \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.