* [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear
@ 2013-02-22 0:32 Hyeonsu Kim
2013-02-22 1:12 ` Jaehoon Chung
0 siblings, 1 reply; 6+ messages in thread
From: Hyeonsu Kim @ 2013-02-22 0:32 UTC (permalink / raw)
To: linux-mmc, cjb; +Cc: kyungmin.park, jh80.chung, Hyeonsu Kim
Signed-off-by: Hyeonsu Kim <hyeonsu.kim@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 323c502..390c15c 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -789,9 +789,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
/* DDR mode set */
if (ios->timing == MMC_TIMING_UHS_DDR50)
- regs |= (0x1 << slot->id) << 16;
+ regs |= ((0x1 << slot->id) << 16);
else
- regs &= ~(0x1 << slot->id) << 16;
+ regs &= ~((0x1 << slot->id) << 16);
mci_writel(slot->host, UHS_REG, regs);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear
2013-02-22 0:32 [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear Hyeonsu Kim
@ 2013-02-22 1:12 ` Jaehoon Chung
0 siblings, 0 replies; 6+ messages in thread
From: Jaehoon Chung @ 2013-02-22 1:12 UTC (permalink / raw)
To: Hyeonsu Kim; +Cc: linux-mmc, cjb, kyungmin.park, Seungwon Jeon
Plz add the commit message and CC'd Mr.Seungwon.
On 02/22/2013 09:32 AM, Hyeonsu Kim wrote:
> Signed-off-by: Hyeonsu Kim <hyeonsu.kim@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 323c502..390c15c 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -789,9 +789,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>
> /* DDR mode set */
> if (ios->timing == MMC_TIMING_UHS_DDR50)
> - regs |= (0x1 << slot->id) << 16;
> + regs |= ((0x1 << slot->id) << 16);
> else
> - regs &= ~(0x1 << slot->id) << 16;
> + regs &= ~((0x1 << slot->id) << 16);
>
> mci_writel(slot->host, UHS_REG, regs);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear
@ 2013-02-22 1:27 Hyeonsu Kim
2013-02-22 1:46 ` Jaehoon Chung
2013-02-22 11:16 ` Seungwon Jeon
0 siblings, 2 replies; 6+ messages in thread
From: Hyeonsu Kim @ 2013-02-22 1:27 UTC (permalink / raw)
To: linux-mmc, cjb, grant.likely, rob.herring
Cc: kyungmin.park, jh80.chung, tgih.jun, Hyeonsu Kim
In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit.
If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15 should be set by
1 according to slot id. In this case, legacy code can make problem.
Signed-off-by: Hyeonsu Kim <hyeonsu.kim@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 323c502..390c15c 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -789,9 +789,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
/* DDR mode set */
if (ios->timing == MMC_TIMING_UHS_DDR50)
- regs |= (0x1 << slot->id) << 16;
+ regs |= ((0x1 << slot->id) << 16);
else
- regs &= ~(0x1 << slot->id) << 16;
+ regs &= ~((0x1 << slot->id) << 16);
mci_writel(slot->host, UHS_REG, regs);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear
2013-02-22 1:27 Hyeonsu Kim
@ 2013-02-22 1:46 ` Jaehoon Chung
2013-02-22 11:16 ` Seungwon Jeon
1 sibling, 0 replies; 6+ messages in thread
From: Jaehoon Chung @ 2013-02-22 1:46 UTC (permalink / raw)
To: Hyeonsu Kim
Cc: linux-mmc, cjb, grant.likely, rob.herring, kyungmin.park,
tgih.jun
On 02/22/2013 10:27 AM, Hyeonsu Kim wrote:
> In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit.
> If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15 should be set by
> 1 according to slot id. In this case, legacy code can make problem.
UHS_REG register is consist of DDR_REG[31:16] and VOLT_REG[15:0].
Before adjusting this patch, bit[15:0] is always cleared.
So this patch looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> Signed-off-by: Hyeonsu Kim <hyeonsu.kim@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 323c502..390c15c 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -789,9 +789,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>
> /* DDR mode set */
> if (ios->timing == MMC_TIMING_UHS_DDR50)
> - regs |= (0x1 << slot->id) << 16;
> + regs |= ((0x1 << slot->id) << 16);
> else
> - regs &= ~(0x1 << slot->id) << 16;
> + regs &= ~((0x1 << slot->id) << 16);
>
> mci_writel(slot->host, UHS_REG, regs);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear
2013-02-22 1:27 Hyeonsu Kim
2013-02-22 1:46 ` Jaehoon Chung
@ 2013-02-22 11:16 ` Seungwon Jeon
2013-03-22 16:04 ` Chris Ball
1 sibling, 1 reply; 6+ messages in thread
From: Seungwon Jeon @ 2013-02-22 11:16 UTC (permalink / raw)
To: 'Hyeonsu Kim', linux-mmc, cjb, grant.likely, rob.herring
Cc: kyungmin.park, jh80.chung
On Friday, February 22, 2013, Hyeonsu Kim wrote:
> In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit.
> If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15 should be set by
> 1 according to slot id. In this case, legacy code can make problem.
>
> Signed-off-by: Hyeonsu Kim <hyeonsu.kim@samsung.com>
Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear
2013-02-22 11:16 ` Seungwon Jeon
@ 2013-03-22 16:04 ` Chris Ball
0 siblings, 0 replies; 6+ messages in thread
From: Chris Ball @ 2013-03-22 16:04 UTC (permalink / raw)
To: Seungwon Jeon
Cc: 'Hyeonsu Kim', linux-mmc, grant.likely, rob.herring,
kyungmin.park, jh80.chung
Hi,
On Fri, Feb 22 2013, Seungwon Jeon wrote:
> On Friday, February 22, 2013, Hyeonsu Kim wrote:
>> In the legacy code, driver clear not only UHS_REG 16 bit also 0-15bit.
>> If we use UHS-1 mode spec card like SDR50, SDR104. UHS_REG 0-15
>> should be set by
>> 1 according to slot id. In this case, legacy code can make problem.
>>
>> Signed-off-by: Hyeonsu Kim <hyeonsu.kim@samsung.com>
>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks, pushed to mmc-next for 3.10.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-22 16:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-22 0:32 [PATCH] mmc: dw_mmc: fixed a wrong UHS_REG 16 bit clear Hyeonsu Kim
2013-02-22 1:12 ` Jaehoon Chung
-- strict thread matches above, loose matches on Subject: below --
2013-02-22 1:27 Hyeonsu Kim
2013-02-22 1:46 ` Jaehoon Chung
2013-02-22 11:16 ` Seungwon Jeon
2013-03-22 16:04 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.