* [Qemu-trivial] [PATCH] ui/gtk: Fix build (missing include for setlocale)
@ 2013-02-22 6:28 Stefan Weil
2013-02-22 13:14 ` [Qemu-trivial] [Qemu-devel] " Anthony Liguori
2013-02-22 17:01 ` [Qemu-trivial] " Anthony Liguori
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Weil @ 2013-02-22 6:28 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil, Anthony Liguori
At least for Ubuntu Linux locale.h is needed.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
This is a build regression, please apply without waiting for qemu-trivial.
Thanks,
Stefan
ui/gtk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 29156be..5f91de4 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -37,6 +37,7 @@
#include <gtk/gtk.h>
#include <gdk/gdkkeysyms.h>
#include <glib/gi18n.h>
+#include <locale.h>
#include <vte/vte.h>
#include <sys/types.h>
#include <sys/socket.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] ui/gtk: Fix build (missing include for setlocale)
2013-02-22 6:28 [Qemu-trivial] [PATCH] ui/gtk: Fix build (missing include for setlocale) Stefan Weil
@ 2013-02-22 13:14 ` Anthony Liguori
2013-02-22 15:48 ` Stefan Weil
2013-02-22 17:01 ` [Qemu-trivial] " Anthony Liguori
1 sibling, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2013-02-22 13:14 UTC (permalink / raw)
To: Stefan Weil, qemu-devel; +Cc: qemu-trivial, Stefan Weil
Stefan Weil <sw@weilnetz.de> writes:
> At least for Ubuntu Linux locale.h is needed.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Thanks, what version of Ubuntu? I'm running 11.10 and don't have this
problem.
Regards,
Anthony Liguori
> ---
>
> This is a build regression, please apply without waiting for qemu-trivial.
>
> Thanks,
> Stefan
>
> ui/gtk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 29156be..5f91de4 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -37,6 +37,7 @@
> #include <gtk/gtk.h>
> #include <gdk/gdkkeysyms.h>
> #include <glib/gi18n.h>
> +#include <locale.h>
> #include <vte/vte.h>
> #include <sys/types.h>
> #include <sys/socket.h>
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] ui/gtk: Fix build (missing include for setlocale)
2013-02-22 13:14 ` [Qemu-trivial] [Qemu-devel] " Anthony Liguori
@ 2013-02-22 15:48 ` Stefan Weil
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2013-02-22 15:48 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-trivial, qemu-devel
Am 22.02.2013 14:14, schrieb Anthony Liguori:
> Stefan Weil <sw@weilnetz.de> writes:
>
>> At least for Ubuntu Linux locale.h is needed.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> Thanks, what version of Ubuntu? I'm running 11.10 and don't have this
> problem.
>
It's needed for Ubuntu Precise 12.04.2 LTS (32 bit), the latest LTS version,
so QEMU should support this environment.
I assume that other distributions include locale.h indirectly.
The man page of setlocale explicitly says that locale.h is the
required include file.
Regards,
Stefan Weil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [PATCH] ui/gtk: Fix build (missing include for setlocale)
2013-02-22 6:28 [Qemu-trivial] [PATCH] ui/gtk: Fix build (missing include for setlocale) Stefan Weil
2013-02-22 13:14 ` [Qemu-trivial] [Qemu-devel] " Anthony Liguori
@ 2013-02-22 17:01 ` Anthony Liguori
1 sibling, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2013-02-22 17:01 UTC (permalink / raw)
To: Stefan Weil, qemu-devel; +Cc: qemu-trivial, Stefan Weil, Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-22 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-22 6:28 [Qemu-trivial] [PATCH] ui/gtk: Fix build (missing include for setlocale) Stefan Weil
2013-02-22 13:14 ` [Qemu-trivial] [Qemu-devel] " Anthony Liguori
2013-02-22 15:48 ` Stefan Weil
2013-02-22 17:01 ` [Qemu-trivial] " Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.