From: Satoru Takeuchi <takeuchi_satoru-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: "H. Peter Anvin" <hpa-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Yinghai Lu <yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] x86, efi: Mark disable_runtime as __initdata
Date: Tue, 26 Feb 2013 08:55:06 +0900 [thread overview]
Message-ID: <512BF9DA.2050906@jp.fujitsu.com> (raw)
In-Reply-To: <1361545427-26393-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
(2013/02/23 0:03), Matt Fleming wrote:
> From: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> disable_runtime is only referenced from __init functions, so mark it
> as __initdata.
>
> Reported-by: Yinghai Lu <yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Satoru Takeuchi <takeuchi_satoru-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> Cc: H. Peter Anvin <hpa-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Signed-off-by: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
It looks good to me.
Reviewed-by: Satoru Takeuchi <takeuchi_satoru-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> ---
> arch/x86/platform/efi/efi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index 2f81db4..5ae99f9 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -85,7 +85,7 @@ int efi_enabled(int facility)
> }
> EXPORT_SYMBOL(efi_enabled);
>
> -static bool disable_runtime = false;
> +static bool __initdata disable_runtime = false;
> static int __init setup_noefi(char *arg)
> {
> disable_runtime = true;
>
WARNING: multiple messages have this Message-ID (diff)
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <linux-efi@vger.kernel.org>,
Yinghai Lu <yinghai@kernel.org>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH] x86, efi: Mark disable_runtime as __initdata
Date: Tue, 26 Feb 2013 08:55:06 +0900 [thread overview]
Message-ID: <512BF9DA.2050906@jp.fujitsu.com> (raw)
In-Reply-To: <1361545427-26393-1-git-send-email-matt@console-pimps.org>
(2013/02/23 0:03), Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> disable_runtime is only referenced from __init functions, so mark it
> as __initdata.
>
> Reported-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> Cc: H. Peter Anvin <hpa@linux.intel.com>
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
It looks good to me.
Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> ---
> arch/x86/platform/efi/efi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index 2f81db4..5ae99f9 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -85,7 +85,7 @@ int efi_enabled(int facility)
> }
> EXPORT_SYMBOL(efi_enabled);
>
> -static bool disable_runtime = false;
> +static bool __initdata disable_runtime = false;
> static int __init setup_noefi(char *arg)
> {
> disable_runtime = true;
>
next prev parent reply other threads:[~2013-02-25 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 15:03 [PATCH] x86, efi: Mark disable_runtime as __initdata Matt Fleming
2013-02-22 15:03 ` Matt Fleming
[not found] ` <1361545427-26393-1-git-send-email-matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-02-25 23:55 ` Satoru Takeuchi [this message]
2013-02-25 23:55 ` Satoru Takeuchi
2013-02-26 0:22 ` [tip:x86/urgent] " tip-bot for Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512BF9DA.2050906@jp.fujitsu.com \
--to=takeuchi_satoru-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=hpa-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.