* [PATCH] hiawatha: ennsure C flags are passed to builds.
@ 2013-02-12 22:22 Jeffrey C Honig
2013-02-13 10:44 ` Jack Mitchell
0 siblings, 1 reply; 9+ messages in thread
From: Jeffrey C Honig @ 2013-02-12 22:22 UTC (permalink / raw)
To: openembedded-devel; +Cc: jeffrey.honig
[ CQID: WIND00403568 ]
Hiawatha was overriding existing C flags instead of prepending warning flags.
This caused build failures on multilibs because the C compiler could not find
the proper sysroot.
Signed-off-by: Jeffrey C Honig <jeffrey.honig@windriver.com>
---
recipes-httpd/hiawatha/files/cmake.patch | 16 ++++++++++++++++
recipes-httpd/hiawatha/hiawatha_8.6.bb | 3 +++
2 files changed, 19 insertions(+)
create mode 100644 recipes-httpd/hiawatha/files/cmake.patch
diff --git a/recipes-httpd/hiawatha/files/cmake.patch b/recipes-httpd/hiawatha/files/cmake.patch
new file mode 100644
index 0000000..f597781
--- /dev/null
+++ b/recipes-httpd/hiawatha/files/cmake.patch
@@ -0,0 +1,16 @@
+It is necessary to include the original CMAKE_C_FLAGS to insure that
+the sysroot is passed to the compiler, instead of just setting warning
+options. Otherwise we'll get problem croos compiling in some
+circumstances.
+
+--- a/CMakeLists.txt 2012-10-31 14:16:45.000000000 -0400
++++ b/CMakeLists.txt 2013-02-12 14:07:04.297058345 -0500
+@@ -2,7 +2,7 @@
+ project(Hiawatha C)
+
+ # Compiler
+-set(CMAKE_C_FLAGS "-Wall -Wextra")
++set(CMAKE_C_FLAGS "-Wall -Wextra ${CMAKE_C_FLAGS}")
+ set(CMAKE_BUILD_TYPE "RelWithDebInfo")
+
+ # Options
diff --git a/recipes-httpd/hiawatha/hiawatha_8.6.bb b/recipes-httpd/hiawatha/hiawatha_8.6.bb
index 837354b..d46a525 100644
--- a/recipes-httpd/hiawatha/hiawatha_8.6.bb
+++ b/recipes-httpd/hiawatha/hiawatha_8.6.bb
@@ -4,9 +4,12 @@ LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
DEPENDS = "libxml2 libxslt"
+PR = "r1"
+
SECTION = "net"
SRC_URI = "http://hiawatha-webserver.org/files/${BPN}-${PV}.tar.gz \
+ file://cmake.patch \
file://hiawatha-init"
SRC_URI[md5sum] = "372ea9e8329ed36e4fb781fdc1a6734c"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] hiawatha: ennsure C flags are passed to builds.
2013-02-12 22:22 [PATCH] hiawatha: ennsure C flags are passed to builds Jeffrey C Honig
@ 2013-02-13 10:44 ` Jack Mitchell
2013-02-20 16:38 ` Mark Hatle
0 siblings, 1 reply; 9+ messages in thread
From: Jack Mitchell @ 2013-02-13 10:44 UTC (permalink / raw)
To: openembedded-devel
On 12/02/13 22:22, Jeffrey C Honig wrote:
> [ CQID: WIND00403568 ]
>
> Hiawatha was overriding existing C flags instead of prepending warning flags.
> This caused build failures on multilibs because the C compiler could not find
> the proper sysroot.
>
> Signed-off-by: Jeffrey C Honig <jeffrey.honig@windriver.com>
> ---
> recipes-httpd/hiawatha/files/cmake.patch | 16 ++++++++++++++++
> recipes-httpd/hiawatha/hiawatha_8.6.bb | 3 +++
> 2 files changed, 19 insertions(+)
> create mode 100644 recipes-httpd/hiawatha/files/cmake.patch
>
> diff --git a/recipes-httpd/hiawatha/files/cmake.patch b/recipes-httpd/hiawatha/files/cmake.patch
> new file mode 100644
> index 0000000..f597781
> --- /dev/null
> +++ b/recipes-httpd/hiawatha/files/cmake.patch
> @@ -0,0 +1,16 @@
> +It is necessary to include the original CMAKE_C_FLAGS to insure that
> +the sysroot is passed to the compiler, instead of just setting warning
> +options. Otherwise we'll get problem croos compiling in some
> +circumstances.
> +
> +--- a/CMakeLists.txt 2012-10-31 14:16:45.000000000 -0400
> ++++ b/CMakeLists.txt 2013-02-12 14:07:04.297058345 -0500
> +@@ -2,7 +2,7 @@
> + project(Hiawatha C)
> +
> + # Compiler
> +-set(CMAKE_C_FLAGS "-Wall -Wextra")
> ++set(CMAKE_C_FLAGS "-Wall -Wextra ${CMAKE_C_FLAGS}")
> + set(CMAKE_BUILD_TYPE "RelWithDebInfo")
> +
> + # Options
> diff --git a/recipes-httpd/hiawatha/hiawatha_8.6.bb b/recipes-httpd/hiawatha/hiawatha_8.6.bb
> index 837354b..d46a525 100644
> --- a/recipes-httpd/hiawatha/hiawatha_8.6.bb
> +++ b/recipes-httpd/hiawatha/hiawatha_8.6.bb
> @@ -4,9 +4,12 @@ LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
> DEPENDS = "libxml2 libxslt"
>
> +PR = "r1"
> +
> SECTION = "net"
>
> SRC_URI = "http://hiawatha-webserver.org/files/${BPN}-${PV}.tar.gz \
> + file://cmake.patch \
> file://hiawatha-init"
>
> SRC_URI[md5sum] = "372ea9e8329ed36e4fb781fdc1a6734c"
What's the upstream status on this? If you email Hugo (the developer)
directly he usually responds within a few hours and will pull the
changes into the next release.
Regards,
Jack.
--
Jack Mitchell (jack@embed.me.uk)
Embedded Systems Engineer
http://www.embed.me.uk
--
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] hiawatha: ennsure C flags are passed to builds.
2013-02-13 10:44 ` Jack Mitchell
@ 2013-02-20 16:38 ` Mark Hatle
2013-02-20 16:55 ` Paul Eggleton
0 siblings, 1 reply; 9+ messages in thread
From: Mark Hatle @ 2013-02-20 16:38 UTC (permalink / raw)
To: openembedded-devel; +Cc: Jeffrey C Honig
On 2/13/13 4:44 AM, Jack Mitchell wrote:
> On 12/02/13 22:22, Jeffrey C Honig wrote:
>> [ CQID: WIND00403568 ]
>>
>> Hiawatha was overriding existing C flags instead of prepending warning flags.
>> This caused build failures on multilibs because the C compiler could not find
>> the proper sysroot.
>>
>> Signed-off-by: Jeffrey C Honig <jeffrey.honig@windriver.com>
>> ---
>> recipes-httpd/hiawatha/files/cmake.patch | 16 ++++++++++++++++
>> recipes-httpd/hiawatha/hiawatha_8.6.bb | 3 +++
>> 2 files changed, 19 insertions(+)
>> create mode 100644 recipes-httpd/hiawatha/files/cmake.patch
>>
>> diff --git a/recipes-httpd/hiawatha/files/cmake.patch b/recipes-httpd/hiawatha/files/cmake.patch
>> new file mode 100644
>> index 0000000..f597781
>> --- /dev/null
>> +++ b/recipes-httpd/hiawatha/files/cmake.patch
>> @@ -0,0 +1,16 @@
>> +It is necessary to include the original CMAKE_C_FLAGS to insure that
>> +the sysroot is passed to the compiler, instead of just setting warning
>> +options. Otherwise we'll get problem croos compiling in some
>> +circumstances.
>> +
>> +--- a/CMakeLists.txt 2012-10-31 14:16:45.000000000 -0400
>> ++++ b/CMakeLists.txt 2013-02-12 14:07:04.297058345 -0500
>> +@@ -2,7 +2,7 @@
>> + project(Hiawatha C)
>> +
>> + # Compiler
>> +-set(CMAKE_C_FLAGS "-Wall -Wextra")
>> ++set(CMAKE_C_FLAGS "-Wall -Wextra ${CMAKE_C_FLAGS}")
>> + set(CMAKE_BUILD_TYPE "RelWithDebInfo")
>> +
>> + # Options
>> diff --git a/recipes-httpd/hiawatha/hiawatha_8.6.bb b/recipes-httpd/hiawatha/hiawatha_8.6.bb
>> index 837354b..d46a525 100644
>> --- a/recipes-httpd/hiawatha/hiawatha_8.6.bb
>> +++ b/recipes-httpd/hiawatha/hiawatha_8.6.bb
>> @@ -4,9 +4,12 @@ LICENSE = "GPLv2"
>> LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
>> DEPENDS = "libxml2 libxslt"
>>
>> +PR = "r1"
>> +
>> SECTION = "net"
>>
>> SRC_URI = "http://hiawatha-webserver.org/files/${BPN}-${PV}.tar.gz \
>> + file://cmake.patch \
>> file://hiawatha-init"
>>
>> SRC_URI[md5sum] = "372ea9e8329ed36e4fb781fdc1a6734c"
>
> What's the upstream status on this? If you email Hugo (the developer)
> directly he usually responds within a few hours and will pull the
> changes into the next release.
I'm following up for Jeff. He has contacted Hugo and the above patch has been
included upstream.
--Mark
> Regards,
> Jack.
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] hiawatha: ennsure C flags are passed to builds.
2013-02-20 16:38 ` Mark Hatle
@ 2013-02-20 16:55 ` Paul Eggleton
2013-02-20 18:19 ` Jeffrey Honig
0 siblings, 1 reply; 9+ messages in thread
From: Paul Eggleton @ 2013-02-20 16:55 UTC (permalink / raw)
To: openembedded-devel; +Cc: Jeffrey C Honig
On Wednesday 20 February 2013 10:38:29 Mark Hatle wrote:
> On 2/13/13 4:44 AM, Jack Mitchell wrote:
> > On 12/02/13 22:22, Jeffrey C Honig wrote:
> >> [ CQID: WIND00403568 ]
> >>
> >> Hiawatha was overriding existing C flags instead of prepending warning
> >> flags. This caused build failures on multilibs because the C compiler
> >> could not find the proper sysroot.
> >>
> >> Signed-off-by: Jeffrey C Honig <jeffrey.honig@windriver.com>
> >> ---
> >>
> >> recipes-httpd/hiawatha/files/cmake.patch | 16 ++++++++++++++++
> >> recipes-httpd/hiawatha/hiawatha_8.6.bb | 3 +++
> >> 2 files changed, 19 insertions(+)
> >> create mode 100644 recipes-httpd/hiawatha/files/cmake.patch
> >>
> >> diff --git a/recipes-httpd/hiawatha/files/cmake.patch
> >> b/recipes-httpd/hiawatha/files/cmake.patch new file mode 100644
> >> index 0000000..f597781
> >> --- /dev/null
> >> +++ b/recipes-httpd/hiawatha/files/cmake.patch
> >> @@ -0,0 +1,16 @@
> >> +It is necessary to include the original CMAKE_C_FLAGS to insure that
> >> +the sysroot is passed to the compiler, instead of just setting warning
> >> +options. Otherwise we'll get problem croos compiling in some
> >> +circumstances.
> >> +
> >> +--- a/CMakeLists.txt 2012-10-31 14:16:45.000000000 -0400
> >> ++++ b/CMakeLists.txt 2013-02-12 14:07:04.297058345 -0500
> >> +@@ -2,7 +2,7 @@
> >> + project(Hiawatha C)
> >> +
> >> + # Compiler
> >> +-set(CMAKE_C_FLAGS "-Wall -Wextra")
> >> ++set(CMAKE_C_FLAGS "-Wall -Wextra ${CMAKE_C_FLAGS}")
> >> + set(CMAKE_BUILD_TYPE "RelWithDebInfo")
> >> +
> >> + # Options
> >> diff --git a/recipes-httpd/hiawatha/hiawatha_8.6.bb
> >> b/recipes-httpd/hiawatha/hiawatha_8.6.bb index 837354b..d46a525 100644
> >> --- a/recipes-httpd/hiawatha/hiawatha_8.6.bb
> >> +++ b/recipes-httpd/hiawatha/hiawatha_8.6.bb
> >> @@ -4,9 +4,12 @@ LICENSE = "GPLv2"
> >>
> >> LIC_FILES_CHKSUM =
> >> "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
> >> DEPENDS = "libxml2 libxslt"
> >>
> >> +PR = "r1"
> >> +
> >>
> >> SECTION = "net"
> >>
> >> SRC_URI = "http://hiawatha-webserver.org/files/${BPN}-${PV}.tar.gz \
> >>
> >> + file://cmake.patch \
> >>
> >> file://hiawatha-init"
> >>
> >> SRC_URI[md5sum] = "372ea9e8329ed36e4fb781fdc1a6734c"
> >
> > What's the upstream status on this? If you email Hugo (the developer)
> > directly he usually responds within a few hours and will pull the
> > changes into the next release.
>
> I'm following up for Jeff. He has contacted Hugo and the above patch has
> been included upstream.
Great. Should I still apply this to meta-webserver then or do we wait for a
new upstream release?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] hiawatha: ennsure C flags are passed to builds.
2013-02-20 16:55 ` Paul Eggleton
@ 2013-02-20 18:19 ` Jeffrey Honig
2013-02-26 16:05 ` Jack Mitchell
0 siblings, 1 reply; 9+ messages in thread
From: Jeffrey Honig @ 2013-02-20 18:19 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-devel
Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> On Wednesday 20 February 2013 10:38:29 Mark Hatle wrote:
> > On 2/13/13 4:44 AM, Jack Mitchell wrote:
> > > On 12/02/13 22:22, Jeffrey C Honig wrote:
> > >> [ CQID: WIND00403568 ]
> > >>
> > >> Hiawatha was overriding existing C flags instead of prepending warning
> > >> flags. This caused build failures on multilibs because the C compiler
> > >> could not find the proper sysroot.
> > >>
> > >> Signed-off-by: Jeffrey C Honig <jeffrey.honig@windriver.com>
> > >> ---
> > >>
> > >> recipes-httpd/hiawatha/files/cmake.patch | 16 ++++++++++++++++
> > >> recipes-httpd/hiawatha/hiawatha_8.6.bb | 3 +++
> > >> 2 files changed, 19 insertions(+)
> > >> create mode 100644 recipes-httpd/hiawatha/files/cmake.patch
> > >>
> > >> diff --git a/recipes-httpd/hiawatha/files/cmake.patch
> > >> b/recipes-httpd/hiawatha/files/cmake.patch new file mode 100644
> > >> index 0000000..f597781
> > >> --- /dev/null
> > >> +++ b/recipes-httpd/hiawatha/files/cmake.patch
> > >> @@ -0,0 +1,16 @@
> > >> +It is necessary to include the original CMAKE_C_FLAGS to insure that
> > >> +the sysroot is passed to the compiler, instead of just setting warning
> > >> +options. Otherwise we'll get problem croos compiling in some
> > >> +circumstances.
> > >> +
> > >> +--- a/CMakeLists.txt 2012-10-31 14:16:45.000000000 -0400
> > >> ++++ b/CMakeLists.txt 2013-02-12 14:07:04.297058345 -0500
> > >> +@@ -2,7 +2,7 @@
> > >> + project(Hiawatha C)
> > >> +
> > >> + # Compiler
> > >> +-set(CMAKE_C_FLAGS "-Wall -Wextra")
> > >> ++set(CMAKE_C_FLAGS "-Wall -Wextra ${CMAKE_C_FLAGS}")
> > >> + set(CMAKE_BUILD_TYPE "RelWithDebInfo")
> > >> +
> > >> + # Options
> > >> diff --git a/recipes-httpd/hiawatha/hiawatha_8.6.bb
> > >> b/recipes-httpd/hiawatha/hiawatha_8.6.bb index 837354b..d46a525 100644
> > >> --- a/recipes-httpd/hiawatha/hiawatha_8.6.bb
> > >> +++ b/recipes-httpd/hiawatha/hiawatha_8.6.bb
> > >> @@ -4,9 +4,12 @@ LICENSE = "GPLv2"
> > >>
> > >> LIC_FILES_CHKSUM =
> > >> "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
> > >> DEPENDS = "libxml2 libxslt"
> > >>
> > >> +PR = "r1"
> > >> +
> > >>
> > >> SECTION = "net"
> > >>
> > >> SRC_URI = "http://hiawatha-webserver.org/files/${BPN}-${PV}.tar.gz \
> > >>
> > >> + file://cmake.patch \
> > >>
> > >> file://hiawatha-init"
> > >>
> > >> SRC_URI[md5sum] = "372ea9e8329ed36e4fb781fdc1a6734c"
> > >
> > > What's the upstream status on this? If you email Hugo (the developer)
> > > directly he usually responds within a few hours and will pull the
> > > changes into the next release.
> >
> > I'm following up for Jeff. He has contacted Hugo and the above patch has
> > been included upstream.
>
> Great. Should I still apply this to meta-webserver then or do we wait for a
> new upstream release?
We have a local patch applied, we are good. It is fine to wait.
Thanks!
Jeff
--
Jeffrey C. Honig
Manager of Linux Products Division / SDT
Wind River (风河)
+1.607.216.8613
http://www.windriver.com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] hiawatha: ennsure C flags are passed to builds.
2013-02-20 18:19 ` Jeffrey Honig
@ 2013-02-26 16:05 ` Jack Mitchell
2013-02-26 17:42 ` Khem Raj
0 siblings, 1 reply; 9+ messages in thread
From: Jack Mitchell @ 2013-02-26 16:05 UTC (permalink / raw)
To: openembedded-devel
On 20/02/13 18:19, Jeffrey Honig wrote:
> Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
>
>> On Wednesday 20 February 2013 10:38:29 Mark Hatle wrote:
>>> On 2/13/13 4:44 AM, Jack Mitchell wrote:
>>>> On 12/02/13 22:22, Jeffrey C Honig wrote:
>>>>> [ CQID: WIND00403568 ]
>>>>>
>>>>> Hiawatha was overriding existing C flags instead of prepending warning
>>>>> flags. This caused build failures on multilibs because the C compiler
>>>>> could not find the proper sysroot.
>>>>>
>>>>> Signed-off-by: Jeffrey C Honig <jeffrey.honig@windriver.com>
>>>>> ---
>>>>>
>>>>> recipes-httpd/hiawatha/files/cmake.patch | 16 ++++++++++++++++
>>>>> recipes-httpd/hiawatha/hiawatha_8.6.bb | 3 +++
>>>>> 2 files changed, 19 insertions(+)
>>>>> create mode 100644 recipes-httpd/hiawatha/files/cmake.patch
>>>>>
>>>>> diff --git a/recipes-httpd/hiawatha/files/cmake.patch
>>>>> b/recipes-httpd/hiawatha/files/cmake.patch new file mode 100644
>>>>> index 0000000..f597781
>>>>> --- /dev/null
>>>>> +++ b/recipes-httpd/hiawatha/files/cmake.patch
>>>>> @@ -0,0 +1,16 @@
>>>>> +It is necessary to include the original CMAKE_C_FLAGS to insure that
>>>>> +the sysroot is passed to the compiler, instead of just setting warning
>>>>> +options. Otherwise we'll get problem croos compiling in some
>>>>> +circumstances.
>>>>> +
>>>>> +--- a/CMakeLists.txt 2012-10-31 14:16:45.000000000 -0400
>>>>> ++++ b/CMakeLists.txt 2013-02-12 14:07:04.297058345 -0500
>>>>> +@@ -2,7 +2,7 @@
>>>>> + project(Hiawatha C)
>>>>> +
>>>>> + # Compiler
>>>>> +-set(CMAKE_C_FLAGS "-Wall -Wextra")
>>>>> ++set(CMAKE_C_FLAGS "-Wall -Wextra ${CMAKE_C_FLAGS}")
>>>>> + set(CMAKE_BUILD_TYPE "RelWithDebInfo")
>>>>> +
>>>>> + # Options
>>>>> diff --git a/recipes-httpd/hiawatha/hiawatha_8.6.bb
>>>>> b/recipes-httpd/hiawatha/hiawatha_8.6.bb index 837354b..d46a525 100644
>>>>> --- a/recipes-httpd/hiawatha/hiawatha_8.6.bb
>>>>> +++ b/recipes-httpd/hiawatha/hiawatha_8.6.bb
>>>>> @@ -4,9 +4,12 @@ LICENSE = "GPLv2"
>>>>>
>>>>> LIC_FILES_CHKSUM =
>>>>> "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe"
>>>>> DEPENDS = "libxml2 libxslt"
>>>>>
>>>>> +PR = "r1"
>>>>> +
>>>>>
>>>>> SECTION = "net"
>>>>>
>>>>> SRC_URI = "http://hiawatha-webserver.org/files/${BPN}-${PV}.tar.gz \
>>>>>
>>>>> + file://cmake.patch \
>>>>>
>>>>> file://hiawatha-init"
>>>>>
>>>>> SRC_URI[md5sum] = "372ea9e8329ed36e4fb781fdc1a6734c"
>>>> What's the upstream status on this? If you email Hugo (the developer)
>>>> directly he usually responds within a few hours and will pull the
>>>> changes into the next release.
>>> I'm following up for Jeff. He has contacted Hugo and the above patch has
>>> been included upstream.
>> Great. Should I still apply this to meta-webserver then or do we wait for a
>> new upstream release?
> We have a local patch applied, we are good. It is fine to wait.
>
> Thanks!
>
> Jeff
>
8.8 has been released if someone wants to pick this up. I would myself
but I'm currently blocked by a binutils failure.
--
Jack Mitchell (jack@embed.me.uk)
Embedded Systems Engineer
http://www.embed.me.uk
--
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-02-26 21:14 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-12 22:22 [PATCH] hiawatha: ennsure C flags are passed to builds Jeffrey C Honig
2013-02-13 10:44 ` Jack Mitchell
2013-02-20 16:38 ` Mark Hatle
2013-02-20 16:55 ` Paul Eggleton
2013-02-20 18:19 ` Jeffrey Honig
2013-02-26 16:05 ` Jack Mitchell
2013-02-26 17:42 ` Khem Raj
2013-02-26 18:35 ` Jack Mitchell
2013-02-26 20:58 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.