* [PATCH] handsfree-audio: Fix missing card index increment
@ 2013-02-26 21:42 Claudio Takahasi
2013-02-26 21:48 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Claudio Takahasi @ 2013-02-26 21:42 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
---
src/handsfree-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c
index db65971..acd08e4 100644
--- a/src/handsfree-audio.c
+++ b/src/handsfree-audio.c
@@ -165,7 +165,7 @@ int ofono_handsfree_card_register(struct ofono_handsfree_card *card)
if (card == NULL)
return -EINVAL;
- snprintf(path, sizeof(path), "/card_%d", next_card_id);
+ snprintf(path, sizeof(path), "/card_%d", next_card_id++);
if (!g_dbus_register_interface(ofono_dbus_get_connection(), path,
HFP_AUDIO_CARD_INTERFACE,
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] handsfree-audio: Fix missing card index increment
2013-02-26 21:42 [PATCH] handsfree-audio: Fix missing card index increment Claudio Takahasi
@ 2013-02-26 21:48 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2013-02-26 21:48 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi Claudio,
On 02/26/2013 03:42 PM, Claudio Takahasi wrote:
> ---
> src/handsfree-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c
> index db65971..acd08e4 100644
> --- a/src/handsfree-audio.c
> +++ b/src/handsfree-audio.c
> @@ -165,7 +165,7 @@ int ofono_handsfree_card_register(struct ofono_handsfree_card *card)
> if (card == NULL)
> return -EINVAL;
>
> - snprintf(path, sizeof(path), "/card_%d", next_card_id);
> + snprintf(path, sizeof(path), "/card_%d", next_card_id++);
>
> if (!g_dbus_register_interface(ofono_dbus_get_connection(), path,
> HFP_AUDIO_CARD_INTERFACE,
Darn, I had to forget something :)
My own fix pushed that is a little bit more paranoid.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-26 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 21:42 [PATCH] handsfree-audio: Fix missing card index increment Claudio Takahasi
2013-02-26 21:48 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.