From: Sekhar Nori <nsekhar@ti.com>
To: "Manjunathappa, Prakash" <prakash.pm@ti.com>
Cc: linux-mmc@vger.kernel.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk,
hs@denx.de, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
cjb@laptop.org, davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH v4 1/5] ARM: davinci: mmc: derive version information from device name
Date: Wed, 27 Feb 2013 17:15:59 +0530 [thread overview]
Message-ID: <512DF1F7.6010508@ti.com> (raw)
In-Reply-To: <1360909322-1858-2-git-send-email-prakash.pm@ti.com>
On 2/15/2013 11:51 AM, Manjunathappa, Prakash wrote:
> Remove specifying mmc controller IP version information via platform
> data, instead specify device name so that driver derives it from
> platform_device_id table. Also change the clock node name to match
> the changed dev_id.
> Tested on da850-evm to make sure driver loads without clk_get failures.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
The patch looks good to me, but after this patch MMC/SD will be broken.
I suggest merging this into 2/5. It makes little sense without those
changes anyway.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] ARM: davinci: mmc: derive version information from device name
Date: Wed, 27 Feb 2013 17:15:59 +0530 [thread overview]
Message-ID: <512DF1F7.6010508@ti.com> (raw)
In-Reply-To: <1360909322-1858-2-git-send-email-prakash.pm@ti.com>
On 2/15/2013 11:51 AM, Manjunathappa, Prakash wrote:
> Remove specifying mmc controller IP version information via platform
> data, instead specify device name so that driver derives it from
> platform_device_id table. Also change the clock node name to match
> the changed dev_id.
> Tested on da850-evm to make sure driver loads without clk_get failures.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
The patch looks good to me, but after this patch MMC/SD will be broken.
I suggest merging this into 2/5. It makes little sense without those
changes anyway.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-02-27 11:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 6:21 [PATCH v4 0/5] Add DT support for davinci_mmc driver Manjunathappa, Prakash
2013-02-15 6:21 ` Manjunathappa, Prakash
2013-02-15 6:21 ` [PATCH v4 1/5] ARM: davinci: mmc: derive version information from device name Manjunathappa, Prakash
2013-02-15 6:21 ` Manjunathappa, Prakash
2013-02-27 11:45 ` Sekhar Nori [this message]
2013-02-27 11:45 ` Sekhar Nori
2013-03-05 11:24 ` Manjunathappa, Prakash
2013-03-05 11:24 ` Manjunathappa, Prakash
2013-02-15 6:21 ` [PATCH v4 2/5] mmc: davinci_mmc: derive controller IP version from platform_device_id Manjunathappa, Prakash
2013-02-15 6:21 ` Manjunathappa, Prakash
2013-02-15 6:22 ` [PATCH v4 3/5] mmc: davinci_mmc: add DT support Manjunathappa, Prakash
2013-02-15 6:22 ` Manjunathappa, Prakash
2013-02-27 11:43 ` Sekhar Nori
2013-02-27 11:43 ` Sekhar Nori
2013-03-05 11:24 ` Manjunathappa, Prakash
2013-03-05 11:24 ` Manjunathappa, Prakash
2013-03-05 11:46 ` Sekhar Nori
2013-03-05 11:46 ` Sekhar Nori
2013-02-15 6:22 ` [PATCH v4 4/5] ARM: davinci: da850: add mmc DT entries Manjunathappa, Prakash
2013-02-15 6:22 ` Manjunathappa, Prakash
2013-02-15 6:22 ` Manjunathappa, Prakash
[not found] ` <1360909322-1858-1-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-02-15 6:22 ` [PATCH v4 5/5] ARM: davinci: da850: override mmc DT node device name Manjunathappa, Prakash
2013-02-15 6:22 ` Manjunathappa, Prakash
2013-02-15 6:22 ` Manjunathappa, Prakash
2013-02-27 14:04 ` Rob Herring
2013-02-27 14:04 ` Rob Herring
2013-02-28 10:51 ` Sekhar Nori
2013-02-28 10:51 ` Sekhar Nori
2013-02-28 10:51 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DF1F7.6010508@ti.com \
--to=nsekhar@ti.com \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=prakash.pm@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.