From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] libfdt: add fdt type definitions in libfdt_env.h
Date: Wed, 27 Feb 2013 11:05:24 -0600 [thread overview]
Message-ID: <512E3CD4.6000305@gmail.com> (raw)
In-Reply-To: <1361928975-29395-1-git-send-email-kim.phillips@freescale.com>
On 02/26/2013 07:36 PM, Kim Phillips wrote:
> in preparation for the forthcoming dtc update which adds fdt specific
> types: fdt{16,32,64}_t.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/arm/boot/compressed/libfdt_env.h | 4 ++++
> include/linux/libfdt_env.h | 6 ++++++
We should kill off arch/arm/boot/compressed/libfdt_env.h and use
include/linux/libfdt_env.h instead. The only reason I see why we have
both is the ARM version was introduced before include/linux/libfdt_env.h
existed.
Rob
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/compressed/libfdt_env.h b/arch/arm/boot/compressed/libfdt_env.h
> index 1f4e718..17ae0f3 100644
> --- a/arch/arm/boot/compressed/libfdt_env.h
> +++ b/arch/arm/boot/compressed/libfdt_env.h
> @@ -5,6 +5,10 @@
> #include <linux/string.h>
> #include <asm/byteorder.h>
>
> +typedef __be16 fdt16_t;
> +typedef __be32 fdt32_t;
> +typedef __be64 fdt64_t;
> +
> #define fdt16_to_cpu(x) be16_to_cpu(x)
> #define cpu_to_fdt16(x) cpu_to_be16(x)
> #define fdt32_to_cpu(x) be32_to_cpu(x)
> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> index 01508c7..da98097 100644
> --- a/include/linux/libfdt_env.h
> +++ b/include/linux/libfdt_env.h
> @@ -5,6 +5,12 @@
>
> #include <asm/byteorder.h>
>
> +typedef __be16 fdt16_t;
> +typedef __be32 fdt32_t;
> +typedef __be64 fdt64_t;
> +
> +#define fdt16_to_cpu(x) be16_to_cpu(x)
> +#define cpu_to_fdt16(x) cpu_to_be16(x)
> #define fdt32_to_cpu(x) be32_to_cpu(x)
> #define cpu_to_fdt32(x) cpu_to_be32(x)
> #define fdt64_to_cpu(x) be64_to_cpu(x)
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Russell King <linux@arm.linux.org.uk>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nico@linaro.org>
Subject: Re: [PATCH 1/3] libfdt: add fdt type definitions in libfdt_env.h
Date: Wed, 27 Feb 2013 11:05:24 -0600 [thread overview]
Message-ID: <512E3CD4.6000305@gmail.com> (raw)
In-Reply-To: <1361928975-29395-1-git-send-email-kim.phillips@freescale.com>
On 02/26/2013 07:36 PM, Kim Phillips wrote:
> in preparation for the forthcoming dtc update which adds fdt specific
> types: fdt{16,32,64}_t.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> arch/arm/boot/compressed/libfdt_env.h | 4 ++++
> include/linux/libfdt_env.h | 6 ++++++
We should kill off arch/arm/boot/compressed/libfdt_env.h and use
include/linux/libfdt_env.h instead. The only reason I see why we have
both is the ARM version was introduced before include/linux/libfdt_env.h
existed.
Rob
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/compressed/libfdt_env.h b/arch/arm/boot/compressed/libfdt_env.h
> index 1f4e718..17ae0f3 100644
> --- a/arch/arm/boot/compressed/libfdt_env.h
> +++ b/arch/arm/boot/compressed/libfdt_env.h
> @@ -5,6 +5,10 @@
> #include <linux/string.h>
> #include <asm/byteorder.h>
>
> +typedef __be16 fdt16_t;
> +typedef __be32 fdt32_t;
> +typedef __be64 fdt64_t;
> +
> #define fdt16_to_cpu(x) be16_to_cpu(x)
> #define cpu_to_fdt16(x) cpu_to_be16(x)
> #define fdt32_to_cpu(x) be32_to_cpu(x)
> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> index 01508c7..da98097 100644
> --- a/include/linux/libfdt_env.h
> +++ b/include/linux/libfdt_env.h
> @@ -5,6 +5,12 @@
>
> #include <asm/byteorder.h>
>
> +typedef __be16 fdt16_t;
> +typedef __be32 fdt32_t;
> +typedef __be64 fdt64_t;
> +
> +#define fdt16_to_cpu(x) be16_to_cpu(x)
> +#define cpu_to_fdt16(x) cpu_to_be16(x)
> #define fdt32_to_cpu(x) be32_to_cpu(x)
> #define cpu_to_fdt32(x) cpu_to_be32(x)
> #define fdt64_to_cpu(x) be64_to_cpu(x)
>
next prev parent reply other threads:[~2013-02-27 17:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 1:36 [PATCH 1/3] libfdt: add fdt type definitions in libfdt_env.h Kim Phillips
2013-02-27 1:36 ` Kim Phillips
2013-02-27 1:36 ` Kim Phillips
2013-02-27 1:36 ` [PATCH 2/3] dtc: import latest upstream dtc Kim Phillips
2013-02-27 1:36 ` Kim Phillips
2013-02-27 1:36 ` Kim Phillips
2013-02-27 3:08 ` Rob Landley
2013-02-27 3:08 ` Rob Landley
2013-02-27 16:45 ` Kim Phillips
2013-02-27 16:45 ` Kim Phillips
2013-02-27 16:45 ` Kim Phillips
2013-02-27 1:36 ` [PATCH 3/3] ARM: zImage: sparse fixes Kim Phillips
2013-02-27 1:36 ` Kim Phillips
2013-02-27 1:36 ` Kim Phillips
2013-02-27 17:05 ` Rob Herring [this message]
2013-02-27 17:05 ` [PATCH 1/3] libfdt: add fdt type definitions in libfdt_env.h Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512E3CD4.6000305@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.