All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Sheng-Hui <shhuiw@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfstests <xfs@oss.sgi.com>,
	linux-btrfs@vger.kernel.org, list.btrfs@jan-o-sch.net
Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'
Date: Thu, 28 Feb 2013 08:02:52 +0800	[thread overview]
Message-ID: <512E9EAC.9050700@gmail.com> (raw)
In-Reply-To: <20130227230443.GB5551@dastard>

On 2013年02月28日 07:04, Dave Chinner wrote:
> On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote:
>> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by
>> -x option of filefrag, and will fail with
>> 	'FIBMAP: Invalid argument'
>> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
>>      'FIEMAP failed with unsupported flags 2'
>> Remove the '-x' option.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
>
> I can see that this changes what gets dumped into the $seq.full
> file, but it seems to me that also changes the extent list returned
> to the checking functions. So either the test previously worked and
> now it fails with this change, or the test never worked and now it
> does, or perhaps something else?
>
> IOWs, I can't tell why you want to change this from the patch
> description, hence I don't know if the original behaviour was
> intentional or not.  Can you say describe what the overall effect of
> the change is in the commit description?

Hi Dave,

I run xfstests for btrfs against SLES11SP2, not upstream kernel.
In the seq.full, I can get the messages
	'FIEMAP failed with unsupported flags 2'

Then I found that the test will run 'filefrag -vx' on btrfs, and
'-v' will run FIEMAP_FLAG_XATTR, which is not supported by btrfs
yet, at least in 3.8 kernel.

Without the patch, I failed the testcase and got:
=============================================
276 8s ... - output mismatch (see 276.out.bad)
     --- 276.out	2013-02-25 19:08:58.000000000 -0600
     +++ 276.out.bad	2013-02-27 17:59:48.000000000 -0600
     @@ -1,4 +1,867 @@
      QA output created by 276
      *** test backref walking
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
      ...
      (Run 'diff -u 276.out 276.out.bad' to see the entire diff)
Ran: 276
Failures: 276
Failed 1 of 1 tests

In the 276.full, I got something like:
=============================================
# filefrag -vx /mnt/scratch/snap1/p0/d4/d21/d4a/f58
Filesystem type is: 9123683e
File size of /mnt/scratch/snap1/p0/d4/d21/d4a/f58 is 2125615 (33 blocks, blocksize 65536)
FIEMAP failed with unsupported flags 2


With the patch, I can pass the testcase:
=============================================
276 8s ... 7s
Ran: 276
Passed all 1 tests


>
> Cheers,
>
> Dave.
>


WARNING: multiple messages have this Message-ID (diff)
From: Wang Sheng-Hui <shhuiw@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: list.btrfs@jan-o-sch.net, linux-btrfs@vger.kernel.org,
	xfstests <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'
Date: Thu, 28 Feb 2013 08:02:52 +0800	[thread overview]
Message-ID: <512E9EAC.9050700@gmail.com> (raw)
In-Reply-To: <20130227230443.GB5551@dastard>

On 2013年02月28日 07:04, Dave Chinner wrote:
> On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote:
>> Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by
>> -x option of filefrag, and will fail with
>> 	'FIBMAP: Invalid argument'
>> for 'filefrag -vx'. 'filefrag -vx' fails on btrfs with
>>      'FIEMAP failed with unsupported flags 2'
>> Remove the '-x' option.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
>
> I can see that this changes what gets dumped into the $seq.full
> file, but it seems to me that also changes the extent list returned
> to the checking functions. So either the test previously worked and
> now it fails with this change, or the test never worked and now it
> does, or perhaps something else?
>
> IOWs, I can't tell why you want to change this from the patch
> description, hence I don't know if the original behaviour was
> intentional or not.  Can you say describe what the overall effect of
> the change is in the commit description?

Hi Dave,

I run xfstests for btrfs against SLES11SP2, not upstream kernel.
In the seq.full, I can get the messages
	'FIEMAP failed with unsupported flags 2'

Then I found that the test will run 'filefrag -vx' on btrfs, and
'-v' will run FIEMAP_FLAG_XATTR, which is not supported by btrfs
yet, at least in 3.8 kernel.

Without the patch, I failed the testcase and got:
=============================================
276 8s ... - output mismatch (see 276.out.bad)
     --- 276.out	2013-02-25 19:08:58.000000000 -0600
     +++ 276.out.bad	2013-02-27 17:59:48.000000000 -0600
     @@ -1,4 +1,867 @@
      QA output created by 276
      *** test backref walking
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
     +FIBMAP: Invalid argument
      ...
      (Run 'diff -u 276.out 276.out.bad' to see the entire diff)
Ran: 276
Failures: 276
Failed 1 of 1 tests

In the 276.full, I got something like:
=============================================
# filefrag -vx /mnt/scratch/snap1/p0/d4/d21/d4a/f58
Filesystem type is: 9123683e
File size of /mnt/scratch/snap1/p0/d4/d21/d4a/f58 is 2125615 (33 blocks, blocksize 65536)
FIEMAP failed with unsupported flags 2


With the patch, I can pass the testcase:
=============================================
276 8s ... 7s
Ran: 276
Passed all 1 tests


>
> Cheers,
>
> Dave.
>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-02-28  0:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27  7:15 [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument' Wang Sheng-Hui
2013-02-27  7:15 ` Wang Sheng-Hui
2013-02-27 23:04 ` Dave Chinner
2013-02-27 23:04   ` Dave Chinner
2013-02-27 23:11   ` Eric Sandeen
2013-02-27 23:11     ` Eric Sandeen
2013-02-28  0:02   ` Wang Sheng-Hui [this message]
2013-02-28  0:02     ` Wang Sheng-Hui
2013-02-28  0:25     ` Dave Chinner
2013-02-28  0:25       ` Dave Chinner
2013-02-28  2:05       ` Wang Sheng-Hui
2013-02-28  2:05         ` Wang Sheng-Hui
2013-03-05 18:43 ` Rich Johnston
2013-03-05 18:43   ` Rich Johnston
2013-05-26  9:35   ` Zhi Yong Wu
2013-05-26  9:35     ` Zhi Yong Wu
2013-05-26 17:35     ` Eric Sandeen
2013-05-26 17:35       ` Eric Sandeen
2013-05-27  2:02       ` Zhi Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512E9EAC.9050700@gmail.com \
    --to=shhuiw@gmail.com \
    --cc=david@fromorbit.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=list.btrfs@jan-o-sch.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.